1
0
Fork 0
forgejo/routers/repo
zeripath 858c35b731
Ensure BlameReaders close at end of request (#12102)
#11716 reports multiple git blame processes hanging around
this was thought to be due to timeouts, however on closer look this
appears to be due to the Close() function of the BlameReader hanging
with a blocked stdout pipe.

This PR fixes this Close function to:

* Cancel the context of the cmd
* Close the StdoutReader - ensuring that the output pipe is closed

Further it makes the context of the `git blame` command a child of the
request context - ensuring that even if Close() is not called, on
cancellation of the Request the blame is command will also be cancelled.

Fixes #11716
Closes #11727

Signed-off-by: Andrew Thornton <art27@cantab.net>
2020-07-01 14:01:17 +01:00
..
activity.go Add top author stats to activity page (#9615) 2020-01-20 12:07:30 +02:00
attachment.go Move dropzone.js to npm/webpack (#10645) 2020-03-07 21:06:15 +00:00
blame.go Ensure BlameReaders close at end of request (#12102) 2020-07-01 14:01:17 +01:00
branch.go Handle more pathological branch and tag names (#11843) 2020-06-11 19:49:47 -04:00
commit.go Show exact tag for commit on diff view (#11846) 2020-06-11 15:42:55 -04:00
compare.go Server-side syntax highlighting for all code (#12047) 2020-07-01 00:34:03 +03:00
download.go Fix download file wrong content-type (#9825) 2020-01-17 20:16:05 +08:00
editor.go Fix numbr of files, total additions, and deletions (#11614) 2020-05-26 01:58:07 -04:00
editor_test.go Add Close() method to gogitRepository (#8901) 2019-11-13 07:01:19 +00:00
http.go fix a small nit (#11834) 2020-06-10 11:26:28 -04:00
issue.go Add push commits history comment on PR time-line (#11167) 2020-05-20 09:47:24 -03:00
issue_dependency.go Fix wrong permissions check when issues/prs shared operations (#9885) 2020-01-20 13:00:32 +01:00
issue_label.go Add Organization Wide Labels (#10814) 2020-04-01 01:14:46 -03:00
issue_label_test.go fix go vet error (#3740) 2018-03-30 07:21:27 +08:00
issue_lock.go Implement "conversation lock" for issue comments (#5073) 2019-02-18 22:55:04 +02:00
issue_stopwatch.go Automatically clear stopwatch on merging a PR (#4327) 2019-02-05 13:38:11 +02:00
issue_timetrack.go [API] Extend times API (#9200) 2019-12-27 20:30:58 +00:00
issue_watch.go Fix PR/issue redirects when having external tracker (#9339) 2019-12-14 01:53:32 +01:00
lfs.go Migrate to go-git/go-git v5.0.0 (#10735) 2020-03-17 12:19:58 -04:00
main_test.go Unit tests for wiki routers (#3022) 2017-11-30 17:52:15 +02:00
middlewares.go Add gitea-vet (#10948) 2020-04-05 07:20:50 +01:00
milestone.go Show description on individual milestone view (#12055) 2020-06-25 21:21:13 -04:00
pull.go Handle more pathological branch and tag names (#11843) 2020-06-11 19:49:47 -04:00
pull_review.go Add a way to mark Conversation (code comment) resolved (#11037) 2020-04-18 10:50:25 -03:00
release.go Honor DEFAULT_PAGING_NUM for API (#11805) 2020-06-08 22:46:51 -04:00
release_test.go Add Close() method to gogitRepository (#8901) 2019-11-13 07:01:19 +00:00
repo.go Global default branch setting (#11918) 2020-06-17 16:53:55 -04:00
search.go Add detected file language to code search (#10256) 2020-02-20 16:53:55 -03:00
setting.go Fix doer of rename repo (#11789) 2020-06-07 18:23:13 +03:00
setting_protected_branch.go Prevent merge of outdated PRs on protected branches (#11012) 2020-04-16 22:00:36 -03:00
settings_test.go Stop various tests from adding to the source tree (#9515) 2019-12-28 10:08:05 +08:00
topic.go Add API endpoint for accessing repo topics (#7963) 2019-09-03 23:46:24 +08:00
view.go Server-side syntax highlighting for all code (#12047) 2020-07-01 00:34:03 +03:00
webhook.go Fix webhook template when validation errors occur (#11421) 2020-05-15 22:02:46 +03:00
wiki.go Allow different HardBreaks settings for documents and comments (#11515) 2020-05-24 09:14:26 +01:00
wiki_test.go Fix wiki raw view on sub path (#10002) 2020-01-28 09:44:08 +00:00