1
0
Fork 0
forgejo/modules/migrations
zeripath c58bc4bf80
Prevent timer leaks in Workerpool and others (#11333)
There is a potential memory leak in `Workerpool` due to the intricacies of
`time.Timer` stopping.

Whenever a `time.Timer` is `Stop`ped its channel must be cleared using a
`select` if the result of the `Stop()` is `false`.

Unfortunately in `Workerpool` these were checked the wrong way round.

However, there were a few other places that were not being checked.

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2020-05-08 16:46:05 +01:00
..
base When migrating from Gitlab map Approvals to approving Reviews (#11147) 2020-04-20 13:30:46 +01:00
error.go Improve migrations to support migrating milestones/labels/issues/comments/pullrequests (#6290) 2019-05-07 09:12:51 +08:00
git.go Migrate reviews when migrating repository from github (#9463) 2020-01-23 19:28:15 +02:00
gitea.go [BugFix] remove nil inserts in models (#11096) 2020-04-17 20:42:57 +03:00
gitea_test.go API add/generalize pagination (#9452) 2020-01-24 14:00:29 -05:00
github.go Prevent timer leaks in Workerpool and others (#11333) 2020-05-08 16:46:05 +01:00
github_test.go Migrate reviews when migrating repository from github (#9463) 2020-01-23 19:28:15 +02:00
gitlab.go When migrating from Gitlab map Approvals to approving Reviews (#11147) 2020-04-20 13:30:46 +01:00
gitlab_test.go When migrating from Gitlab map Approvals to approving Reviews (#11147) 2020-04-20 13:30:46 +01:00
main_test.go Improve migrations to support migrating milestones/labels/issues/comments/pullrequests (#6290) 2019-05-07 09:12:51 +08:00
migrate.go When migrating from Gitlab map Approvals to approving Reviews (#11147) 2020-04-20 13:30:46 +01:00
update.go Graceful: Xorm, RepoIndexer, Cron and Others (#9282) 2019-12-15 09:51:28 +00:00