1
0
Fork 0
forgejo/routers
Farid AYOUJIL f72ce26326
Add Content-Length header to HEAD requests (#14542)
* Add Content-Length header to HEAD requests

This change adds the header Content-Length to HEAD HTTP requests.

The previous behaviour was blocking some Windows executables (i.e
bitsadmin.exe) from downloading files hosted in Gitea.

This along with PR #14541, makes the web server compliant with HTTP RFC 2616 which states
"The methods GET and HEAD MUST be supported by all general-purpose servers"
and
"The HEAD method is identical to GET except that the server MUST NOT return a message-body in the response."

This should also respond to issues #8030 and #14532.

* This change adds the header Content-Length to HEAD HTTP requests

Pass the Size of the content as a parameter to ServeData() instead of
calculating it using ioutil.ReadAll(reader) --> this call is dangerous
and can result in a denial of service.

* Add Content-Length header to HEAD requests

Quick fix for imported dependency not used.

* Check if size is positiv int ...

Co-authored-by: zeripath <art27@cantab.net>
2021-02-05 21:10:40 +01:00
..
admin Update docs and comments to remove macaron (#14491) 2021-01-29 16:35:30 +01:00
api/v1 [API] GetRelease by tag only return release (#14397) 2021-02-04 04:12:25 +01:00
dev Display ui time with customize time location (#7792) 2019-08-15 22:46:21 +08:00
events Add EventSource support (#11235) 2020-05-07 22:49:00 +01:00
org Move macaron to chi (#14293) 2021-01-26 16:36:53 +01:00
private Move macaron to chi (#14293) 2021-01-26 16:36:53 +01:00
repo Add Content-Length header to HEAD requests (#14542) 2021-02-05 21:10:40 +01:00
routes Adding Chi's GetHead middleware (#14541) 2021-02-02 10:53:42 +02:00
user Honor REGISTER_MANUAL_CONFIRM when doing openid registration (#14548) 2021-02-05 04:03:20 +01:00
utils Return the full rejection message and errors in flash errors (#13221) 2020-10-20 19:50:10 -04:00
home.go [Feature] add precise search type for Elastic Search (#12869) 2021-01-27 12:00:35 +02:00
init.go Print usefull error if SQLite is used in settings but not supported (#14476) 2021-01-27 04:57:18 +01:00
install.go Move middlewares to web/middleware (#14480) 2021-01-30 10:55:53 +02:00
metrics.go Move metrics from macaron to chi (#13601) 2020-11-17 15:50:06 -05:00
swagger_json.go Move macaron to chi (#14293) 2021-01-26 16:36:53 +01:00