1
0
Fork 0
forgejo/models
oliverpool 0fc61c8836 [BUG] split code conversations in diff tab (#2306)
Follow-up of #2282 and #2296 (which tried to address #2278)

One of the issue with the previous PR is that when a conversation on the Files tab was marked as "resolved", it would fetch all the comments for that line (even the outdated ones, which should not be shown on this page - except when explicitly activated).

To properly fix this, I have changed `FetchCodeCommentsByLine` to `FetchCodeConversation`. Its role is to fetch all comments related to a given (review, path, line) and reverted my changes in the template (which were based on a misunderstanding).

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2306
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: oliverpool <git@olivier.pfad.fr>
Co-committed-by: oliverpool <git@olivier.pfad.fr>
2024-02-16 12:16:11 +00:00
..
actions Revert "Fix schedule tasks bugs (#28691)" 2024-02-05 16:54:42 +01:00
activities [MODERATION] Refactor excluding watchers mechanism (squash) 2024-02-05 15:56:58 +01:00
admin
asymkey [GITEA] Add noreply email address as verified for SSH signed Git commits 2024-02-05 16:09:40 +01:00
auth [GITEA] Fix session generation for database 2024-02-05 16:09:41 +01:00
avatars Refactor some legacy code and remove unused code (#28622) 2023-12-28 09:38:59 +00:00
db [FEAT] Don't log context cancelled SQL errors 2024-02-12 23:11:50 +01:00
dbfs
fixtures Merge branch 'rebase-forgejo-dependency' into wip-forgejo 2024-02-05 18:58:23 +01:00
forgejo/semver [SEMVER] store SemVer in ForgejoSemVer after a database upgrade 2024-02-05 14:44:33 +01:00
forgejo_migrations [GITEA] Allow changing the repo Wiki branch to main 2024-02-05 16:57:47 +01:00
git Revert "Fix schedule tasks bugs (#28691)" 2024-02-05 16:54:42 +01:00
issues [BUG] split code conversations in diff tab (#2306) 2024-02-16 12:16:11 +00:00
migrations Merge branch 'rebase-forgejo-dependency' into wip-forgejo 2024-02-05 18:58:23 +01:00
organization
packages Fix some RPM registry flaws (#28782) 2024-01-19 11:37:10 +00:00
perm [GITEA] Optionally allow anyone to edit Wikis 2024-02-05 16:09:42 +01:00
project
pull [GITEA] GetScheduledMergeByPullID may involve a system user 2024-02-05 16:09:41 +01:00
repo Add merge style fast-forward-only (#28954) 2024-02-14 17:19:19 +01:00
secret
shared/types
system Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
unit Add a direct link from repo header to unit settings 2024-02-13 22:42:09 +01:00
unittest [gitea] Remove unnecessary parameter (#29092) 2024-02-10 10:53:43 +01:00
user [gitea] Drop "@" from email sender to avoid spam filters (#29109) 2024-02-11 13:47:44 +01:00
webhook Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
error.go Add merge style fast-forward-only (#28954) 2024-02-14 17:19:19 +01:00
fixture_generation.go
fixture_test.go
main_test.go
org.go Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
org_team.go
org_team_test.go
org_test.go
repo.go Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
repo_test.go
repo_transfer.go [MODERATION] User blocking 2024-02-05 15:56:45 +01:00
repo_transfer_test.go [MODERATION] User blocking 2024-02-05 15:56:45 +01:00