1
0
Fork 0
forgejo/services
zeripath edfebe65b1
Finally fix diff names (#13136)
* Finally fix diff names

#12771 attempted to fix diff by avoiding the git diff line as
it is possible to have an ambiguous line here.

#12254 attempted to fix diff by assuming that names would quoted
if they needed to be and if one was quoted then both would be.

Both of these were wrong.

I have now discovered `--src-prefix` and `--dst-prefix` which
means that we can set this in such a way to force the git diff
to always be unambiguous.

Therefore this PR rollsback most of the changes in #12771 and
uses these options to fix this.

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Update services/gitdiff/gitdiff.go

* Update services/gitdiff/gitdiff.go

* Update modules/repofiles/temp_repo.go

* fix test

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: Lauris BH <lauris@nix.lv>
2020-10-14 07:49:33 +03:00
..
comments Refactor pull request review (#8954) 2019-11-14 10:57:36 +08:00
externalaccount Allow externalID to be UUID (#8551) 2019-10-17 10:06:28 +08:00
gitdiff Finally fix diff names (#13136) 2020-10-14 07:49:33 +03:00
issue Add team support for review request (#12039) 2020-10-12 20:55:13 +01:00
mailer Fix "only mail on mention" bug (#12775) 2020-09-09 15:08:55 -04:00
mirror Mirror: Update DB on Address-Update too (#12964) 2020-09-28 15:00:52 -04:00
pull [Enhancement] Allow admin to merge pr with protected file changes (#12078) 2020-10-13 14:50:57 -04:00
release Add a storage layer for attachments (#11387) 2020-08-18 12:23:45 +08:00
repository Move update-server-info to hooks (#12826) 2020-10-14 00:24:06 +08:00
wiki Update golangci-lint to version 1.31.0 (#13102) 2020-10-11 21:27:20 +01:00