The post step was always waiting, even if all steps were done. Then, once the task was done, the post step became success immediately. Before: <img width="915" alt="xnip_240320_120228" src="https://github.com/go-gitea/gitea/assets/9418365/00347430-f998-4c43-917a-bf6dd6d0e333"> After: <img width="905" alt="xnip_240320_120443" src="https://github.com/go-gitea/gitea/assets/9418365/a419b111-17c2-4029-a022-c761cc419091"> (cherry picked from commit 35cfd98e121005f90f6d0d55d9a69e37d7990010)
		
			
				
	
	
		
			146 lines
		
	
	
	
		
			5.7 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			146 lines
		
	
	
	
		
			5.7 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
// Copyright 2022 The Gitea Authors. All rights reserved.
 | 
						|
// SPDX-License-Identifier: MIT
 | 
						|
 | 
						|
package actions
 | 
						|
 | 
						|
import (
 | 
						|
	"testing"
 | 
						|
 | 
						|
	actions_model "code.gitea.io/gitea/models/actions"
 | 
						|
 | 
						|
	"github.com/stretchr/testify/assert"
 | 
						|
)
 | 
						|
 | 
						|
func TestFullSteps(t *testing.T) {
 | 
						|
	tests := []struct {
 | 
						|
		name string
 | 
						|
		task *actions_model.ActionTask
 | 
						|
		want []*actions_model.ActionTaskStep
 | 
						|
	}{
 | 
						|
		{
 | 
						|
			name: "regular",
 | 
						|
			task: &actions_model.ActionTask{
 | 
						|
				Steps: []*actions_model.ActionTaskStep{
 | 
						|
					{Status: actions_model.StatusSuccess, LogIndex: 10, LogLength: 80, Started: 10010, Stopped: 10090},
 | 
						|
				},
 | 
						|
				Status:    actions_model.StatusSuccess,
 | 
						|
				Started:   10000,
 | 
						|
				Stopped:   10100,
 | 
						|
				LogLength: 100,
 | 
						|
			},
 | 
						|
			want: []*actions_model.ActionTaskStep{
 | 
						|
				{Name: preStepName, Status: actions_model.StatusSuccess, LogIndex: 0, LogLength: 10, Started: 10000, Stopped: 10010},
 | 
						|
				{Status: actions_model.StatusSuccess, LogIndex: 10, LogLength: 80, Started: 10010, Stopped: 10090},
 | 
						|
				{Name: postStepName, Status: actions_model.StatusSuccess, LogIndex: 90, LogLength: 10, Started: 10090, Stopped: 10100},
 | 
						|
			},
 | 
						|
		},
 | 
						|
		{
 | 
						|
			name: "failed step",
 | 
						|
			task: &actions_model.ActionTask{
 | 
						|
				Steps: []*actions_model.ActionTaskStep{
 | 
						|
					{Status: actions_model.StatusSuccess, LogIndex: 10, LogLength: 20, Started: 10010, Stopped: 10020},
 | 
						|
					{Status: actions_model.StatusFailure, LogIndex: 30, LogLength: 60, Started: 10020, Stopped: 10090},
 | 
						|
					{Status: actions_model.StatusCancelled, LogIndex: 0, LogLength: 0, Started: 0, Stopped: 0},
 | 
						|
				},
 | 
						|
				Status:    actions_model.StatusFailure,
 | 
						|
				Started:   10000,
 | 
						|
				Stopped:   10100,
 | 
						|
				LogLength: 100,
 | 
						|
			},
 | 
						|
			want: []*actions_model.ActionTaskStep{
 | 
						|
				{Name: preStepName, Status: actions_model.StatusSuccess, LogIndex: 0, LogLength: 10, Started: 10000, Stopped: 10010},
 | 
						|
				{Status: actions_model.StatusSuccess, LogIndex: 10, LogLength: 20, Started: 10010, Stopped: 10020},
 | 
						|
				{Status: actions_model.StatusFailure, LogIndex: 30, LogLength: 60, Started: 10020, Stopped: 10090},
 | 
						|
				{Status: actions_model.StatusCancelled, LogIndex: 0, LogLength: 0, Started: 0, Stopped: 0},
 | 
						|
				{Name: postStepName, Status: actions_model.StatusFailure, LogIndex: 90, LogLength: 10, Started: 10090, Stopped: 10100},
 | 
						|
			},
 | 
						|
		},
 | 
						|
		{
 | 
						|
			name: "first step is running",
 | 
						|
			task: &actions_model.ActionTask{
 | 
						|
				Steps: []*actions_model.ActionTaskStep{
 | 
						|
					{Status: actions_model.StatusRunning, LogIndex: 10, LogLength: 80, Started: 10010, Stopped: 0},
 | 
						|
				},
 | 
						|
				Status:    actions_model.StatusRunning,
 | 
						|
				Started:   10000,
 | 
						|
				Stopped:   10100,
 | 
						|
				LogLength: 100,
 | 
						|
			},
 | 
						|
			want: []*actions_model.ActionTaskStep{
 | 
						|
				{Name: preStepName, Status: actions_model.StatusSuccess, LogIndex: 0, LogLength: 10, Started: 10000, Stopped: 10010},
 | 
						|
				{Status: actions_model.StatusRunning, LogIndex: 10, LogLength: 80, Started: 10010, Stopped: 0},
 | 
						|
				{Name: postStepName, Status: actions_model.StatusWaiting, LogIndex: 0, LogLength: 0, Started: 0, Stopped: 0},
 | 
						|
			},
 | 
						|
		},
 | 
						|
		{
 | 
						|
			name: "first step has canceled",
 | 
						|
			task: &actions_model.ActionTask{
 | 
						|
				Steps: []*actions_model.ActionTaskStep{
 | 
						|
					{Status: actions_model.StatusCancelled, LogIndex: 0, LogLength: 0, Started: 0, Stopped: 0},
 | 
						|
				},
 | 
						|
				Status:    actions_model.StatusFailure,
 | 
						|
				Started:   10000,
 | 
						|
				Stopped:   10100,
 | 
						|
				LogLength: 100,
 | 
						|
			},
 | 
						|
			want: []*actions_model.ActionTaskStep{
 | 
						|
				{Name: preStepName, Status: actions_model.StatusFailure, LogIndex: 0, LogLength: 100, Started: 10000, Stopped: 10100},
 | 
						|
				{Status: actions_model.StatusCancelled, LogIndex: 0, LogLength: 0, Started: 0, Stopped: 0},
 | 
						|
				{Name: postStepName, Status: actions_model.StatusFailure, LogIndex: 100, LogLength: 0, Started: 10100, Stopped: 10100},
 | 
						|
			},
 | 
						|
		},
 | 
						|
		{
 | 
						|
			name: "empty steps",
 | 
						|
			task: &actions_model.ActionTask{
 | 
						|
				Steps:     []*actions_model.ActionTaskStep{},
 | 
						|
				Status:    actions_model.StatusSuccess,
 | 
						|
				Started:   10000,
 | 
						|
				Stopped:   10100,
 | 
						|
				LogLength: 100,
 | 
						|
			},
 | 
						|
			want: []*actions_model.ActionTaskStep{
 | 
						|
				{Name: preStepName, Status: actions_model.StatusSuccess, LogIndex: 0, LogLength: 100, Started: 10000, Stopped: 10100},
 | 
						|
				{Name: postStepName, Status: actions_model.StatusSuccess, LogIndex: 100, LogLength: 0, Started: 10100, Stopped: 10100},
 | 
						|
			},
 | 
						|
		},
 | 
						|
		{
 | 
						|
			name: "all steps finished but task is running",
 | 
						|
			task: &actions_model.ActionTask{
 | 
						|
				Steps: []*actions_model.ActionTaskStep{
 | 
						|
					{Status: actions_model.StatusSuccess, LogIndex: 10, LogLength: 80, Started: 10010, Stopped: 10090},
 | 
						|
				},
 | 
						|
				Status:    actions_model.StatusRunning,
 | 
						|
				Started:   10000,
 | 
						|
				Stopped:   0,
 | 
						|
				LogLength: 100,
 | 
						|
			},
 | 
						|
			want: []*actions_model.ActionTaskStep{
 | 
						|
				{Name: preStepName, Status: actions_model.StatusSuccess, LogIndex: 0, LogLength: 10, Started: 10000, Stopped: 10010},
 | 
						|
				{Status: actions_model.StatusSuccess, LogIndex: 10, LogLength: 80, Started: 10010, Stopped: 10090},
 | 
						|
				{Name: postStepName, Status: actions_model.StatusRunning, LogIndex: 90, LogLength: 10, Started: 10090, Stopped: 0},
 | 
						|
			},
 | 
						|
		},
 | 
						|
		{
 | 
						|
			name: "skipped task",
 | 
						|
			task: &actions_model.ActionTask{
 | 
						|
				Steps: []*actions_model.ActionTaskStep{
 | 
						|
					{Status: actions_model.StatusSkipped, LogIndex: 0, LogLength: 0, Started: 0, Stopped: 0},
 | 
						|
				},
 | 
						|
				Status:    actions_model.StatusSkipped,
 | 
						|
				Started:   0,
 | 
						|
				Stopped:   0,
 | 
						|
				LogLength: 0,
 | 
						|
			},
 | 
						|
			want: []*actions_model.ActionTaskStep{
 | 
						|
				{Name: preStepName, Status: actions_model.StatusSkipped, LogIndex: 0, LogLength: 0, Started: 0, Stopped: 0},
 | 
						|
				{Status: actions_model.StatusSkipped, LogIndex: 0, LogLength: 0, Started: 0, Stopped: 0},
 | 
						|
				{Name: postStepName, Status: actions_model.StatusSkipped, LogIndex: 0, LogLength: 0, Started: 0, Stopped: 0},
 | 
						|
			},
 | 
						|
		},
 | 
						|
	}
 | 
						|
	for _, tt := range tests {
 | 
						|
		t.Run(tt.name, func(t *testing.T) {
 | 
						|
			assert.Equalf(t, tt.want, FullSteps(tt.task), "FullSteps(%v)", tt.task)
 | 
						|
		})
 | 
						|
	}
 | 
						|
}
 |