forks/forgejo
1
0
Fork 0
Code Releases Activity
forgejo/models
History
qwerty287 9d943bf374
Add missing X-Total-Count and fix some related bugs (#17968) 
* Add missing `X-Total-Count` and fix some related bugs

Adds `X-Total-Count` header to APIs that return a list but doesn't have it yet.
Fixed bugs:
* not returned after reporting error (39eb82446c/routers/api/v1/user/star.go (L70))
* crash with index out of bounds, API issue/issueSubscriptions

I also found various endpoints that return lists but do not apply/support pagination yet:
```
/repos/{owner}/{repo}/issues/{index}/labels
/repos/{owner}/{repo}/issues/comments/{id}/reactions
/repos/{owner}/{repo}/branch_protections
/repos/{owner}/{repo}/contents
/repos/{owner}/{repo}/hooks/git
/repos/{owner}/{repo}/issue_templates
/repos/{owner}/{repo}/releases/{id}/assets
/repos/{owner}/{repo}/reviewers
/repos/{owner}/{repo}/teams
/user/emails
/users/{username}/heatmap
```
If this is not expected, an new issue should be opened.

Closes #13043

* fmt

* Update routers/api/v1/repo/issue_subscription.go

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>

* Use FindAndCount

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: 6543 <6543@obermui.de>
2021-12-15 13:39:34 +08:00
..
admin Move user/org deletion to services (#17673) 2021-11-19 01:42:27 +08:00
appstate Sync gitea app path for git hooks and authorized keys when starting (#17335) 2021-10-21 17:22:43 +08:00
asymkey Move keys to models/asymkey (#17917) 2021-12-10 16:14:24 +08:00
avatars Multiple Escaping Improvements (#17551) 2021-11-16 18:18:25 +00:00
db Move keys to models/asymkey (#17917) 2021-12-10 16:14:24 +08:00
fixtures Allow U2F 2FA without TOTP (#11573) 2021-11-08 23:47:19 +01:00
issues Improvements to content history (#17746) 2021-11-22 20:20:16 +08:00
login Remove NewSession method from db.Engine interface (#17577) 2021-11-21 23:41:00 +08:00
migrations Prevent services/mailer/mailer_test.go tests from deleteing data directory (#17941) 2021-12-10 19:43:28 +00:00
perm Move accessmode into models/perm (#17828) 2021-11-28 12:58:28 +01:00
repo Prevent deadlock in create issue (#17970) 2021-12-13 17:59:39 -05:00
unit Move unit into models/unit/ (#17576) 2021-11-09 20:57:58 +01:00
unittest Prevent services/mailer/mailer_test.go tests from deleteing data directory (#17941) 2021-12-10 19:43:28 +00:00
user Add Option to synchronize Admin & Restricted states from OIDC/OAuth2 along with Setting Scopes (#16766) 2021-12-14 16:37:11 +08:00
webhook Remove NewSession method from db.Engine interface (#17577) 2021-11-21 23:41:00 +08:00
access.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
access_test.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
action.go Some repository refactors (#17950) 2021-12-12 23:48:20 +08:00
action_list.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
action_test.go Some repository refactors (#17950) 2021-12-12 23:48:20 +08:00
branches.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
branches_test.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
commit.go Move keys to models/asymkey (#17917) 2021-12-10 16:14:24 +08:00
commit_status.go Add missing X-Total-Count and fix some related bugs (#17968) 2021-12-15 13:39:34 +08:00
commit_status_test.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
consistency.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
consistency_test.go A better go code formatter, and now make fmt can run in Windows (#17684) 2021-11-17 20:34:35 +08:00
engine_test.go Refactor install page (db type) (#17919) 2021-12-07 13:44:08 +08:00
error.go Some repository refactors (#17950) 2021-12-12 23:48:20 +08:00
fixture_generation.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
fixture_test.go Decouple unit test code from business code (#17623) 2021-11-12 22:36:47 +08:00
helper.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
helper_directory.go refactor: move from io/ioutil to io and os package (#17109) 2021-09-22 13:38:34 +08:00
helper_environment.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
issue.go Add missing X-Total-Count and fix some related bugs (#17968) 2021-12-15 13:39:34 +08:00
issue_assignees.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
issue_assignees_test.go Move user related model into models/user (#17781) 2021-11-24 17:49:20 +08:00
issue_comment.go Add missing X-Total-Count and fix some related bugs (#17968) 2021-12-15 13:39:34 +08:00
issue_comment_list.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
issue_comment_test.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
issue_dependency.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
issue_dependency_test.go Move user related model into models/user (#17781) 2021-11-24 17:49:20 +08:00
issue_label.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
issue_label_test.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
issue_list.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
issue_list_test.go Decouple unit test, remove intermediate unittestbridge package (#17662) 2021-11-16 16:53:21 +08:00
issue_lock.go Move user related model into models/user (#17781) 2021-11-24 17:49:20 +08:00
issue_milestone.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
issue_milestone_test.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
issue_reaction.go Add missing X-Total-Count and fix some related bugs (#17968) 2021-12-15 13:39:34 +08:00
issue_reaction_test.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
issue_stopwatch.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
issue_stopwatch_test.go Move user related model into models/user (#17781) 2021-11-24 17:49:20 +08:00
issue_test.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
issue_tracked_time.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
issue_tracked_time_test.go Move user related model into models/user (#17781) 2021-11-24 17:49:20 +08:00
issue_user.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
issue_user_test.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
issue_watch.go Add missing X-Total-Count and fix some related bugs (#17968) 2021-12-15 13:39:34 +08:00
issue_watch_test.go A better go code formatter, and now make fmt can run in Windows (#17684) 2021-11-17 20:34:35 +08:00
issue_xref.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
issue_xref_test.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
lfs.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
lfs_lock.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
main_test.go Move keys to models/asymkey (#17917) 2021-12-10 16:14:24 +08:00
migrate.go Move more model into models/user (#17826) 2021-11-28 22:11:58 +08:00
notification.go Some repository refactors (#17950) 2021-12-12 23:48:20 +08:00
notification_test.go Move user related model into models/user (#17781) 2021-11-24 17:49:20 +08:00
org.go Some repository refactors (#17950) 2021-12-12 23:48:20 +08:00
org_team.go Some repository refactors (#17950) 2021-12-12 23:48:20 +08:00
org_team_test.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
org_test.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
project.go Remove NewSession method from db.Engine interface (#17577) 2021-11-21 23:41:00 +08:00
project_board.go Support sorting for project board issuses (#17152) 2021-12-08 14:57:18 +08:00
project_issue.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
project_test.go Decouple unit test code from business code (#17623) 2021-11-12 22:36:47 +08:00
protected_tag.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
protected_tag_test.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
pull.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
pull_list.go Move user related model into models/user (#17781) 2021-11-24 17:49:20 +08:00
pull_test.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
release.go Some repository refactors (#17950) 2021-12-12 23:48:20 +08:00
repo.go Improve behavior of "Fork" button (#17288) 2021-12-13 09:59:09 +08:00
repo_activity.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
repo_collaboration.go Some repository refactors (#17950) 2021-12-12 23:48:20 +08:00
repo_collaboration_test.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
repo_generate.go Some repository refactors (#17950) 2021-12-12 23:48:20 +08:00
repo_generate_test.go Fixed assert statements. (#16089) 2021-06-07 07:27:09 +02:00
repo_list.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
repo_list_test.go Decouple unit test, remove intermediate unittestbridge package (#17662) 2021-11-16 16:53:21 +08:00
repo_permission.go Some repository refactors (#17950) 2021-12-12 23:48:20 +08:00
repo_permission_test.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
repo_test.go Some repository refactors (#17950) 2021-12-12 23:48:20 +08:00
repo_transfer.go Some repository refactors (#17950) 2021-12-12 23:48:20 +08:00
repo_transfer_test.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
review.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
review_test.go Move user related model into models/user (#17781) 2021-11-24 17:49:20 +08:00
statistic.go Some repository refactors (#17950) 2021-12-12 23:48:20 +08:00
task.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
token.go Fix problem when database ID is not incremented as expected (#17229) 2021-10-06 15:36:24 -05:00
token_test.go A better go code formatter, and now make fmt can run in Windows (#17684) 2021-11-17 20:34:35 +08:00
upload.go Remove NewSession method from db.Engine interface (#17577) 2021-11-21 23:41:00 +08:00
user.go Some repository refactors (#17950) 2021-12-12 23:48:20 +08:00
user_heatmap.go Move user related model into models/user (#17781) 2021-11-24 17:49:20 +08:00
user_heatmap_test.go Move user related model into models/user (#17781) 2021-11-24 17:49:20 +08:00
user_test.go Move keys to models/asymkey (#17917) 2021-12-10 16:14:24 +08:00
userlist.go Move more model into models/user (#17826) 2021-11-28 22:11:58 +08:00
userlist_test.go Move more model into models/user (#17826) 2021-11-28 22:11:58 +08:00