1
0
Fork 0
gitea/services
Giteabot 8b590de186
Fix migration panic due to an empty review comment diff (#28334) (#28362)
Backport #28334 by @lng2020

Fix #28328 
```
func (p *PullRequestComment) GetDiffHunk() string {
	if p == nil || p.DiffHunk == nil {
		return ""
	}
	return *p.DiffHunk
}
```
This function in the package `go-github` may return an empty diff. When
it's empty, the following code will panic because it access `ss[1]`

ec1feedbf5/services/migrations/gitea_uploader.go (L861-L867)

ec1feedbf5/modules/git/diff.go (L97-L101)

Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com>
2023-12-05 16:58:15 +08:00
..
actions
agit
asymkey
attachment
auth Unify two factor check (#27915) (#27929) 2023-11-06 18:07:22 +00:00
automerge
context
convert
cron
externalaccount
feed
forms Fix required error for token name (#28267) (#28284) 2023-11-29 23:00:32 +08:00
gitdiff
indexer Fix missing issue search index update when changing status (#28325) (#28330) 2023-12-03 11:43:17 +00:00
issue
lfs
mailer Clean up template locale usage (#27856) (#27857) 2023-10-31 17:35:55 +01:00
markup
migrations Fix migration panic due to an empty review comment diff (#28334) (#28362) 2023-12-05 16:58:15 +08:00
mirror
notify
org Delete repos of org when purge delete user (#27273) (#27728) 2023-11-01 10:03:12 +08:00
packages Fix RPM/Debian signature key creation (#28352) (#28353) 2023-12-05 13:42:41 +08:00
pull
release Fix comment permissions (#28213) (#28216) 2023-11-25 23:43:23 +00:00
repository Delete repos of org when purge delete user (#27273) (#27728) 2023-11-01 10:03:12 +08:00
secrets
task
uinotification
user Remove action runners on user deletion (#27902) (#27908) 2023-11-05 13:20:00 +00:00
webhook Fix comment permissions (#28213) (#28216) 2023-11-25 23:43:23 +00:00
wiki