1
0
Fork 0
gitea/models
Gusted ebe569a268
Set correct PR status on 3way on conflict checking (#19457)
* Set correct PR status on 3way on conflict checking

- When 3-way merge is enabled for conflict checking, it has a new
interesting behavior that it doesn't return any error when it found a
conflict, so we change the condition to not check for the error, but
instead check if conflictedfiles is populated, this fixes a issue
whereby PR status wasn't correctly on conflicted PR's.
- Refactor the mergeable property(which was incorrectly set and lead me this
bug) to be more maintainable.
- Add a dedicated test for conflicting checking, so it should prevent
future issues with this.

* Fix linter
2022-04-21 22:55:45 +01:00
..
admin Use a struct as test options (#19393) 2022-04-14 21:58:21 +08:00
appstate
asymkey Use a struct as test options (#19393) 2022-04-14 21:58:21 +08:00
auth Use a struct as test options (#19393) 2022-04-14 21:58:21 +08:00
avatars
db Use a struct as test options (#19393) 2022-04-14 21:58:21 +08:00
fixtures
foreignreference
issues Use a struct as test options (#19393) 2022-04-14 21:58:21 +08:00
migrations
organization Fix panic in team repos API (#19431) 2022-04-20 18:43:26 +08:00
packages Add Helm Chart registry (#19406) 2022-04-19 12:55:35 -04:00
perm
project Use a struct as test options (#19393) 2022-04-14 21:58:21 +08:00
repo Use a struct as test options (#19393) 2022-04-14 21:58:21 +08:00
unit
unittest Use a struct as test options (#19393) 2022-04-14 21:58:21 +08:00
user Use a struct as test options (#19393) 2022-04-14 21:58:21 +08:00
webhook Use a struct as test options (#19393) 2022-04-14 21:58:21 +08:00
access.go
access_test.go
action.go Move milestone to models/issues/ (#19278) 2022-04-08 17:11:15 +08:00
action_list.go
action_test.go
branches.go
branches_test.go
commit.go
commit_status.go
commit_status_test.go
consistency.go
consistency_test.go Move milestone to models/issues/ (#19278) 2022-04-08 17:11:15 +08:00
engine_test.go
error.go Move milestone to models/issues/ (#19278) 2022-04-08 17:11:15 +08:00
fixture_generation.go
fixture_test.go
helper.go
helper_directory.go
helper_environment.go
issue.go Move milestone to models/issues/ (#19278) 2022-04-08 17:11:15 +08:00
issue_assignees.go Move milestone to models/issues/ (#19278) 2022-04-08 17:11:15 +08:00
issue_assignees_test.go
issue_comment.go Move milestone to models/issues/ (#19278) 2022-04-08 17:11:15 +08:00
issue_comment_list.go Move milestone to models/issues/ (#19278) 2022-04-08 17:11:15 +08:00
issue_comment_test.go
issue_dependency.go
issue_dependency_test.go
issue_label.go Move milestone to models/issues/ (#19278) 2022-04-08 17:11:15 +08:00
issue_label_test.go
issue_list.go Move milestone to models/issues/ (#19278) 2022-04-08 17:11:15 +08:00
issue_list_test.go
issue_lock.go Move milestone to models/issues/ (#19278) 2022-04-08 17:11:15 +08:00
issue_project.go Move milestone to models/issues/ (#19278) 2022-04-08 17:11:15 +08:00
issue_stopwatch.go Move milestone to models/issues/ (#19278) 2022-04-08 17:11:15 +08:00
issue_stopwatch_test.go
issue_test.go Move milestone to models/issues/ (#19278) 2022-04-08 17:11:15 +08:00
issue_tracked_time.go Move milestone to models/issues/ (#19278) 2022-04-08 17:11:15 +08:00
issue_tracked_time_test.go
issue_user.go
issue_user_test.go
issue_watch.go
issue_watch_test.go
issue_xref.go Move milestone to models/issues/ (#19278) 2022-04-08 17:11:15 +08:00
issue_xref_test.go
lfs.go
lfs_lock.go
main_test.go Use a struct as test options (#19393) 2022-04-14 21:58:21 +08:00
migrate.go Move milestone to models/issues/ (#19278) 2022-04-08 17:11:15 +08:00
migrate_test.go Move milestone to models/issues/ (#19278) 2022-04-08 17:11:15 +08:00
notification.go Move milestone to models/issues/ (#19278) 2022-04-08 17:11:15 +08:00
notification_test.go
org.go
org_team.go
org_team_test.go
org_test.go
protected_tag.go
protected_tag_test.go
pull.go Set correct PR status on 3way on conflict checking (#19457) 2022-04-21 22:55:45 +01:00
pull_list.go
pull_test.go
release.go
repo.go Move milestone to models/issues/ (#19278) 2022-04-08 17:11:15 +08:00
repo_activity.go
repo_collaboration.go
repo_collaboration_test.go
repo_generate.go
repo_generate_test.go
repo_list.go
repo_list_test.go
repo_permission.go
repo_permission_test.go
repo_test.go
repo_transfer.go
repo_transfer_test.go
review.go Move milestone to models/issues/ (#19278) 2022-04-08 17:11:15 +08:00
review_test.go
statistic.go Move milestone to models/issues/ (#19278) 2022-04-08 17:11:15 +08:00
task.go
token.go
token_test.go
upload.go
user.go
user_heatmap.go
user_heatmap_test.go
user_test.go
userlist.go
userlist_test.go