forks/miniflux
1
0
Fork 0
Code Releases Activity

Do no rewrite Youtube description twice in "add_youtube_video" rule

Browse source 
This is already done before in <media:description>.
This commit is contained in:
Frédéric Guillot 2019-11-30 22:46:12 -08:00
parent 6291b59849
commit 120d6ec7d8
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
reader/rewrite/rewrite_functions.go
View file

@ -143,7 +143,7 @@ func addYoutubeVideo(entryURL, entryContent string) string {
if len(matches) == 2 { if len(matches) == 2 {
video := `<iframe width="650" height="350" frameborder="0" src="https://www.youtube-nocookie.com/embed/` + matches[1] + `" allowfullscreen></iframe>` video := `<iframe width="650" height="350" frameborder="0" src="https://www.youtube-nocookie.com/embed/` + matches[1] + `" allowfullscreen></iframe>`
return video + "<p>" + replaceLineFeeds(replaceTextLinks(entryContent)) + "</p>" return video + `<br>` + entryContent
} }
return entryContent return entryContent
} }

4
reader/rewrite/rewriter_test.go
View file

@ -36,8 +36,8 @@ func TestRewriteWithNoMatchingRule(t *testing.T) {
} }
func TestRewriteWithYoutubeLink(t *testing.T) { func TestRewriteWithYoutubeLink(t *testing.T) {
output := Rewriter("https://www.youtube.com/watch?v=1234", "Video Description\nhttp://example.org/path", ``) output := Rewriter("https://www.youtube.com/watch?v=1234", "Video Description", ``)
expected := `<iframe width="650" height="350" frameborder="0" src="https://www.youtube-nocookie.com/embed/1234" allowfullscreen></iframe><p>Video Description<br><a href="http://example.org/path">http://example.org/path</a></p>` expected := `<iframe width="650" height="350" frameborder="0" src="https://www.youtube-nocookie.com/embed/1234" allowfullscreen></iframe><br>Video Description`
if expected != output { if expected != output {
t.Errorf(`Not expected output: got "%s" instead of "%s"`, output, expected) t.Errorf(`Not expected output: got "%s" instead of "%s"`, output, expected)