fix: do not alter the original URL if there is no tracker parameter
This commit is contained in:
parent
92f3dc26e4
commit
37309adbc0
2 changed files with 28 additions and 9 deletions
|
@ -78,14 +78,21 @@ func RemoveTrackingParameters(inputURL string) (string, error) {
|
||||||
}
|
}
|
||||||
|
|
||||||
queryParams := parsedURL.Query()
|
queryParams := parsedURL.Query()
|
||||||
|
hasTrackers := false
|
||||||
|
|
||||||
// Remove tracking parameters
|
// Remove tracking parameters
|
||||||
for param := range queryParams {
|
for param := range queryParams {
|
||||||
if trackingParams[strings.ToLower(param)] {
|
if trackingParams[strings.ToLower(param)] {
|
||||||
queryParams.Del(param)
|
queryParams.Del(param)
|
||||||
|
hasTrackers = true
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Do not modify the URL if there are no tracking parameters
|
||||||
|
if !hasTrackers {
|
||||||
|
return inputURL, nil
|
||||||
|
}
|
||||||
|
|
||||||
parsedURL.RawQuery = queryParams.Encode()
|
parsedURL.RawQuery = queryParams.Encode()
|
||||||
|
|
||||||
// Remove trailing "?" if query string is empty
|
// Remove trailing "?" if query string is empty
|
||||||
|
|
|
@ -14,6 +14,7 @@ func TestRemoveTrackingParams(t *testing.T) {
|
||||||
name string
|
name string
|
||||||
input string
|
input string
|
||||||
expected string
|
expected string
|
||||||
|
strictComparison bool
|
||||||
}{
|
}{
|
||||||
{
|
{
|
||||||
name: "URL with tracking parameters",
|
name: "URL with tracking parameters",
|
||||||
|
@ -34,6 +35,7 @@ func TestRemoveTrackingParams(t *testing.T) {
|
||||||
name: "URL with no parameters",
|
name: "URL with no parameters",
|
||||||
input: "https://example.com/page",
|
input: "https://example.com/page",
|
||||||
expected: "https://example.com/page",
|
expected: "https://example.com/page",
|
||||||
|
strictComparison: true,
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: "URL with mixed case tracking parameters",
|
name: "URL with mixed case tracking parameters",
|
||||||
|
@ -60,6 +62,12 @@ func TestRemoveTrackingParams(t *testing.T) {
|
||||||
input: "https://example.com/page?name=John%20Doe&utm_source=newsletter",
|
input: "https://example.com/page?name=John%20Doe&utm_source=newsletter",
|
||||||
expected: "https://example.com/page?name=John+Doe",
|
expected: "https://example.com/page?name=John+Doe",
|
||||||
},
|
},
|
||||||
|
{
|
||||||
|
name: "Non-standard URL parameter with no tracker",
|
||||||
|
input: "https://example.com/foo.jpg?crop/1420x708/format/webp",
|
||||||
|
expected: "https://example.com/foo.jpg?crop/1420x708/format/webp",
|
||||||
|
strictComparison: true,
|
||||||
|
},
|
||||||
{
|
{
|
||||||
name: "Invalid URL",
|
name: "Invalid URL",
|
||||||
input: "https://example|org/",
|
input: "https://example|org/",
|
||||||
|
@ -69,6 +77,7 @@ func TestRemoveTrackingParams(t *testing.T) {
|
||||||
name: "Non-HTTP URL",
|
name: "Non-HTTP URL",
|
||||||
input: "mailto:user@example.org",
|
input: "mailto:user@example.org",
|
||||||
expected: "mailto:user@example.org",
|
expected: "mailto:user@example.org",
|
||||||
|
strictComparison: true,
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -83,6 +92,9 @@ func TestRemoveTrackingParams(t *testing.T) {
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Errorf("Unexpected error: %v", err)
|
t.Errorf("Unexpected error: %v", err)
|
||||||
}
|
}
|
||||||
|
if tt.strictComparison && result != tt.expected {
|
||||||
|
t.Errorf("removeTrackingParams(%q) = %q, want %q", tt.input, result, tt.expected)
|
||||||
|
}
|
||||||
if !urlsEqual(result, tt.expected) {
|
if !urlsEqual(result, tt.expected) {
|
||||||
t.Errorf("removeTrackingParams(%q) = %q, want %q", tt.input, result, tt.expected)
|
t.Errorf("removeTrackingParams(%q) = %q, want %q", tt.input, result, tt.expected)
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue