forks/miniflux
1
0
Fork 0
Code Releases Activity

Close resources as soon as possible, instead of using defer() in a loop

Browse source 
So that resources can be freed as soon as they're not used anymore, instead of
waiting for the two nested loops to finish.
This commit is contained in:
jvoisin 2024-02-29 00:30:54 +01:00 committed by Frédéric Guillot
parent c4e5dad549
commit 543a690bfd
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
internal/reader/subscription/finder.go
View file

@ -232,9 +232,10 @@ func (f *SubscriptionFinder) FindSubscriptionsFromWellKnownURLs(websiteURL strin
f.requestBuilder.WithoutRedirects() f.requestBuilder.WithoutRedirects()
responseHandler := fetcher.NewResponseHandler(f.requestBuilder.ExecuteRequest(fullURL)) responseHandler := fetcher.NewResponseHandler(f.requestBuilder.ExecuteRequest(fullURL))
defer responseHandler.Close() localizedError := responseHandler.LocalizedError()
responseHandler.Close()
if localizedError := responseHandler.LocalizedError(); localizedError != nil { if localizedError != nil {
slog.Debug("Unable to subscribe", slog.String("fullURL", fullURL), slog.Any("error", localizedError.Error())) slog.Debug("Unable to subscribe", slog.String("fullURL", fullURL), slog.Any("error", localizedError.Error()))
continue continue
} }