forks/miniflux
1
0
Fork 0
Code Releases Activity

Proxify empty URL should not crash

Browse source
This commit is contained in:
Frédéric Guillot 2022-07-05 21:13:40 -07:00
parent c0eab5ebc5
commit abe568b5b3
2 changed files with 27 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
proxy/image_proxy_test.go
View file

@ -220,6 +220,29 @@ func TestProxyFilterWithSrcset(t *testing.T) {
} }
} }
func TestProxyFilterWithEmptySrcset(t *testing.T) {
os.Clearenv()
os.Setenv("PROXY_IMAGES", "all")
var err error
parser := config.NewParser()
config.Opts, err = parser.ParseEnvironmentVariables()
if err != nil {
t.Fatalf(`Parsing failure: %v`, err)
}
r := mux.NewRouter()
r.HandleFunc("/proxy/{encodedURL}", func(w http.ResponseWriter, r *http.Request) {}).Name("proxy")
input := `<p><img src="http://website/folder/image.png" srcset="" alt="test"></p>`
expected := `<p><img src="/proxy/aHR0cDovL3dlYnNpdGUvZm9sZGVyL2ltYWdlLnBuZw==" srcset="" alt="test"/></p>`
output := ImageProxyRewriter(r, input)
if expected != output {
t.Errorf(`Not expected output: got %s`, output)
}
}
func TestProxyFilterWithPictureSource(t *testing.T) { func TestProxyFilterWithPictureSource(t *testing.T) {
os.Clearenv() os.Clearenv()
os.Setenv("PROXY_IMAGES", "all") os.Setenv("PROXY_IMAGES", "all")

3
proxy/proxy.go
View file

@ -14,5 +14,8 @@ import (
// ProxifyURL generates an URL for a proxified resource. // ProxifyURL generates an URL for a proxified resource.
func ProxifyURL(router *mux.Router, link string) string { func ProxifyURL(router *mux.Router, link string) string {
if link != "" {
return route.Path(router, "proxy", "encodedURL", base64.URLEncoding.EncodeToString([]byte(link))) return route.Path(router, "proxy", "encodedURL", base64.URLEncoding.EncodeToString([]byte(link)))
} }
return ""
}