forks/miniflux
1
0
Fork 0
Code Releases Activity

Use base64 URL encoding instead of standard encoding

Browse source
This commit is contained in:
Frédéric Guillot 2017-12-18 18:06:53 -08:00
parent 99dc590e45
commit ce75748cf2
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
server/ui/controller/proxy.go
View file

@ -30,7 +30,7 @@ func (c *Controller) ImageProxy(ctx *core.Context, request *core.Request, respon
return
}
decodedURL, err := base64.StdEncoding.DecodeString(encodedURL)
decodedURL, err := base64.URLEncoding.DecodeString(encodedURL)
if err != nil {
response.HTML().BadRequest(errors.New("Unable to decode this URL"))
return

3
server/ui/filter/image_proxy_filter.go
View file

@ -36,5 +36,6 @@ func ImageProxyFilter(router *mux.Router, data string) string {
// Proxify returns a proxified link.
func Proxify(router *mux.Router, link string) string {
return route.Path(router, "proxy", "encodedURL", base64.StdEncoding.EncodeToString([]byte(link)))
// We use base64 url encoding to avoid slash in the URL.
return route.Path(router, "proxy", "encodedURL", base64.URLEncoding.EncodeToString([]byte(link)))
}