1
0
Fork 0
peertube/server/tests/api/videos/multiple-servers.ts

1092 lines
37 KiB
TypeScript
Raw Normal View History

2020-01-31 10:56:52 -05:00
/* eslint-disable @typescript-eslint/no-unused-expressions,@typescript-eslint/require-await */
2017-09-04 15:21:47 -04:00
2017-12-27 14:03:37 -05:00
import 'mocha'
2021-05-11 05:27:40 -04:00
import * as chai from 'chai'
2017-12-08 11:31:21 -05:00
import * as request from 'supertest'
2021-05-11 05:27:40 -04:00
import { HttpStatusCode } from '../../../../shared/core-utils/miscs/http-error-codes'
2017-09-04 15:21:47 -04:00
import {
2018-03-12 06:06:15 -04:00
addVideoChannel,
2021-06-14 10:52:22 -04:00
buildAbsoluteFixturePath,
2018-12-11 03:16:41 -05:00
checkTmpIsEmpty,
checkVideoFilesWereRemoved,
cleanupTests,
2018-03-12 06:06:15 -04:00
completeVideoCheck,
createUser,
dateIsValid,
doubleFollow,
flushAndRunMultipleServers,
getLocalVideos,
2018-03-12 06:06:15 -04:00
getVideo,
getVideoChannelsList,
getVideosList,
rateVideo,
removeVideo,
ServerInfo,
setAccessTokensToServers,
testImage,
updateVideo,
uploadVideo,
userLogin,
viewVideo,
wait,
webtorrentAdd
} from '../../../../shared/extra-utils'
2021-05-11 05:27:40 -04:00
import { waitJobs } from '../../../../shared/extra-utils/server/jobs'
2017-12-28 07:59:22 -05:00
import {
2018-03-12 06:06:15 -04:00
addVideoCommentReply,
addVideoCommentThread,
deleteVideoComment,
2021-05-11 05:27:40 -04:00
findCommentId,
2018-03-12 06:06:15 -04:00
getVideoCommentThreads,
2021-05-11 05:27:40 -04:00
getVideoThreadComments
} from '../../../../shared/extra-utils/videos/video-comments'
2021-05-11 05:27:40 -04:00
import { VideoComment, VideoCommentThreadTree, VideoPrivacy } from '../../../../shared/models/videos'
2017-09-04 15:21:47 -04:00
const expect = chai.expect
2017-11-17 09:20:42 -05:00
describe('Test multiple servers', function () {
2017-09-04 15:21:47 -04:00
let servers: ServerInfo[] = []
const toRemove = []
let videoUUID = ''
2017-10-24 13:41:30 -04:00
let videoChannelId: number
2017-09-04 15:21:47 -04:00
before(async function () {
this.timeout(120000)
servers = await flushAndRunMultipleServers(3)
// Get the access tokens
await setAccessTokensToServers(servers)
2018-04-24 11:05:32 -04:00
{
const videoChannel = {
2018-08-17 09:45:42 -04:00
name: 'super_channel_name',
2018-04-26 10:11:38 -04:00
displayName: 'my channel',
2018-04-24 11:05:32 -04:00
description: 'super channel'
}
2020-01-31 10:56:52 -05:00
await addVideoChannel(servers[0].url, servers[0].accessToken, videoChannel)
const channelRes = await getVideoChannelsList(servers[0].url, 0, 1)
videoChannelId = channelRes.body.data[0].id
2017-10-24 13:41:30 -04:00
}
2017-11-17 09:20:42 -05:00
// Server 1 and server 2 follow each other
await doubleFollow(servers[0], servers[1])
// Server 1 and server 3 follow each other
await doubleFollow(servers[0], servers[2])
// Server 2 and server 3 follow each other
await doubleFollow(servers[1], servers[2])
2017-09-04 15:21:47 -04:00
})
2017-11-17 09:20:42 -05:00
it('Should not have videos for all servers', async function () {
2017-09-04 15:21:47 -04:00
for (const server of servers) {
const res = await getVideosList(server.url)
const videos = res.body.data
expect(videos).to.be.an('array')
expect(videos.length).to.equal(0)
}
})
2017-11-17 09:20:42 -05:00
describe('Should upload the video and propagate on each server', function () {
it('Should upload the video on server 1 and propagate on each server', async function () {
2017-11-24 08:39:14 -05:00
this.timeout(25000)
2017-09-04 15:21:47 -04:00
const videoAttributes = {
2017-11-17 09:20:42 -05:00
name: 'my super name for server 1',
2017-09-04 15:21:47 -04:00
category: 5,
licence: 4,
2018-04-23 08:39:52 -04:00
language: 'ja',
2017-09-04 15:21:47 -04:00
nsfw: true,
2017-11-17 09:20:42 -05:00
description: 'my super description for server 1',
support: 'my super support text for server 1',
2019-02-11 08:41:55 -05:00
originallyPublishedAt: '2019-02-10T13:38:14.449Z',
2017-09-04 15:21:47 -04:00
tags: [ 'tag1p1', 'tag2p1' ],
2017-10-24 13:41:30 -04:00
channelId: videoChannelId,
2017-09-04 15:21:47 -04:00
fixture: 'video_short1.webm'
}
await uploadVideo(servers[0].url, servers[0].accessToken, videoAttributes)
await waitJobs(servers)
2017-09-04 15:21:47 -04:00
2017-11-17 09:20:42 -05:00
// All servers should have this video
let publishedAt: string = null
2017-09-04 15:21:47 -04:00
for (const server of servers) {
2019-04-26 02:50:52 -04:00
const isLocal = server.port === servers[0].port
2017-12-29 05:51:55 -05:00
const checkAttributes = {
name: 'my super name for server 1',
category: 5,
licence: 4,
2018-04-23 08:39:52 -04:00
language: 'ja',
2017-12-29 05:51:55 -05:00
nsfw: true,
description: 'my super description for server 1',
support: 'my super support text for server 1',
2019-02-11 08:41:55 -05:00
originallyPublishedAt: '2019-02-10T13:38:14.449Z',
2018-03-12 06:06:15 -04:00
account: {
name: 'root',
host: 'localhost:' + servers[0].port
2018-03-12 06:06:15 -04:00
},
2017-12-29 05:51:55 -05:00
isLocal,
publishedAt,
2017-12-29 05:51:55 -05:00
duration: 10,
tags: [ 'tag1p1', 'tag2p1' ],
privacy: VideoPrivacy.PUBLIC,
2018-01-03 04:12:36 -05:00
commentsEnabled: true,
downloadEnabled: true,
2017-12-29 05:51:55 -05:00
channel: {
displayName: 'my channel',
name: 'super_channel_name',
2017-12-29 05:51:55 -05:00
description: 'super channel',
isLocal
},
2017-12-29 08:32:51 -05:00
fixture: 'video_short1.webm',
2017-12-29 05:51:55 -05:00
files: [
{
resolution: 720,
size: 572456
}
]
}
2017-09-04 15:21:47 -04:00
const res = await getVideosList(server.url)
const videos = res.body.data
expect(videos).to.be.an('array')
expect(videos.length).to.equal(1)
const video = videos[0]
2017-12-29 05:51:55 -05:00
await completeVideoCheck(server.url, video, checkAttributes)
publishedAt = video.publishedAt
2017-09-04 15:21:47 -04:00
}
})
2017-11-17 09:20:42 -05:00
it('Should upload the video on server 2 and propagate on each server', async function () {
2020-11-16 05:55:17 -05:00
this.timeout(100000)
2017-09-04 15:21:47 -04:00
2017-10-24 13:41:30 -04:00
const user = {
username: 'user1',
password: 'super_password'
}
2020-01-31 10:56:52 -05:00
await createUser({ url: servers[1].url, accessToken: servers[1].accessToken, username: user.username, password: user.password })
2017-12-28 08:29:57 -05:00
const userAccessToken = await userLogin(servers[1], user)
2017-10-24 13:41:30 -04:00
2017-09-04 15:21:47 -04:00
const videoAttributes = {
2017-11-17 09:20:42 -05:00
name: 'my super name for server 2',
2017-09-04 15:21:47 -04:00
category: 4,
licence: 3,
2018-04-23 08:39:52 -04:00
language: 'de',
2017-09-04 15:21:47 -04:00
nsfw: true,
2017-11-17 09:20:42 -05:00
description: 'my super description for server 2',
support: 'my super support text for server 2',
2017-09-04 15:21:47 -04:00
tags: [ 'tag1p2', 'tag2p2', 'tag3p2' ],
fixture: 'video_short2.webm',
thumbnailfile: 'thumbnail.jpg',
previewfile: 'preview.jpg'
2017-09-04 15:21:47 -04:00
}
Resumable video uploads (#3933) * WIP: resumable video uploads relates to #324 * fix review comments * video upload: error handling * fix audio upload * fixes after self review * Update server/controllers/api/videos/index.ts Co-authored-by: Rigel Kent <par@rigelk.eu> * Update server/middlewares/validators/videos/videos.ts Co-authored-by: Rigel Kent <par@rigelk.eu> * Update server/controllers/api/videos/index.ts Co-authored-by: Rigel Kent <par@rigelk.eu> * update after code review * refactor upload route - restore multipart upload route - move resumable to dedicated upload-resumable route - move checks to middleware - do not leak internal fs structure in response * fix yarn.lock upon rebase * factorize addVideo for reuse in both endpoints * add resumable upload API to openapi spec * add initial test and test helper for resumable upload * typings for videoAddResumable middleware * avoid including aws and google packages via node-uploadx, by only including uploadx/core * rename ex-isAudioBg to more explicit name mentioning it is a preview file for audio * add video-upload-tmp-folder-cleaner job * stronger typing of video upload middleware * reduce dependency to @uploadx/core * add audio upload test * refactor resumable uploads cleanup from job to scheduler * refactor resumable uploads scheduler to compare to last execution time * make resumable upload validator to always cleanup on failure * move legacy upload request building outside of uploadVideo test helper * filter upload-resumable middlewares down to POST, PUT, DELETE also begin to type metadata * merge add duration functions * stronger typings and documentation for uploadx behaviour, move init validator up * refactor(client/video-edit): options > uploadxOptions * refactor(client/video-edit): remove obsolete else * scheduler/remove-dangling-resum: rename tag * refactor(server/video): add UploadVideoFiles type * refactor(mw/validators): restructure eslint disable * refactor(mw/validators/videos): rename import * refactor(client/vid-upload): rename html elem id * refactor(sched/remove-dangl): move fn to method * refactor(mw/async): add method typing * refactor(mw/vali/video): double quote > single * refactor(server/upload-resum): express use > all * proper http methud enum server/middlewares/async.ts * properly type http methods * factorize common video upload validation steps * add check for maximum partially uploaded file size * fix audioBg use * fix extname(filename) in addVideo * document parameters for uploadx's resumable protocol * clear META files in scheduler * last audio refactor before cramming preview in the initial POST form data * refactor as mulitpart/form-data initial post request this allows preview/thumbnail uploads alongside the initial request, and cleans up the upload form * Add more tests for resumable uploads * Refactor remove dangling resumable uploads * Prepare changelog * Add more resumable upload tests * Remove user quota check for resumable uploads * Fix upload error handler * Update nginx template for upload-resumable * Cleanup comment * Remove unused express methods * Prefer to use got instead of raw http * Don't retry on error 500 Co-authored-by: Rigel Kent <par@rigelk.eu> Co-authored-by: Rigel Kent <sendmemail@rigelk.eu> Co-authored-by: Chocobozzz <me@florianbigard.com>
2021-05-10 05:13:41 -04:00
await uploadVideo(servers[1].url, userAccessToken, videoAttributes, HttpStatusCode.OK_200, 'resumable')
2017-09-04 15:21:47 -04:00
// Transcoding
await waitJobs(servers)
2017-09-04 15:21:47 -04:00
2017-11-17 09:20:42 -05:00
// All servers should have this video
2017-09-04 15:21:47 -04:00
for (const server of servers) {
const isLocal = server.url === 'http://localhost:' + servers[1].port
2017-12-29 05:51:55 -05:00
const checkAttributes = {
name: 'my super name for server 2',
category: 4,
licence: 3,
2018-04-23 08:39:52 -04:00
language: 'de',
2017-12-29 05:51:55 -05:00
nsfw: true,
description: 'my super description for server 2',
support: 'my super support text for server 2',
2018-03-12 06:06:15 -04:00
account: {
name: 'user1',
host: 'localhost:' + servers[1].port
2018-03-12 06:06:15 -04:00
},
2017-12-29 05:51:55 -05:00
isLocal,
2018-01-03 04:12:36 -05:00
commentsEnabled: true,
downloadEnabled: true,
2017-12-29 05:51:55 -05:00
duration: 5,
tags: [ 'tag1p2', 'tag2p2', 'tag3p2' ],
privacy: VideoPrivacy.PUBLIC,
channel: {
displayName: 'Main user1 channel',
name: 'user1_channel',
2017-12-29 05:51:55 -05:00
description: 'super channel',
isLocal
},
fixture: 'video_short2.webm',
files: [
{
resolution: 240,
2020-11-24 10:24:50 -05:00
size: 270000
2017-12-29 05:51:55 -05:00
},
{
resolution: 360,
2020-11-24 10:24:50 -05:00
size: 359000
2017-12-29 05:51:55 -05:00
},
{
resolution: 480,
2020-11-24 10:24:50 -05:00
size: 465000
2017-12-29 05:51:55 -05:00
},
{
resolution: 720,
2020-11-24 10:24:50 -05:00
size: 788000
2017-12-29 05:51:55 -05:00
}
],
thumbnailfile: 'thumbnail',
previewfile: 'preview'
2017-12-29 05:51:55 -05:00
}
2017-09-04 15:21:47 -04:00
const res = await getVideosList(server.url)
const videos = res.body.data
expect(videos).to.be.an('array')
expect(videos.length).to.equal(2)
const video = videos[1]
2017-12-29 05:51:55 -05:00
await completeVideoCheck(server.url, video, checkAttributes)
2017-09-04 15:21:47 -04:00
}
})
2017-11-17 09:20:42 -05:00
it('Should upload two videos on server 3 and propagate on each server', async function () {
2017-09-04 15:21:47 -04:00
this.timeout(45000)
const videoAttributes1 = {
2017-11-17 09:20:42 -05:00
name: 'my super name for server 3',
2017-09-04 15:21:47 -04:00
category: 6,
licence: 5,
2018-04-23 08:39:52 -04:00
language: 'de',
2017-09-04 15:21:47 -04:00
nsfw: true,
2017-11-17 09:20:42 -05:00
description: 'my super description for server 3',
support: 'my super support text for server 3',
2017-09-04 15:21:47 -04:00
tags: [ 'tag1p3' ],
fixture: 'video_short3.webm'
}
await uploadVideo(servers[2].url, servers[2].accessToken, videoAttributes1)
const videoAttributes2 = {
2017-11-17 09:20:42 -05:00
name: 'my super name for server 3-2',
2017-09-04 15:21:47 -04:00
category: 7,
licence: 6,
2018-04-23 08:39:52 -04:00
language: 'ko',
2017-09-04 15:21:47 -04:00
nsfw: false,
2017-11-17 09:20:42 -05:00
description: 'my super description for server 3-2',
support: 'my super support text for server 3-2',
2017-09-04 15:21:47 -04:00
tags: [ 'tag2p3', 'tag3p3', 'tag4p3' ],
fixture: 'video_short.webm'
}
await uploadVideo(servers[2].url, servers[2].accessToken, videoAttributes2)
await waitJobs(servers)
2017-09-04 15:21:47 -04:00
2017-11-17 09:20:42 -05:00
// All servers should have this video
2017-09-04 15:21:47 -04:00
for (const server of servers) {
const isLocal = server.url === 'http://localhost:' + servers[2].port
2017-09-04 15:21:47 -04:00
const res = await getVideosList(server.url)
const videos = res.body.data
expect(videos).to.be.an('array')
expect(videos.length).to.equal(4)
// We not sure about the order of the two last uploads
let video1 = null
let video2 = null
2017-11-17 09:20:42 -05:00
if (videos[2].name === 'my super name for server 3') {
2017-09-04 15:21:47 -04:00
video1 = videos[2]
video2 = videos[3]
} else {
video1 = videos[3]
video2 = videos[2]
}
2017-12-29 05:51:55 -05:00
const checkAttributesVideo1 = {
name: 'my super name for server 3',
category: 6,
licence: 5,
2018-04-23 08:39:52 -04:00
language: 'de',
2017-12-29 05:51:55 -05:00
nsfw: true,
description: 'my super description for server 3',
support: 'my super support text for server 3',
2018-03-12 06:06:15 -04:00
account: {
name: 'root',
host: 'localhost:' + servers[2].port
2018-03-12 06:06:15 -04:00
},
2017-12-29 05:51:55 -05:00
isLocal,
duration: 5,
2018-01-03 04:12:36 -05:00
commentsEnabled: true,
downloadEnabled: true,
2017-12-29 05:51:55 -05:00
tags: [ 'tag1p3' ],
privacy: VideoPrivacy.PUBLIC,
channel: {
displayName: 'Main root channel',
name: 'root_channel',
2017-12-29 05:51:55 -05:00
description: '',
isLocal
},
fixture: 'video_short3.webm',
files: [
{
resolution: 720,
size: 292677
}
]
2017-09-04 15:21:47 -04:00
}
2017-12-29 05:51:55 -05:00
await completeVideoCheck(server.url, video1, checkAttributesVideo1)
const checkAttributesVideo2 = {
name: 'my super name for server 3-2',
category: 7,
licence: 6,
2018-04-23 08:39:52 -04:00
language: 'ko',
2017-12-29 05:51:55 -05:00
nsfw: false,
description: 'my super description for server 3-2',
support: 'my super support text for server 3-2',
2018-03-12 06:06:15 -04:00
account: {
name: 'root',
host: 'localhost:' + servers[2].port
2018-03-12 06:06:15 -04:00
},
2018-01-03 04:12:36 -05:00
commentsEnabled: true,
downloadEnabled: true,
2017-12-29 05:51:55 -05:00
isLocal,
duration: 5,
tags: [ 'tag2p3', 'tag3p3', 'tag4p3' ],
privacy: VideoPrivacy.PUBLIC,
channel: {
displayName: 'Main root channel',
name: 'root_channel',
2017-12-29 05:51:55 -05:00
description: '',
isLocal
},
2017-12-29 08:32:51 -05:00
fixture: 'video_short.webm',
2017-12-29 05:51:55 -05:00
files: [
{
resolution: 720,
size: 218910
}
]
2017-09-04 15:21:47 -04:00
}
2017-12-29 05:51:55 -05:00
await completeVideoCheck(server.url, video2, checkAttributesVideo2)
2017-09-04 15:21:47 -04:00
}
})
})
2018-03-13 05:24:28 -04:00
describe('It should list local videos', function () {
it('Should list only local videos on server 1', async function () {
const { body } = await getLocalVideos(servers[0].url)
expect(body.total).to.equal(1)
expect(body.data).to.be.an('array')
expect(body.data.length).to.equal(1)
expect(body.data[0].name).to.equal('my super name for server 1')
})
it('Should list only local videos on server 2', async function () {
const { body } = await getLocalVideos(servers[1].url)
expect(body.total).to.equal(1)
expect(body.data).to.be.an('array')
expect(body.data.length).to.equal(1)
expect(body.data[0].name).to.equal('my super name for server 2')
})
it('Should list only local videos on server 3', async function () {
const { body } = await getLocalVideos(servers[2].url)
expect(body.total).to.equal(2)
expect(body.data).to.be.an('array')
expect(body.data.length).to.equal(2)
expect(body.data[0].name).to.equal('my super name for server 3')
expect(body.data[1].name).to.equal('my super name for server 3-2')
})
})
2017-09-04 15:21:47 -04:00
describe('Should seed the uploaded video', function () {
2017-11-17 09:20:42 -05:00
it('Should add the file 1 by asking server 3', async function () {
this.timeout(10000)
2017-09-04 15:21:47 -04:00
const res = await getVideosList(servers[2].url)
const video = res.body.data[0]
toRemove.push(res.body.data[2])
toRemove.push(res.body.data[3])
2017-10-24 13:41:30 -04:00
const res2 = await getVideo(servers[2].url, video.id)
const videoDetails = res2.body
2017-12-29 05:51:55 -05:00
const torrent = await webtorrentAdd(videoDetails.files[0].magnetUri, true)
2017-09-04 15:21:47 -04:00
expect(torrent.files).to.be.an('array')
expect(torrent.files.length).to.equal(1)
expect(torrent.files[0].path).to.exist.and.to.not.equal('')
})
2017-11-17 09:20:42 -05:00
it('Should add the file 2 by asking server 1', async function () {
this.timeout(10000)
2017-09-04 15:21:47 -04:00
const res = await getVideosList(servers[0].url)
const video = res.body.data[1]
2017-10-24 13:41:30 -04:00
const res2 = await getVideo(servers[0].url, video.id)
const videoDetails = res2.body
2017-09-04 15:21:47 -04:00
2017-12-29 05:51:55 -05:00
const torrent = await webtorrentAdd(videoDetails.files[0].magnetUri, true)
2017-09-04 15:21:47 -04:00
expect(torrent.files).to.be.an('array')
expect(torrent.files.length).to.equal(1)
expect(torrent.files[0].path).to.exist.and.to.not.equal('')
})
2017-11-17 09:20:42 -05:00
it('Should add the file 3 by asking server 2', async function () {
this.timeout(10000)
2017-09-04 15:21:47 -04:00
const res = await getVideosList(servers[1].url)
const video = res.body.data[2]
2017-10-24 13:41:30 -04:00
const res2 = await getVideo(servers[1].url, video.id)
const videoDetails = res2.body
2017-09-04 15:21:47 -04:00
2017-12-29 05:51:55 -05:00
const torrent = await webtorrentAdd(videoDetails.files[0].magnetUri, true)
2017-09-04 15:21:47 -04:00
expect(torrent.files).to.be.an('array')
expect(torrent.files.length).to.equal(1)
expect(torrent.files[0].path).to.exist.and.to.not.equal('')
})
2017-11-17 09:20:42 -05:00
it('Should add the file 3-2 by asking server 1', async function () {
this.timeout(10000)
2017-09-04 15:21:47 -04:00
const res = await getVideosList(servers[0].url)
const video = res.body.data[3]
2017-10-24 13:41:30 -04:00
const res2 = await getVideo(servers[0].url, video.id)
const videoDetails = res2.body
2017-09-04 15:21:47 -04:00
2017-10-24 13:41:30 -04:00
const torrent = await webtorrentAdd(videoDetails.files[0].magnetUri)
2017-09-04 15:21:47 -04:00
expect(torrent.files).to.be.an('array')
expect(torrent.files.length).to.equal(1)
expect(torrent.files[0].path).to.exist.and.to.not.equal('')
})
2017-11-17 09:20:42 -05:00
it('Should add the file 2 in 360p by asking server 1', async function () {
this.timeout(10000)
const res = await getVideosList(servers[0].url)
2017-11-17 09:20:42 -05:00
const video = res.body.data.find(v => v.name === 'my super name for server 2')
2017-10-24 13:41:30 -04:00
const res2 = await getVideo(servers[0].url, video.id)
const videoDetails = res2.body
2018-03-19 07:36:41 -04:00
const file = videoDetails.files.find(f => f.resolution.id === 360)
expect(file).not.to.be.undefined
const torrent = await webtorrentAdd(file.magnetUri)
expect(torrent.files).to.be.an('array')
expect(torrent.files.length).to.equal(1)
expect(torrent.files[0].path).to.exist.and.to.not.equal('')
})
2017-09-04 15:21:47 -04:00
})
describe('Should update video views, likes and dislikes', function () {
2017-11-17 09:20:42 -05:00
let localVideosServer3 = []
let remoteVideosServer1 = []
let remoteVideosServer2 = []
let remoteVideosServer3 = []
2017-09-04 15:21:47 -04:00
before(async function () {
const res1 = await getVideosList(servers[0].url)
2017-11-17 09:20:42 -05:00
remoteVideosServer1 = res1.body.data.filter(video => video.isLocal === false).map(video => video.uuid)
2017-09-04 15:21:47 -04:00
const res2 = await getVideosList(servers[1].url)
2017-11-17 09:20:42 -05:00
remoteVideosServer2 = res2.body.data.filter(video => video.isLocal === false).map(video => video.uuid)
2017-09-04 15:21:47 -04:00
const res3 = await getVideosList(servers[2].url)
2017-11-17 09:20:42 -05:00
localVideosServer3 = res3.body.data.filter(video => video.isLocal === true).map(video => video.uuid)
remoteVideosServer3 = res3.body.data.filter(video => video.isLocal === false).map(video => video.uuid)
2017-09-04 15:21:47 -04:00
})
it('Should view multiple videos on owned servers', async function () {
2018-08-29 10:26:25 -04:00
this.timeout(30000)
2017-09-04 15:21:47 -04:00
2018-02-23 10:39:51 -05:00
await viewVideo(servers[2].url, localVideosServer3[0])
await wait(1000)
2018-02-23 10:39:51 -05:00
await viewVideo(servers[2].url, localVideosServer3[0])
await viewVideo(servers[2].url, localVideosServer3[1])
2018-02-23 10:39:51 -05:00
await wait(1000)
2018-02-23 10:39:51 -05:00
2019-08-12 02:46:46 -04:00
await viewVideo(servers[2].url, localVideosServer3[0])
await viewVideo(servers[2].url, localVideosServer3[0])
2017-09-04 15:21:47 -04:00
await waitJobs(servers)
2017-09-04 15:21:47 -04:00
2018-08-29 10:26:25 -04:00
// Wait the repeatable job
await wait(6000)
await waitJobs(servers)
2017-09-04 15:21:47 -04:00
for (const server of servers) {
const res = await getVideosList(server.url)
const videos = res.body.data
2017-11-17 09:20:42 -05:00
const video0 = videos.find(v => v.uuid === localVideosServer3[0])
const video1 = videos.find(v => v.uuid === localVideosServer3[1])
2017-10-24 13:41:30 -04:00
2017-11-30 03:21:11 -05:00
expect(video0.views).to.equal(3)
expect(video1.views).to.equal(1)
2017-09-04 15:21:47 -04:00
}
})
it('Should view multiple videos on each servers', async function () {
2019-07-24 03:21:22 -04:00
this.timeout(45000)
2017-09-04 15:21:47 -04:00
const tasks: Promise<any>[] = []
2017-11-30 03:21:11 -05:00
tasks.push(viewVideo(servers[0].url, remoteVideosServer1[0]))
tasks.push(viewVideo(servers[1].url, remoteVideosServer2[0]))
tasks.push(viewVideo(servers[1].url, remoteVideosServer2[0]))
tasks.push(viewVideo(servers[2].url, remoteVideosServer3[0]))
tasks.push(viewVideo(servers[2].url, remoteVideosServer3[1]))
tasks.push(viewVideo(servers[2].url, remoteVideosServer3[1]))
tasks.push(viewVideo(servers[2].url, remoteVideosServer3[1]))
tasks.push(viewVideo(servers[2].url, localVideosServer3[1]))
tasks.push(viewVideo(servers[2].url, localVideosServer3[1]))
tasks.push(viewVideo(servers[2].url, localVideosServer3[1]))
2017-09-04 15:21:47 -04:00
await Promise.all(tasks)
await waitJobs(servers)
2017-09-04 15:21:47 -04:00
2018-08-29 10:26:25 -04:00
// Wait the repeatable job
2019-07-24 03:21:22 -04:00
await wait(16000)
2018-08-29 10:26:25 -04:00
await waitJobs(servers)
2017-09-04 15:21:47 -04:00
let baseVideos = null
for (const server of servers) {
const res = await getVideosList(server.url)
const videos = res.body.data
// Initialize base videos for future comparisons
if (baseVideos === null) {
baseVideos = videos
2017-11-22 12:22:06 -05:00
continue
2017-09-04 15:21:47 -04:00
}
for (const baseVideo of baseVideos) {
const sameVideo = videos.find(video => video.name === baseVideo.name)
expect(baseVideo.views).to.equal(sameVideo.views)
}
}
})
it('Should like and dislikes videos on different services', async function () {
2021-04-23 02:34:17 -04:00
this.timeout(50000)
2017-09-04 15:21:47 -04:00
await rateVideo(servers[0].url, servers[0].accessToken, remoteVideosServer1[0], 'like')
2019-03-19 11:23:02 -04:00
await wait(500)
await rateVideo(servers[0].url, servers[0].accessToken, remoteVideosServer1[0], 'dislike')
2019-03-19 11:23:02 -04:00
await wait(500)
await rateVideo(servers[0].url, servers[0].accessToken, remoteVideosServer1[0], 'like')
await rateVideo(servers[2].url, servers[2].accessToken, localVideosServer3[1], 'like')
2019-03-19 11:23:02 -04:00
await wait(500)
await rateVideo(servers[2].url, servers[2].accessToken, localVideosServer3[1], 'dislike')
await rateVideo(servers[2].url, servers[2].accessToken, remoteVideosServer3[1], 'dislike')
2019-03-19 11:23:02 -04:00
await wait(500)
await rateVideo(servers[2].url, servers[2].accessToken, remoteVideosServer3[0], 'like')
2017-09-04 15:21:47 -04:00
await waitJobs(servers)
2020-11-18 08:15:25 -05:00
await wait(5000)
2017-09-04 15:21:47 -04:00
let baseVideos = null
for (const server of servers) {
const res = await getVideosList(server.url)
const videos = res.body.data
// Initialize base videos for future comparisons
if (baseVideos === null) {
baseVideos = videos
2017-11-22 12:22:06 -05:00
continue
2017-09-04 15:21:47 -04:00
}
2017-11-22 12:22:06 -05:00
for (const baseVideo of baseVideos) {
2017-09-04 15:21:47 -04:00
const sameVideo = videos.find(video => video.name === baseVideo.name)
expect(baseVideo.likes).to.equal(sameVideo.likes)
expect(baseVideo.dislikes).to.equal(sameVideo.dislikes)
2017-11-22 12:22:06 -05:00
}
2017-09-04 15:21:47 -04:00
}
})
})
describe('Should manipulate these videos', function () {
2017-11-17 09:20:42 -05:00
it('Should update the video 3 by asking server 3', async function () {
this.timeout(10000)
2017-09-04 15:21:47 -04:00
const attributes = {
name: 'my super video updated',
category: 10,
licence: 7,
2018-04-23 08:39:52 -04:00
language: 'fr',
2017-09-04 15:21:47 -04:00
nsfw: true,
description: 'my super description updated',
support: 'my super support text updated',
tags: [ 'tag_up_1', 'tag_up_2' ],
thumbnailfile: 'thumbnail.jpg',
2019-02-11 08:41:55 -05:00
originallyPublishedAt: '2019-02-11T13:38:14.449Z',
previewfile: 'preview.jpg'
2017-09-04 15:21:47 -04:00
}
await updateVideo(servers[2].url, servers[2].accessToken, toRemove[0].id, attributes)
await waitJobs(servers)
2017-09-04 15:21:47 -04:00
})
2017-11-17 09:20:42 -05:00
it('Should have the video 3 updated on each server', async function () {
this.timeout(10000)
2017-09-04 15:21:47 -04:00
for (const server of servers) {
const res = await getVideosList(server.url)
const videos = res.body.data
const videoUpdated = videos.find(video => video.name === 'my super video updated')
expect(!!videoUpdated).to.be.true
const isLocal = server.url === 'http://localhost:' + servers[2].port
2017-12-29 05:51:55 -05:00
const checkAttributes = {
name: 'my super video updated',
category: 10,
licence: 7,
2018-04-23 08:39:52 -04:00
language: 'fr',
2017-12-29 05:51:55 -05:00
nsfw: true,
description: 'my super description updated',
support: 'my super support text updated',
2019-02-11 08:41:55 -05:00
originallyPublishedAt: '2019-02-11T13:38:14.449Z',
2018-03-12 06:06:15 -04:00
account: {
name: 'root',
host: 'localhost:' + servers[2].port
2018-03-12 06:06:15 -04:00
},
2017-12-29 05:51:55 -05:00
isLocal,
duration: 5,
2018-01-03 04:12:36 -05:00
commentsEnabled: true,
downloadEnabled: true,
2017-12-29 05:51:55 -05:00
tags: [ 'tag_up_1', 'tag_up_2' ],
privacy: VideoPrivacy.PUBLIC,
channel: {
displayName: 'Main root channel',
name: 'root_channel',
2017-12-29 05:51:55 -05:00
description: '',
isLocal
},
fixture: 'video_short3.webm',
files: [
{
resolution: 720,
size: 292677
}
],
thumbnailfile: 'thumbnail',
previewfile: 'preview'
2017-12-29 05:51:55 -05:00
}
await completeVideoCheck(server.url, videoUpdated, checkAttributes)
2017-09-04 15:21:47 -04:00
}
})
2017-11-17 09:20:42 -05:00
it('Should remove the videos 3 and 3-2 by asking server 3', async function () {
this.timeout(10000)
2017-09-04 15:21:47 -04:00
await removeVideo(servers[2].url, servers[2].accessToken, toRemove[0].id)
await removeVideo(servers[2].url, servers[2].accessToken, toRemove[1].id)
await waitJobs(servers)
2017-09-04 15:21:47 -04:00
})
it('Should not have files of videos 3 and 3-2 on each server', async function () {
for (const server of servers) {
2020-01-24 10:48:05 -05:00
await checkVideoFilesWereRemoved(toRemove[0].uuid, server.internalServerNumber)
await checkVideoFilesWereRemoved(toRemove[1].uuid, server.internalServerNumber)
}
})
2017-11-17 09:20:42 -05:00
it('Should have videos 1 and 3 on each server', async function () {
2017-09-04 15:21:47 -04:00
for (const server of servers) {
const res = await getVideosList(server.url)
const videos = res.body.data
expect(videos).to.be.an('array')
expect(videos.length).to.equal(2)
expect(videos[0].name).not.to.equal(videos[1].name)
expect(videos[0].name).not.to.equal(toRemove[0].name)
expect(videos[1].name).not.to.equal(toRemove[0].name)
expect(videos[0].name).not.to.equal(toRemove[1].name)
expect(videos[1].name).not.to.equal(toRemove[1].name)
2017-11-17 09:20:42 -05:00
videoUUID = videos.find(video => video.name === 'my super name for server 1').uuid
2017-09-04 15:21:47 -04:00
}
})
2017-11-17 09:20:42 -05:00
it('Should get the same video by UUID on each server', async function () {
2017-09-04 15:21:47 -04:00
let baseVideo = null
for (const server of servers) {
const res = await getVideo(server.url, videoUUID)
const video = res.body
if (baseVideo === null) {
baseVideo = video
2017-11-22 12:22:06 -05:00
continue
2017-09-04 15:21:47 -04:00
}
expect(baseVideo.name).to.equal(video.name)
expect(baseVideo.uuid).to.equal(video.uuid)
2018-03-19 07:36:41 -04:00
expect(baseVideo.category.id).to.equal(video.category.id)
expect(baseVideo.language.id).to.equal(video.language.id)
expect(baseVideo.licence.id).to.equal(video.licence.id)
2017-09-04 15:21:47 -04:00
expect(baseVideo.nsfw).to.equal(video.nsfw)
2018-03-12 06:06:15 -04:00
expect(baseVideo.account.name).to.equal(video.account.name)
expect(baseVideo.account.displayName).to.equal(video.account.displayName)
expect(baseVideo.account.url).to.equal(video.account.url)
expect(baseVideo.account.host).to.equal(video.account.host)
2017-09-04 15:21:47 -04:00
expect(baseVideo.tags).to.deep.equal(video.tags)
}
})
2017-11-17 09:20:42 -05:00
it('Should get the preview from each server', async function () {
2017-09-04 15:21:47 -04:00
for (const server of servers) {
const res = await getVideo(server.url, videoUUID)
const video = res.body
2018-02-14 12:21:14 -05:00
await testImage(server.url, 'video_short1-preview.webm', video.previewPath)
2017-09-04 15:21:47 -04:00
}
})
})
2017-12-27 14:03:37 -05:00
describe('Should comment these videos', function () {
2018-03-27 04:26:52 -04:00
let childOfFirstChild: VideoCommentThreadTree
2017-12-27 14:03:37 -05:00
it('Should add comment (threads and replies)', async function () {
this.timeout(25000)
{
const text = 'my super first comment'
2020-01-31 10:56:52 -05:00
await addVideoCommentThread(servers[0].url, servers[0].accessToken, videoUUID, text)
2017-12-27 14:03:37 -05:00
}
{
const text = 'my super second comment'
2020-01-31 10:56:52 -05:00
await addVideoCommentThread(servers[2].url, servers[2].accessToken, videoUUID, text)
2017-12-27 14:03:37 -05:00
}
await waitJobs(servers)
2017-12-27 14:03:37 -05:00
{
const threadId = await findCommentId(servers[1].url, videoUUID, 'my super first comment')
2017-12-27 14:03:37 -05:00
const text = 'my super answer to thread 1'
2020-01-31 10:56:52 -05:00
await addVideoCommentReply(servers[1].url, servers[1].accessToken, videoUUID, threadId, text)
2017-12-27 14:03:37 -05:00
}
await waitJobs(servers)
2017-12-27 14:03:37 -05:00
{
const threadId = await findCommentId(servers[2].url, videoUUID, 'my super first comment')
2017-12-27 14:03:37 -05:00
const res2 = await getVideoThreadComments(servers[2].url, videoUUID, threadId)
const childCommentId = res2.body.children[0].comment.id
const text3 = 'my second answer to thread 1'
2020-01-31 10:56:52 -05:00
await addVideoCommentReply(servers[2].url, servers[2].accessToken, videoUUID, threadId, text3)
2017-12-27 14:03:37 -05:00
const text2 = 'my super answer to answer of thread 1'
2020-01-31 10:56:52 -05:00
await addVideoCommentReply(servers[2].url, servers[2].accessToken, videoUUID, childCommentId, text2)
2017-12-27 14:03:37 -05:00
}
await waitJobs(servers)
2017-12-27 14:03:37 -05:00
})
it('Should have these threads', async function () {
for (const server of servers) {
const res = await getVideoCommentThreads(server.url, videoUUID, 0, 5)
expect(res.body.total).to.equal(2)
expect(res.body.data).to.be.an('array')
expect(res.body.data).to.have.lengthOf(2)
{
const comment: VideoComment = res.body.data.find(c => c.text === 'my super first comment')
expect(comment).to.not.be.undefined
expect(comment.inReplyToCommentId).to.be.null
expect(comment.account.name).to.equal('root')
expect(comment.account.host).to.equal('localhost:' + servers[0].port)
2017-12-27 14:03:37 -05:00
expect(comment.totalReplies).to.equal(3)
expect(dateIsValid(comment.createdAt as string)).to.be.true
expect(dateIsValid(comment.updatedAt as string)).to.be.true
}
{
const comment: VideoComment = res.body.data.find(c => c.text === 'my super second comment')
expect(comment).to.not.be.undefined
expect(comment.inReplyToCommentId).to.be.null
expect(comment.account.name).to.equal('root')
expect(comment.account.host).to.equal('localhost:' + servers[2].port)
2017-12-27 14:03:37 -05:00
expect(comment.totalReplies).to.equal(0)
expect(dateIsValid(comment.createdAt as string)).to.be.true
expect(dateIsValid(comment.updatedAt as string)).to.be.true
}
}
})
it('Should have these comments', async function () {
for (const server of servers) {
const res1 = await getVideoCommentThreads(server.url, videoUUID, 0, 5)
const threadId = res1.body.data.find(c => c.text === 'my super first comment').id
const res2 = await getVideoThreadComments(server.url, videoUUID, threadId)
const tree: VideoCommentThreadTree = res2.body
expect(tree.comment.text).equal('my super first comment')
expect(tree.comment.account.name).equal('root')
expect(tree.comment.account.host).equal('localhost:' + servers[0].port)
2017-12-27 14:03:37 -05:00
expect(tree.children).to.have.lengthOf(2)
const firstChild = tree.children[0]
expect(firstChild.comment.text).to.equal('my super answer to thread 1')
expect(firstChild.comment.account.name).equal('root')
expect(firstChild.comment.account.host).equal('localhost:' + servers[1].port)
2017-12-27 14:03:37 -05:00
expect(firstChild.children).to.have.lengthOf(1)
2018-03-27 04:26:52 -04:00
childOfFirstChild = firstChild.children[0]
2017-12-27 14:03:37 -05:00
expect(childOfFirstChild.comment.text).to.equal('my super answer to answer of thread 1')
expect(childOfFirstChild.comment.account.name).equal('root')
expect(childOfFirstChild.comment.account.host).equal('localhost:' + servers[2].port)
2017-12-27 14:03:37 -05:00
expect(childOfFirstChild.children).to.have.lengthOf(0)
const secondChild = tree.children[1]
expect(secondChild.comment.text).to.equal('my second answer to thread 1')
expect(secondChild.comment.account.name).equal('root')
expect(secondChild.comment.account.host).equal('localhost:' + servers[2].port)
2017-12-27 14:03:37 -05:00
expect(secondChild.children).to.have.lengthOf(0)
}
})
2018-01-03 04:12:36 -05:00
2018-03-27 04:26:52 -04:00
it('Should delete a reply', async function () {
this.timeout(10000)
await deleteVideoComment(servers[2].url, servers[2].accessToken, videoUUID, childOfFirstChild.comment.id)
await waitJobs(servers)
2018-03-27 04:26:52 -04:00
})
it('Should have this comment marked as deleted', async function () {
2018-03-27 04:26:52 -04:00
for (const server of servers) {
const res1 = await getVideoCommentThreads(server.url, videoUUID, 0, 5)
const threadId = res1.body.data.find(c => c.text === 'my super first comment').id
const res2 = await getVideoThreadComments(server.url, videoUUID, threadId)
const tree: VideoCommentThreadTree = res2.body
expect(tree.comment.text).equal('my super first comment')
const firstChild = tree.children[0]
expect(firstChild.comment.text).to.equal('my super answer to thread 1')
expect(firstChild.children).to.have.lengthOf(1)
const deletedComment = firstChild.children[0].comment
expect(deletedComment.isDeleted).to.be.true
expect(deletedComment.deletedAt).to.not.be.null
expect(deletedComment.account).to.be.null
expect(deletedComment.text).to.equal('')
2018-03-27 04:26:52 -04:00
const secondChild = tree.children[1]
expect(secondChild.comment.text).to.equal('my second answer to thread 1')
}
})
2018-01-04 05:19:16 -05:00
it('Should delete the thread comments', async function () {
this.timeout(10000)
2020-01-31 10:56:52 -05:00
const res = await getVideoCommentThreads(servers[0].url, videoUUID, 0, 5)
const threadId = res.body.data.find(c => c.text === 'my super first comment').id
2020-01-31 10:56:52 -05:00
await deleteVideoComment(servers[0].url, servers[0].accessToken, videoUUID, threadId)
2018-01-04 05:19:16 -05:00
await waitJobs(servers)
2018-01-04 05:19:16 -05:00
})
it('Should have the threads marked as deleted on other servers too', async function () {
2018-01-04 05:19:16 -05:00
for (const server of servers) {
const res = await getVideoCommentThreads(server.url, videoUUID, 0, 5)
expect(res.body.total).to.equal(2)
2018-01-04 05:19:16 -05:00
expect(res.body.data).to.be.an('array')
expect(res.body.data).to.have.lengthOf(2)
2018-01-04 05:19:16 -05:00
{
const comment: VideoComment = res.body.data[0]
expect(comment).to.not.be.undefined
expect(comment.inReplyToCommentId).to.be.null
expect(comment.account.name).to.equal('root')
expect(comment.account.host).to.equal('localhost:' + servers[2].port)
2018-01-04 05:19:16 -05:00
expect(comment.totalReplies).to.equal(0)
expect(dateIsValid(comment.createdAt as string)).to.be.true
expect(dateIsValid(comment.updatedAt as string)).to.be.true
}
{
const deletedComment: VideoComment = res.body.data[1]
expect(deletedComment).to.not.be.undefined
expect(deletedComment.isDeleted).to.be.true
expect(deletedComment.deletedAt).to.not.be.null
expect(deletedComment.text).to.equal('')
expect(deletedComment.inReplyToCommentId).to.be.null
expect(deletedComment.account).to.be.null
expect(deletedComment.totalReplies).to.equal(2)
expect(dateIsValid(deletedComment.createdAt as string)).to.be.true
expect(dateIsValid(deletedComment.updatedAt as string)).to.be.true
expect(dateIsValid(deletedComment.deletedAt as string)).to.be.true
}
2018-01-04 05:19:16 -05:00
}
})
it('Should delete a remote thread by the origin server', async function () {
this.timeout(5000)
2020-01-31 10:56:52 -05:00
const res = await getVideoCommentThreads(servers[0].url, videoUUID, 0, 5)
const threadId = res.body.data.find(c => c.text === 'my super second comment').id
2020-01-31 10:56:52 -05:00
await deleteVideoComment(servers[0].url, servers[0].accessToken, videoUUID, threadId)
await waitJobs(servers)
})
it('Should have the threads marked as deleted on other servers too', async function () {
for (const server of servers) {
const res = await getVideoCommentThreads(server.url, videoUUID, 0, 5)
expect(res.body.total).to.equal(2)
expect(res.body.data).to.have.lengthOf(2)
{
const comment: VideoComment = res.body.data[0]
expect(comment.text).to.equal('')
expect(comment.isDeleted).to.be.true
expect(comment.createdAt).to.not.be.null
expect(comment.deletedAt).to.not.be.null
expect(comment.account).to.be.null
expect(comment.totalReplies).to.equal(0)
}
{
const comment: VideoComment = res.body.data[1]
expect(comment.text).to.equal('')
expect(comment.isDeleted).to.be.true
expect(comment.createdAt).to.not.be.null
expect(comment.deletedAt).to.not.be.null
expect(comment.account).to.be.null
expect(comment.totalReplies).to.equal(2)
}
}
})
it('Should disable comments and download', async function () {
2018-01-03 04:12:36 -05:00
this.timeout(20000)
const attributes = {
commentsEnabled: false,
downloadEnabled: false
2018-01-03 04:12:36 -05:00
}
await updateVideo(servers[0].url, servers[0].accessToken, videoUUID, attributes)
await waitJobs(servers)
2018-01-03 04:12:36 -05:00
for (const server of servers) {
const res = await getVideo(server.url, videoUUID)
expect(res.body.commentsEnabled).to.be.false
expect(res.body.downloadEnabled).to.be.false
2018-01-03 04:12:36 -05:00
const text = 'my super forbidden comment'
await addVideoCommentThread(server.url, server.accessToken, videoUUID, text, HttpStatusCode.CONFLICT_409)
2018-01-03 04:12:36 -05:00
}
})
2017-12-27 14:03:37 -05:00
})
2017-12-08 11:31:21 -05:00
describe('With minimum parameters', function () {
it('Should upload and propagate the video', async function () {
this.timeout(60000)
2017-12-08 11:31:21 -05:00
const path = '/api/v1/videos/upload'
const req = request(servers[1].url)
.post(path)
.set('Accept', 'application/json')
.set('Authorization', 'Bearer ' + servers[1].accessToken)
.field('name', 'minimum parameters')
.field('privacy', '1')
.field('channelId', '1')
2021-06-14 10:52:22 -04:00
await req.attach('videofile', buildAbsoluteFixturePath('video_short.webm'))
.expect(HttpStatusCode.OK_200)
2017-12-08 11:31:21 -05:00
await waitJobs(servers)
2017-12-08 11:31:21 -05:00
for (const server of servers) {
const res = await getVideosList(server.url)
const video = res.body.data.find(v => v.name === 'minimum parameters')
const isLocal = server.url === 'http://localhost:' + servers[1].port
2017-12-29 05:51:55 -05:00
const checkAttributes = {
name: 'minimum parameters',
category: null,
licence: null,
language: null,
nsfw: false,
description: null,
support: null,
2018-03-12 06:06:15 -04:00
account: {
name: 'root',
host: 'localhost:' + servers[1].port
2018-03-12 06:06:15 -04:00
},
2017-12-29 05:51:55 -05:00
isLocal,
duration: 5,
2019-09-18 11:20:37 -04:00
commentsEnabled: true,
2019-02-11 08:41:55 -05:00
downloadEnabled: true,
2020-01-31 10:56:52 -05:00
tags: [],
2017-12-29 05:51:55 -05:00
privacy: VideoPrivacy.PUBLIC,
channel: {
displayName: 'Main root channel',
name: 'root_channel',
2017-12-29 05:51:55 -05:00
description: '',
isLocal
},
fixture: 'video_short.webm',
files: [
{
resolution: 720,
2021-01-29 09:58:01 -05:00
size: 59000
2017-12-29 05:51:55 -05:00
},
{
resolution: 480,
2021-01-29 09:58:01 -05:00
size: 34000
2017-12-29 05:51:55 -05:00
},
{
resolution: 360,
2021-01-29 09:58:01 -05:00
size: 31000
2017-12-29 05:51:55 -05:00
},
{
resolution: 240,
2021-01-29 09:58:01 -05:00
size: 23000
2017-12-29 05:51:55 -05:00
}
]
}
await completeVideoCheck(server.url, video, checkAttributes)
2017-12-08 11:31:21 -05:00
}
})
})
2018-12-11 03:16:41 -05:00
describe('TMP directory', function () {
it('Should have an empty tmp directory', async function () {
for (const server of servers) {
await checkTmpIsEmpty(server)
}
})
})
2019-04-24 09:10:37 -04:00
after(async function () {
await cleanupTests(servers)
2017-09-04 15:21:47 -04:00
})
})