diff --git a/config/default.yaml b/config/default.yaml index cbe6fa9ea..e4a5ee727 100644 --- a/config/default.yaml +++ b/config/default.yaml @@ -101,6 +101,7 @@ log: maxFiles: 20 anonymizeIP: false log_ping_requests: true + prettify_sql: false trending: videos: diff --git a/config/production.yaml.example b/config/production.yaml.example index 88def3ad5..f7b56cc4a 100644 --- a/config/production.yaml.example +++ b/config/production.yaml.example @@ -101,6 +101,7 @@ log: maxFiles: 20 anonymizeIP: false log_ping_requests: true + prettify_sql: false trending: videos: diff --git a/scripts/parse-log.ts b/scripts/parse-log.ts index eb3534e5e..065fe7e82 100755 --- a/scripts/parse-log.ts +++ b/scripts/parse-log.ts @@ -9,6 +9,7 @@ import * as winston from 'winston' import { labelFormatter } from '../server/helpers/logger' import { CONFIG } from '../server/initializers/config' import { mtimeSortFilesDesc } from '../shared/core-utils/logs/logs' +import { inspect } from 'util' program .option('-l, --level [level]', 'Level log (debug/info/warn/error)') @@ -82,7 +83,7 @@ function run () { logLevels[log.level](log) } catch (err) { - console.error('Cannot parse line.', line) + console.error('Cannot parse line.', inspect(line)) throw err } }) diff --git a/server/helpers/logger.ts b/server/helpers/logger.ts index f1808849e..0548dfd5b 100644 --- a/server/helpers/logger.ts +++ b/server/helpers/logger.ts @@ -40,14 +40,17 @@ function getLoggerReplacer () { } const consoleLoggerFormat = winston.format.printf(info => { - const obj = omit(info, 'label', 'timestamp', 'level', 'message', 'sql') + const toOmit = [ 'label', 'timestamp', 'level', 'message' ] + if (CONFIG.LOG.PRETTIFY_SQL) toOmit.push('sql') + + const obj = omit(info, ...toOmit) let additionalInfos = JSON.stringify(obj, getLoggerReplacer(), 2) if (additionalInfos === undefined || additionalInfos === '{}') additionalInfos = '' else additionalInfos = ' ' + additionalInfos - if (info.sql) { + if (CONFIG.LOG.PRETTIFY_SQL && info.sql) { additionalInfos += '\n' + sqlFormat(info.sql, { language: 'sql', ident: ' ' diff --git a/server/initializers/config.ts b/server/initializers/config.ts index ba79b4ea1..c7ef9b497 100644 --- a/server/initializers/config.ts +++ b/server/initializers/config.ts @@ -105,7 +105,8 @@ const CONFIG = { MAX_FILES: config.get('log.rotation.maxFiles') }, ANONYMIZE_IP: config.get('log.anonymizeIP'), - LOG_PING_REQUESTS: config.get('log.log_ping_requests') + LOG_PING_REQUESTS: config.get('log.log_ping_requests'), + PRETTIFY_SQL: config.get('log.prettify_sql') }, TRENDING: { VIDEOS: {