forks/peertube
1
0
Fork 0
Code Releases Activity

Optimize video views redis calls

Browse source 
Try to avoid them if we can
This commit is contained in:
Chocobozzz 2023-10-26 14:08:19 +02:00
parent 0f21769205
commit 40a6dcb632
No known key found for this signature in database
GPG key ID: 583A612D890159BE
2 changed files with 25 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
server/core/lib/redis.ts
View file

@ -382,7 +382,7 @@ class Redis {
return 'verify-email-registration-' + registrationId
}
private generateIPViewKey (ip: string, videoUUID: string) {
generateIPViewKey (ip: string, videoUUID: string) {
return `views-${videoUUID}-${ip}`
}

26
server/core/lib/views/shared/video-views.ts
View file

@ -5,11 +5,18 @@ import { getServerActor } from '@server/models/application/application.js'
import { MVideo, MVideoImmutable } from '@server/types/models/index.js'
import { buildUUID } from '@peertube/peertube-node-utils'
import { Redis } from '../../redis.js'
import { LRUCache } from 'lru-cache'
import { VIEW_LIFETIME } from '@server/initializers/constants.js'
const lTags = loggerTagsFactory('views')
export class VideoViews {
private readonly viewsCache = new LRUCache<string, boolean>({
max: 10_000,
ttl: VIEW_LIFETIME.VIEW
})
async addLocalView (options: {
video: MVideoImmutable
ip: string
@ -21,10 +28,10 @@ export class VideoViews {
if (!await this.hasEnoughWatchTime(video, watchTime)) return false
const viewExists = await Redis.Instance.doesVideoIPViewExist(ip, video.uuid)
const viewExists = await this.doesVideoIPViewExist(ip, video.uuid)
if (viewExists) return false
await Redis.Instance.setIPVideoView(ip, video.uuid)
await this.setIPVideoView(ip, video.uuid)
await this.addView(video)
@ -67,4 +74,19 @@ export class VideoViews {
// Check more than 50% of the video is watched
return duration / watchTime < 2
}
private doesVideoIPViewExist (ip: string, videoUUID: string) {
const key = Redis.Instance.generateIPViewKey(ip, videoUUID)
const value = this.viewsCache.has(key)
if (value === true) return Promise.resolve(true)
return Redis.Instance.doesVideoIPViewExist(ip, videoUUID)
}
private setIPVideoView (ip: string, videoUUID: string) {
const key = Redis.Instance.generateIPViewKey(ip, videoUUID)
this.viewsCache.set(key, true)
return Redis.Instance.setIPVideoView(ip, videoUUID)
}
}