Convert scripts to typescript

package.json

@@ -28,14 +28,14 @@
     "danger:clean:dev": "scripty",
     "danger:clean:prod": "scripty",
     "danger:clean:modules": "scripty",
-    "reset-password": "scripty",
+    "reset-password": "ts-node ./scripts/reset-password.ts",
     "play": "scripty",
     "dev:server": "scripty",
     "dev:client": "scripty",
     "start": "node dist/server",
-    "check": "scripty",
+    "check": "ts-node ./scripts/check.ts",
     "upgrade": "scripty",
-    "update-host": "scripty",
+    "update-host": "ts-node ./scripts/update-host.ts",
     "test": "scripty",
     "help": "scripty",
     "postinstall": "cd client && yarn install",
@@ -85,6 +85,7 @@
     "@types/async": "^2.0.40",
     "@types/bcrypt": "^1.0.0",
     "@types/body-parser": "^1.16.3",
+    "@types/commander": "^2.9.1",
     "@types/config": "^0.0.32",
     "@types/express": "^4.0.35",
     "@types/lodash": "^4.14.64",

scripts/check.ts

@@ -1,12 +1,9 @@
-#!/usr/bin/env node
+import * as series from 'async/series'
+import * as request from 'request'
+import * as WebSocket from 'ws'
 
-'use strict'
+import { CONFIG } from '../server/initializers/constants'
 
-const series = require('async/series')
-const request = require('request')
-const WebSocket = require('ws')
-
-const constants = require('../server/initializers/constants')
 const requestHeaders = {
   'Range': '',
   'Keep-Alive': '',
@@ -29,8 +26,8 @@ series([
 
 // ---------------------------------------------------------------------------
 
-function pingServer (callback) {
+function pingServer (callback: () => void) {
-  const pingUrl = constants.CONFIG.WEBSERVER.URL + '/api/v1/ping'
+  const pingUrl = CONFIG.WEBSERVER.URL + '/api/v1/ping'
   console.log('Checking server is up (%s)...', pingUrl)
 
   request(pingUrl, function (err, res, body) {
@@ -44,8 +41,8 @@ function pingServer (callback) {
   })
 }
 
-function checkCORSTorrent (callback) {
+function checkCORSTorrent (callback: () => void) {
-  const torrentUrl = constants.CONFIG.WEBSERVER.URL + '/static/torrents/test.torrent'
+  const torrentUrl = CONFIG.WEBSERVER.URL + '/static/torrents/test.torrent'
   console.log('Checking CORS headers for the torrent (%s)...', torrentUrl)
 
   request({
@@ -63,8 +60,8 @@ function checkCORSTorrent (callback) {
   })
 }
 
-function checkCORSWebSeed (callback) {
+function checkCORSWebSeed (callback: () => void) {
-  const webseedUrl = constants.CONFIG.WEBSERVER.URL + '/static/webseed/test.mp4'
+  const webseedUrl = CONFIG.WEBSERVER.URL + '/static/webseed/test.mp4'
   console.log('Checking CORS headers for the video (%s)...', webseedUrl)
 
   request({
@@ -82,9 +79,9 @@ function checkCORSWebSeed (callback) {
   })
 }
 
-function checkTracker (callback) {
+function checkTracker (callback: () => void) {
-  const trackerUrl = constants.CONFIG.WEBSERVER.WS + '://' +
+  const trackerUrl = CONFIG.WEBSERVER.WS + '://' +
-                     constants.CONFIG.WEBSERVER.HOST +
+                     CONFIG.WEBSERVER.HOST +
                      '/tracker/socket'
   console.log('Checking tracker websocket (%s)...', trackerUrl)
 
@@ -111,7 +108,7 @@ function checkTracker (callback) {
   }
 }
 
-function isThereValidCORSHeaders (res) {
+function isThereValidCORSHeaders (res: request.RequestResponse) {
   let fail = false
 
   // Check Access-Control-Allow-Origin
@@ -160,7 +157,7 @@ function isThereValidCORSHeaders (res) {
   return !fail
 }
 
-function findPatternNotInString (stringChain, patterns) {
+function findPatternNotInString (stringChain: string, patterns: string[]) {
   let res = null
   const stringChainLowerCase = stringChain.toLowerCase()
 

scripts/reset-password.ts

@@ -1,10 +1,6 @@
-#!/usr/bin/env node
+import * as program from 'commander'
 
-'use strict'
+import { database as db } from '../server/initializers/database'
-
-const program = require('commander')
-
-const db = require('../server/initializers/database')
 
 program
   .option('-u, --user [user]', 'User')

scripts/update-host.js

@@ -1,42 +0,0 @@
-#!/usr/bin/env node
-
-'use strict'
-
-const fs = require('fs')
-const parseTorrent = require('parse-torrent')
-
-const constants = require('../server/initializers/constants')
-const db = require('../server/initializers/database')
-
-const friends = require('../server/lib/friends')
-
-db.init(true, function () {
-  friends.hasFriends(function (err, hasFriends) {
-    if (err) throw err
-
-    if (hasFriends === true) {
-      console.log('Cannot update host because you have friends!')
-      process.exit(-1)
-    }
-
-    console.log('Updating torrent files.')
-    db.Video.list(function (err, videos) {
-      if (err) throw err
-
-      videos.forEach(function (video) {
-        const torrentName = video.id + '.torrent'
-        const torrentPath = constants.CONFIG.STORAGE.TORRENTS_DIR + torrentName
-        const filename = video.id + video.extname
-
-        const parsed = parseTorrent(fs.readFileSync(torrentPath))
-        parsed.announce = [ constants.CONFIG.WEBSERVER.WS + '://' + constants.CONFIG.WEBSERVER.HOST + '/tracker/socket' ]
-        parsed.urlList = [ constants.CONFIG.WEBSERVER.URL + constants.STATIC_PATHS.WEBSEED + filename ]
-
-        const buf = parseTorrent.toTorrentFile(parsed)
-        fs.writeFileSync(torrentPath, buf)
-      })
-
-      process.exit(0)
-    })
-  })
-})

scripts/update-host.ts

@@ -0,0 +1,37 @@
+import { readFileSync, writeFileSync } from 'fs'
+import * as parseTorrent from 'parse-torrent'
+
+import { CONFIG, STATIC_PATHS } from '../server/initializers/constants'
+import { database as db } from '../server/initializers/database'
+import { hasFriends } from '../server/lib/friends'
+
+db.init(true, function () {
+  hasFriends(function (err, itHasFriends) {
+    if (err) throw err
+
+    if (itHasFriends === true) {
+      console.log('Cannot update host because you have friends!')
+      process.exit(-1)
+    }
+
+    console.log('Updating torrent files.')
+    db.Video.list(function (err, videos) {
+      if (err) throw err
+
+      videos.forEach(function (video) {
+        const torrentName = video.id + '.torrent'
+        const torrentPath = CONFIG.STORAGE.TORRENTS_DIR + torrentName
+        const filename = video.id + video.extname
+
+        const parsed = parseTorrent(readFileSync(torrentPath))
+        parsed.announce = [ CONFIG.WEBSERVER.WS + '://' + CONFIG.WEBSERVER.HOST + '/tracker/socket' ]
+        parsed.urlList = [ CONFIG.WEBSERVER.URL + STATIC_PATHS.WEBSEED + filename ]
+
+        const buf = parseTorrent.toTorrentFile(parsed)
+        writeFileSync(torrentPath, buf)
+      })
+
+      process.exit(0)
+    })
+  })
+})

server/models/video-interface.ts

@@ -70,7 +70,7 @@ export namespace VideoMethods {
   export type GetDurationFromFileCallback = (err: Error, duration?: number) => void
   export type GetDurationFromFile = (videoPath, callback) => void
 
-  export type ListCallback = () => void
+  export type ListCallback = (err: Error, videoInstances: VideoInstance[]) => void
   export type List = (callback: ListCallback) => void
 
   export type ListForApiCallback = (err: Error, videoInstances?: VideoInstance[], total?: number) => void

yarn.lock

@@ -21,6 +21,12 @@
     "@types/express" "*"
     "@types/node" "*"
 
+"@types/commander@^2.9.1":
+  version "2.9.1"
+  resolved "https://registry.yarnpkg.com/@types/commander/-/commander-2.9.1.tgz#d4e464425baf4685bd49dd233be11de9c00c0784"
+  dependencies:
+    "@types/node" "*"
+
 "@types/config@^0.0.32":
   version "0.0.32"
   resolved "https://registry.yarnpkg.com/@types/config/-/config-0.0.32.tgz#c106055802d78e234e28374adc4dad460d098558"