forks/peertube
1
0
Fork 0
Code Releases Activity

Save replay of permanent live in client

Browse source
This commit is contained in:
Chocobozzz 2022-05-02 10:49:48 +02:00
parent 98ebfa3950
commit 86c5229b4d
No known key found for this signature in database
GPG key ID: 583A612D890159BE
5 changed files with 1 additions and 33 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
client/src/app/+admin/config/edit-custom-config/edit-live-configuration.component.html
View file

@ -30,9 +30,6 @@
inputName="liveAllowReplay" formControlName="allowReplay"
i18n-labelText labelText="Allow your users to automatically publish a replay of their live"
>
<ng-container ngProjectAs="description" i18n>
If the user quota is reached, PeerTube will automatically terminate the live streaming
</ng-container>
</my-peertube-checkbox>
</div>

19
client/src/app/+videos/+video-edit/shared/video-edit.component.ts
View file

@ -180,7 +180,6 @@ export class VideoEditComponent implements OnInit, OnDestroy {
this.trackChannelChange()
this.trackPrivacyChange()
this.trackLivePermanentFieldChange()
this.formBuilt.emit()
}
@ -457,24 +456,6 @@ export class VideoEditComponent implements OnInit, OnDestroy {
)
}
private trackLivePermanentFieldChange () {
// We will update the "support" field depending on the channel
this.form.controls['permanentLive']
.valueChanges
.subscribe(
permanentLive => {
const saveReplayControl = this.form.controls['saveReplay']
if (permanentLive === true) {
saveReplayControl.setValue(false)
saveReplayControl.disable()
} else {
saveReplayControl.enable()
}
}
)
}
private updateSupportField (support: string) {
return this.form.patchValue({ support: support || '' })
}

2
client/src/app/+videos/+video-edit/video-add-components/video-go-live.component.ts
View file

@ -71,7 +71,7 @@ export class VideoGoLiveComponent extends VideoSend implements OnInit, AfterView
nsfw: this.serverConfig.instance.isNSFW,
waitTranscoding: true,
permanentLive: this.firstStepPermanentLive,
saveReplay: this.firstStepPermanentLive === false && this.isReplayAllowed(),
saveReplay: this.isReplayAllowed(),
channelId: this.firstStepChannelId
}

4
server/middlewares/validators/videos/video-live.ts
View file

@ -170,10 +170,6 @@ const videoLiveUpdateValidator = [
const body: LiveVideoUpdate = req.body
if (body.permanentLive && body.saveReplay) {
return res.fail({ message: 'Cannot set this live as permanent while saving its replay' })
}
if (hasValidSaveReplay(body) !== true) {
return res.fail({
status: HttpStatusCode.FORBIDDEN_403,

6
server/tests/api/check-params/live.ts
View file

@ -414,12 +414,6 @@ describe('Test video lives API validator', function () {
await command.update({ videoId: videoIdNotLive, fields: {}, expectedStatus: HttpStatusCode.NOT_FOUND_404 })
})
it('Should fail with save replay and permanent live set to true', async function () {
const fields = { saveReplay: true, permanentLive: true }
await command.update({ videoId: video.id, fields, expectedStatus: HttpStatusCode.BAD_REQUEST_400 })
})
it('Should fail with bad latency setting', async function () {
const fields = { latencyMode: 42 }