Upgrade client dependencies

client/package.json

@@ -63,9 +63,9 @@
     "setupTestFrameworkScriptFile": "<rootDir>/src/setupJest.ts"
   },
   "devDependencies": {
-    "@angular-devkit/build-angular": "^0.7.5",
+    "@angular-devkit/build-angular": "^0.8.3",
     "@angular/animations": "~6.1.4",
-    "@angular/cli": "~6.1.5",
+    "@angular/cli": "~6.2.3",
     "@angular/common": "~6.1.4",
     "@angular/compiler": "~6.1.4",
     "@angular/compiler-cli": "~6.1.4",
@@ -93,12 +93,12 @@
     "@types/lodash-es": "^4.17.0",
     "@types/markdown-it": "^0.0.5",
     "@types/node": "^10.9.2",
-    "@types/sanitize-html": "^1.14.0",
+    "@types/sanitize-html": "1.18.0",
     "@types/video.js": "6.2.7",
     "@types/webtorrent": "^0.98.4",
     "angular2-hotkeys": "^2.1.2",
     "angular2-notifications": "^1.0.2",
-    "awesome-typescript-loader": "5.2.0",
+    "awesome-typescript-loader": "5.2.1",
     "bootstrap": "^4.1.3",
     "buffer": "^5.1.0",
     "cache-chunk-store": "^3.0.0",
@@ -108,6 +108,7 @@
     "dexie": "^2.0.4",
     "extract-text-webpack-plugin": "4.0.0-beta.0",
     "file-loader": "^2.0.0",
+    "focus-visible": "^4.1.5",
     "html-loader": "^0.5.5",
     "html-webpack-plugin": "^3.2.0",
     "https-browserify": "^1.0.0",
@@ -124,8 +125,8 @@
     "linkifyjs": "^2.1.5",
     "lodash-es": "^4.17.4",
     "markdown-it": "^8.4.0",
-    "ngx-chips": "1.9.3",
-    "ngx-clipboard": "11.1.3",
+    "ngx-chips": "1.9.7",
+    "ngx-clipboard": "11.1.7",
     "ngx-pipes": "^2.1.7",
     "ngx-qrcode2": "^0.0.9",
     "ngx-textarea-autosize": "^2.0.0",
@@ -138,28 +139,26 @@
     "purify-css": "^1.2.5",
     "purifycss-webpack": "^0.7.0",
     "raw-loader": "^0.5.1",
-    "resolve-url-loader": "^2.0.0",
     "rxjs": "^6.1.0",
     "sanitize-html": "^1.18.4",
     "sass-loader": "^7.1.0",
     "sass-resources-loader": "^1.2.1",
+    "stream-browserify": "^2.0.1",
     "stream-http": "^2.8.3",
+    "terser-webpack-plugin": "^1.1.0",
     "ts-jest": "^23.1.4",
     "tslint": "^5.7.0",
     "tslint-config-standard": "^7.0.0",
     "typescript": "2.9",
-    "uglifyjs-webpack-plugin": "^1.3.0",
-    "video.js": "7.2",
-    "videojs-contextmenu": "^2.0.0",
-    "videojs-contextmenu-ui": "^4.0.0",
+    "video.js": "^7",
+    "videojs-contextmenu-ui": "^5.0.0",
     "videojs-dock": "^2.0.2",
     "videojs-hotkeys": "^0.2.21",
     "webpack": "^4.17.1",
-    "webpack-bundle-analyzer": "^2.9.1",
+    "webpack-bundle-analyzer": "^3.0.2",
     "webpack-cli": "^3.0.8",
     "webtorrent": "^0.102.1",
-    "whatwg-fetch": "^2.0.4",
-    "zone.js": "~0.8.5",
-    "focus-visible": "^4.1.5"
+    "whatwg-fetch": "^3.0.0",
+    "zone.js": "~0.8.5"
   }
 }

client/src/app/shared/video-caption/video-caption.service.ts

@@ -76,7 +76,7 @@ export class VideoCaptionService {
       }
     }
 
-    if (observables.length === 0) return of(true)
+    if (observables.length === 0) return of(undefined)
 
     return forkJoin(observables)
   }

client/src/app/videos/+video-edit/video-add-components/video-send.ts

@@ -13,7 +13,6 @@ import { VideoEdit } from '@app/shared/video/video-edit.model'
 import { populateAsyncUserVideoChannels } from '@app/shared/misc/utils'
 
 export abstract class VideoSend extends FormReactive implements OnInit, CanComponentDeactivate {
-
   userVideoChannels: { id: number, label: string, support: string }[] = []
   videoPrivacies: VideoConstant<VideoPrivacy>[] = []
   videoCaptions: VideoCaptionEdit[] = []

client/src/assets/player/peertube-player.ts

@@ -2,7 +2,6 @@ import { VideoFile } from '../../../../shared/models/videos'
 
 import 'videojs-hotkeys'
 import 'videojs-dock'
-import 'videojs-contextmenu'
 import 'videojs-contextmenu-ui'
 import './peertube-link-button'
 import './resolution-menu-button'

client/src/shims/http.ts

@@ -1 +1 @@
-module.exports = require('stream-http');
+module.exports = require('stream-http')

client/src/shims/https.ts

@@ -1 +1 @@
-module.exports = require('https-browserify');
+module.exports = require('https-browserify')

client/src/shims/noop.ts

@@ -1,3 +1,3 @@
-// Does nothing. Used to shim out node.js modules 
+// Does nothing. Used to shim out node.js modules
 // which are no-ops in the browser.
-export const NOOP = 0;
+export const NOOP = 0

client/src/shims/path.ts

@@ -1 +1 @@
-module.exports = require('path-browserify');
+module.exports = require('path-browserify')

client/webpack/webpack.video-embed.js

@@ -3,15 +3,12 @@ const path = require('path')
 
 const CheckerPlugin = require('awesome-typescript-loader').CheckerPlugin
 const HtmlWebpackPlugin = require('html-webpack-plugin')
-const UglifyJsPlugin = require('uglifyjs-webpack-plugin')
-const HashedModuleIdsPlugin = require('webpack/lib/HashedModuleIdsPlugin')
+const TerserPlugin = require('terser-webpack-plugin')
 const LoaderOptionsPlugin = require('webpack/lib/LoaderOptionsPlugin')
 const ExtractTextPlugin = require('extract-text-webpack-plugin')
 const PurifyCSSPlugin = require('purifycss-webpack')
 
 module.exports = function () {
-  const isProd = process.env.NODE_ENV === 'production'
-
   const configuration = {
     entry: {
       'video-embed': './src/standalone/videos/embed.ts',
@@ -72,7 +69,12 @@ module.exports = function () {
                   importLoaders: 1
                 }
               },
-              'resolve-url-loader',
+              // {
+              //   loader: 'resolve-url-loader',
+              //   options: {
+              //     debug: true
+              //   }
+              // },
               {
                 loader: 'sass-loader',
                 options: {
@@ -113,9 +115,9 @@ module.exports = function () {
       }),
 
       new PurifyCSSPlugin({
-        paths: [ 
+        paths: [
           helpers.root('src/standalone/videos/embed.ts'),
-          helpers.root('src/standalone/videos/test-embed.html') 
+          helpers.root('src/standalone/videos/test-embed.html')
         ],
         purifyOptions: {
           minify: true,
@@ -158,6 +160,27 @@ module.exports = function () {
       })
     ],
 
+    optimization: {
+      minimizer: [
+        new TerserPlugin({
+          terserOptions: {
+            ecma: 6,
+            warnings: false,
+            ie8: false,
+            mangle: true,
+            compress: {
+              passes: 3,
+              pure_getters: true
+            },
+            output: {
+              ascii_only: true,
+              comments: false
+            }
+          }
+        })
+      ]
+    },
+
     performance: {
       maxEntrypointSize: 700000, // 600kB
       maxAssetSize: 700000
@@ -174,28 +197,5 @@ module.exports = function () {
     }
   }
 
-  if (isProd) {
-    configuration.plugins.push(
-      new UglifyJsPlugin({
-        uglifyOptions: {
-          ecma: 6,
-          warnings: false,
-          ie8: false,
-          mangle: true,
-          compress: {
-            passes: 3,
-            pure_getters: true
-          },
-          output: {
-            ascii_only: true,
-            comments: false
-          }
-        }
-      }),
-
-      new HashedModuleIdsPlugin()
-    )
-  }
-
   return configuration
 }