2a491182e4
* Add external channel URL for channel update / creation (#754) * Disallow synchronisation if user has no video quota (#754) * More constraints serverside (#754) * Disable sync if server configuration does not allow HTTP import (#754) * Working version synchronizing videos with a job (#754) TODO: refactoring, too much code duplication * More logs and try/catch (#754) * Fix eslint error (#754) * WIP: support synchronization time change (#754) * New frontend #754 * WIP: Create sync front (#754) * Enhance UI, sync creation form (#754) * Warning message when HTTP upload is disallowed * More consistent names (#754) * Binding Front with API (#754) * Add a /me API (#754) * Improve list UI (#754) * Implement creation and deletion routes (#754) * Lint (#754) * Lint again (#754) * WIP: UI for triggering import existing videos (#754) * Implement jobs for syncing and importing channels * Don't sync videos before sync creation + avoid concurrency issue (#754) * Cleanup (#754) * Cleanup: OpenAPI + API rework (#754) * Remove dead code (#754) * Eslint (#754) * Revert the mess with whitespaces in constants.ts (#754) * Some fixes after rebase (#754) * Several fixes after PR remarks (#754) * Front + API: Rename video-channels-sync to video-channel-syncs (#754) * Allow enabling channel sync through UI (#754) * getChannelInfo (#754) * Minor fixes: openapi + model + sql (#754) * Simplified API validators (#754) * Rename MChannelSync to MChannelSyncChannel (#754) * Add command for VideoChannelSync (#754) * Use synchronization.enabled config (#754) * Check parameters test + some fixes (#754) * Fix conflict mistake (#754) * Restrict access to video channel sync list API (#754) * Start adding unit test for synchronization (#754) * Continue testing (#754) * Tests finished + convertion of job to scheduler (#754) * Add lastSyncAt field (#754) * Fix externalRemoteUrl sort + creation date not well formatted (#754) * Small fix (#754) * Factorize addYoutubeDLImport and buildVideo (#754) * Check duplicates on channel not on users (#754) * factorize thumbnail generation (#754) * Fetch error should return status 400 (#754) * Separate video-channel-import and video-channel-sync-latest (#754) * Bump DB migration version after rebase (#754) * Prettier states in UI table (#754) * Add DefaultScope in VideoChannelSyncModel (#754) * Fix audit logs (#754) * Ensure user can upload when importing channel + minor fixes (#754) * Mark synchronization as failed on exception + typos (#754) * Change REST API for importing videos into channel (#754) * Add option for fully synchronize a chnanel (#754) * Return a whole sync object on creation to avoid tricks in Front (#754) * Various remarks (#754) * Single quotes by default (#754) * Rename synchronization to video_channel_synchronization * Add check.latest_videos_count and max_per_user options (#754) * Better channel rendering in list #754 * Allow sorting with channel name and state (#754) * Add missing tests for channel imports (#754) * Prefer using a parent job for channel sync * Styling * Client styling Co-authored-by: Chocobozzz <me@florianbigard.com>
424 lines
14 KiB
TypeScript
424 lines
14 KiB
TypeScript
/* eslint-disable @typescript-eslint/no-unused-expressions,@typescript-eslint/require-await */
|
|
|
|
import 'mocha'
|
|
import { omit } from 'lodash'
|
|
import { checkBadCountPagination, checkBadSortPagination, checkBadStartPagination, FIXTURE_URLS } from '@server/tests/shared'
|
|
import { buildAbsoluteFixturePath } from '@shared/core-utils'
|
|
import { HttpStatusCode, VideoPrivacy } from '@shared/models'
|
|
import {
|
|
cleanupTests,
|
|
createSingleServer,
|
|
makeGetRequest,
|
|
makePostBodyRequest,
|
|
makeUploadRequest,
|
|
PeerTubeServer,
|
|
setAccessTokensToServers,
|
|
setDefaultVideoChannel,
|
|
waitJobs
|
|
} from '@shared/server-commands'
|
|
|
|
describe('Test video imports API validator', function () {
|
|
const path = '/api/v1/videos/imports'
|
|
let server: PeerTubeServer
|
|
let userAccessToken = ''
|
|
let channelId: number
|
|
|
|
// ---------------------------------------------------------------
|
|
|
|
before(async function () {
|
|
this.timeout(30000)
|
|
|
|
server = await createSingleServer(1)
|
|
|
|
await setAccessTokensToServers([ server ])
|
|
await setDefaultVideoChannel([ server ])
|
|
|
|
const username = 'user1'
|
|
const password = 'my super password'
|
|
await server.users.create({ username, password })
|
|
userAccessToken = await server.login.getAccessToken({ username, password })
|
|
|
|
{
|
|
const { videoChannels } = await server.users.getMyInfo()
|
|
channelId = videoChannels[0].id
|
|
}
|
|
})
|
|
|
|
describe('When listing my video imports', function () {
|
|
const myPath = '/api/v1/users/me/videos/imports'
|
|
|
|
it('Should fail with a bad start pagination', async function () {
|
|
await checkBadStartPagination(server.url, myPath, server.accessToken)
|
|
})
|
|
|
|
it('Should fail with a bad count pagination', async function () {
|
|
await checkBadCountPagination(server.url, myPath, server.accessToken)
|
|
})
|
|
|
|
it('Should fail with an incorrect sort', async function () {
|
|
await checkBadSortPagination(server.url, myPath, server.accessToken)
|
|
})
|
|
|
|
it('Should success with the correct parameters', async function () {
|
|
await makeGetRequest({ url: server.url, path: myPath, expectedStatus: HttpStatusCode.OK_200, token: server.accessToken })
|
|
})
|
|
})
|
|
|
|
describe('When adding a video import', function () {
|
|
let baseCorrectParams
|
|
|
|
before(function () {
|
|
baseCorrectParams = {
|
|
targetUrl: FIXTURE_URLS.goodVideo,
|
|
name: 'my super name',
|
|
category: 5,
|
|
licence: 1,
|
|
language: 'pt',
|
|
nsfw: false,
|
|
commentsEnabled: true,
|
|
downloadEnabled: true,
|
|
waitTranscoding: true,
|
|
description: 'my super description',
|
|
support: 'my super support text',
|
|
tags: [ 'tag1', 'tag2' ],
|
|
privacy: VideoPrivacy.PUBLIC,
|
|
channelId
|
|
}
|
|
})
|
|
|
|
it('Should fail with nothing', async function () {
|
|
const fields = {}
|
|
await makePostBodyRequest({
|
|
url: server.url,
|
|
path,
|
|
token: server.accessToken,
|
|
fields,
|
|
expectedStatus: HttpStatusCode.BAD_REQUEST_400
|
|
})
|
|
})
|
|
|
|
it('Should fail without a target url', async function () {
|
|
const fields = omit(baseCorrectParams, 'targetUrl')
|
|
await makePostBodyRequest({
|
|
url: server.url,
|
|
path,
|
|
token: server.accessToken,
|
|
fields,
|
|
expectedStatus: HttpStatusCode.BAD_REQUEST_400
|
|
})
|
|
})
|
|
|
|
it('Should fail with a bad target url', async function () {
|
|
const fields = { ...baseCorrectParams, targetUrl: 'htt://hello' }
|
|
|
|
await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with localhost', async function () {
|
|
const fields = { ...baseCorrectParams, targetUrl: 'http://localhost:8000' }
|
|
|
|
await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with a private IP target urls', async function () {
|
|
const targetUrls = [
|
|
'http://127.0.0.1:8000',
|
|
'http://127.0.0.1',
|
|
'http://127.0.0.1/hello',
|
|
'https://192.168.1.42',
|
|
'http://192.168.1.42',
|
|
'http://127.0.0.1.cpy.re'
|
|
]
|
|
|
|
for (const targetUrl of targetUrls) {
|
|
const fields = { ...baseCorrectParams, targetUrl }
|
|
|
|
await makePostBodyRequest({
|
|
url: server.url,
|
|
path,
|
|
token: server.accessToken,
|
|
fields,
|
|
expectedStatus: HttpStatusCode.FORBIDDEN_403
|
|
})
|
|
}
|
|
})
|
|
|
|
it('Should fail with a long name', async function () {
|
|
const fields = { ...baseCorrectParams, name: 'super'.repeat(65) }
|
|
|
|
await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with a bad category', async function () {
|
|
const fields = { ...baseCorrectParams, category: 125 }
|
|
|
|
await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with a bad licence', async function () {
|
|
const fields = { ...baseCorrectParams, licence: 125 }
|
|
|
|
await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with a bad language', async function () {
|
|
const fields = { ...baseCorrectParams, language: 'a'.repeat(15) }
|
|
|
|
await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with a long description', async function () {
|
|
const fields = { ...baseCorrectParams, description: 'super'.repeat(2500) }
|
|
|
|
await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with a long support text', async function () {
|
|
const fields = { ...baseCorrectParams, support: 'super'.repeat(201) }
|
|
|
|
await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail without a channel', async function () {
|
|
const fields = omit(baseCorrectParams, 'channelId')
|
|
|
|
await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with a bad channel', async function () {
|
|
const fields = { ...baseCorrectParams, channelId: 545454 }
|
|
|
|
await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with another user channel', async function () {
|
|
const user = {
|
|
username: 'fake',
|
|
password: 'fake_password'
|
|
}
|
|
await server.users.create({ username: user.username, password: user.password })
|
|
|
|
const accessTokenUser = await server.login.getAccessToken(user)
|
|
const { videoChannels } = await server.users.getMyInfo({ token: accessTokenUser })
|
|
const customChannelId = videoChannels[0].id
|
|
|
|
const fields = { ...baseCorrectParams, channelId: customChannelId }
|
|
|
|
await makePostBodyRequest({ url: server.url, path, token: userAccessToken, fields })
|
|
})
|
|
|
|
it('Should fail with too many tags', async function () {
|
|
const fields = { ...baseCorrectParams, tags: [ 'tag1', 'tag2', 'tag3', 'tag4', 'tag5', 'tag6' ] }
|
|
|
|
await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with a tag length too low', async function () {
|
|
const fields = { ...baseCorrectParams, tags: [ 'tag1', 't' ] }
|
|
|
|
await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with a tag length too big', async function () {
|
|
const fields = { ...baseCorrectParams, tags: [ 'tag1', 'my_super_tag_too_long_long_long_long_long_long' ] }
|
|
|
|
await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with an incorrect thumbnail file', async function () {
|
|
const fields = baseCorrectParams
|
|
const attaches = {
|
|
thumbnailfile: buildAbsoluteFixturePath('video_short.mp4')
|
|
}
|
|
|
|
await makeUploadRequest({ url: server.url, path, token: server.accessToken, fields, attaches })
|
|
})
|
|
|
|
it('Should fail with a big thumbnail file', async function () {
|
|
const fields = baseCorrectParams
|
|
const attaches = {
|
|
thumbnailfile: buildAbsoluteFixturePath('preview-big.png')
|
|
}
|
|
|
|
await makeUploadRequest({ url: server.url, path, token: server.accessToken, fields, attaches })
|
|
})
|
|
|
|
it('Should fail with an incorrect preview file', async function () {
|
|
const fields = baseCorrectParams
|
|
const attaches = {
|
|
previewfile: buildAbsoluteFixturePath('video_short.mp4')
|
|
}
|
|
|
|
await makeUploadRequest({ url: server.url, path, token: server.accessToken, fields, attaches })
|
|
})
|
|
|
|
it('Should fail with a big preview file', async function () {
|
|
const fields = baseCorrectParams
|
|
const attaches = {
|
|
previewfile: buildAbsoluteFixturePath('preview-big.png')
|
|
}
|
|
|
|
await makeUploadRequest({ url: server.url, path, token: server.accessToken, fields, attaches })
|
|
})
|
|
|
|
it('Should fail with an invalid torrent file', async function () {
|
|
const fields = omit(baseCorrectParams, 'targetUrl')
|
|
const attaches = {
|
|
torrentfile: buildAbsoluteFixturePath('avatar-big.png')
|
|
}
|
|
|
|
await makeUploadRequest({ url: server.url, path, token: server.accessToken, fields, attaches })
|
|
})
|
|
|
|
it('Should fail with an invalid magnet URI', async function () {
|
|
let fields = omit(baseCorrectParams, 'targetUrl')
|
|
fields = { ...fields, magnetUri: 'blabla' }
|
|
|
|
await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should succeed with the correct parameters', async function () {
|
|
this.timeout(120000)
|
|
|
|
await makePostBodyRequest({
|
|
url: server.url,
|
|
path,
|
|
token: server.accessToken,
|
|
fields: baseCorrectParams,
|
|
expectedStatus: HttpStatusCode.OK_200
|
|
})
|
|
})
|
|
|
|
it('Should forbid to import http videos', async function () {
|
|
await server.config.updateCustomSubConfig({
|
|
newConfig: {
|
|
import: {
|
|
videos: {
|
|
http: {
|
|
enabled: false
|
|
},
|
|
torrent: {
|
|
enabled: true
|
|
}
|
|
}
|
|
}
|
|
}
|
|
})
|
|
|
|
await makePostBodyRequest({
|
|
url: server.url,
|
|
path,
|
|
token: server.accessToken,
|
|
fields: baseCorrectParams,
|
|
expectedStatus: HttpStatusCode.CONFLICT_409
|
|
})
|
|
})
|
|
|
|
it('Should forbid to import torrent videos', async function () {
|
|
await server.config.updateCustomSubConfig({
|
|
newConfig: {
|
|
import: {
|
|
videos: {
|
|
http: {
|
|
enabled: true
|
|
},
|
|
torrent: {
|
|
enabled: false
|
|
}
|
|
}
|
|
}
|
|
}
|
|
})
|
|
|
|
let fields = omit(baseCorrectParams, 'targetUrl')
|
|
fields = { ...fields, magnetUri: FIXTURE_URLS.magnet }
|
|
|
|
await makePostBodyRequest({
|
|
url: server.url,
|
|
path,
|
|
token: server.accessToken,
|
|
fields,
|
|
expectedStatus: HttpStatusCode.CONFLICT_409
|
|
})
|
|
|
|
fields = omit(fields, 'magnetUri')
|
|
const attaches = {
|
|
torrentfile: buildAbsoluteFixturePath('video-720p.torrent')
|
|
}
|
|
|
|
await makeUploadRequest({
|
|
url: server.url,
|
|
path,
|
|
token: server.accessToken,
|
|
fields,
|
|
attaches,
|
|
expectedStatus: HttpStatusCode.CONFLICT_409
|
|
})
|
|
})
|
|
})
|
|
|
|
describe('Deleting/cancelling a video import', function () {
|
|
let importId: number
|
|
|
|
async function importVideo () {
|
|
const attributes = { channelId: server.store.channel.id, targetUrl: FIXTURE_URLS.goodVideo }
|
|
const res = await server.imports.importVideo({ attributes })
|
|
|
|
return res.id
|
|
}
|
|
|
|
before(async function () {
|
|
importId = await importVideo()
|
|
})
|
|
|
|
it('Should fail with an invalid import id', async function () {
|
|
await server.imports.cancel({ importId: 'artyom' as any, expectedStatus: HttpStatusCode.BAD_REQUEST_400 })
|
|
await server.imports.delete({ importId: 'artyom' as any, expectedStatus: HttpStatusCode.BAD_REQUEST_400 })
|
|
})
|
|
|
|
it('Should fail with an unknown import id', async function () {
|
|
await server.imports.cancel({ importId: 42, expectedStatus: HttpStatusCode.NOT_FOUND_404 })
|
|
await server.imports.delete({ importId: 42, expectedStatus: HttpStatusCode.NOT_FOUND_404 })
|
|
})
|
|
|
|
it('Should fail without token', async function () {
|
|
await server.imports.cancel({ importId, token: null, expectedStatus: HttpStatusCode.UNAUTHORIZED_401 })
|
|
await server.imports.delete({ importId, token: null, expectedStatus: HttpStatusCode.UNAUTHORIZED_401 })
|
|
})
|
|
|
|
it('Should fail with another user token', async function () {
|
|
await server.imports.cancel({ importId, token: userAccessToken, expectedStatus: HttpStatusCode.FORBIDDEN_403 })
|
|
await server.imports.delete({ importId, token: userAccessToken, expectedStatus: HttpStatusCode.FORBIDDEN_403 })
|
|
})
|
|
|
|
it('Should fail to cancel non pending import', async function () {
|
|
this.timeout(60000)
|
|
|
|
await waitJobs([ server ])
|
|
|
|
await server.imports.cancel({ importId, expectedStatus: HttpStatusCode.CONFLICT_409 })
|
|
})
|
|
|
|
it('Should succeed to delete an import', async function () {
|
|
await server.imports.delete({ importId })
|
|
})
|
|
|
|
it('Should fail to delete a pending import', async function () {
|
|
await server.jobs.pauseJobQueue()
|
|
|
|
importId = await importVideo()
|
|
|
|
await server.imports.delete({ importId, expectedStatus: HttpStatusCode.CONFLICT_409 })
|
|
})
|
|
|
|
it('Should succeed to cancel an import', async function () {
|
|
importId = await importVideo()
|
|
|
|
await server.imports.cancel({ importId })
|
|
})
|
|
})
|
|
|
|
after(async function () {
|
|
await cleanupTests([ server ])
|
|
})
|
|
})
|