f6d6e7f861
* WIP: resumable video uploads relates to #324 * fix review comments * video upload: error handling * fix audio upload * fixes after self review * Update server/controllers/api/videos/index.ts Co-authored-by: Rigel Kent <par@rigelk.eu> * Update server/middlewares/validators/videos/videos.ts Co-authored-by: Rigel Kent <par@rigelk.eu> * Update server/controllers/api/videos/index.ts Co-authored-by: Rigel Kent <par@rigelk.eu> * update after code review * refactor upload route - restore multipart upload route - move resumable to dedicated upload-resumable route - move checks to middleware - do not leak internal fs structure in response * fix yarn.lock upon rebase * factorize addVideo for reuse in both endpoints * add resumable upload API to openapi spec * add initial test and test helper for resumable upload * typings for videoAddResumable middleware * avoid including aws and google packages via node-uploadx, by only including uploadx/core * rename ex-isAudioBg to more explicit name mentioning it is a preview file for audio * add video-upload-tmp-folder-cleaner job * stronger typing of video upload middleware * reduce dependency to @uploadx/core * add audio upload test * refactor resumable uploads cleanup from job to scheduler * refactor resumable uploads scheduler to compare to last execution time * make resumable upload validator to always cleanup on failure * move legacy upload request building outside of uploadVideo test helper * filter upload-resumable middlewares down to POST, PUT, DELETE also begin to type metadata * merge add duration functions * stronger typings and documentation for uploadx behaviour, move init validator up * refactor(client/video-edit): options > uploadxOptions * refactor(client/video-edit): remove obsolete else * scheduler/remove-dangling-resum: rename tag * refactor(server/video): add UploadVideoFiles type * refactor(mw/validators): restructure eslint disable * refactor(mw/validators/videos): rename import * refactor(client/vid-upload): rename html elem id * refactor(sched/remove-dangl): move fn to method * refactor(mw/async): add method typing * refactor(mw/vali/video): double quote > single * refactor(server/upload-resum): express use > all * proper http methud enum server/middlewares/async.ts * properly type http methods * factorize common video upload validation steps * add check for maximum partially uploaded file size * fix audioBg use * fix extname(filename) in addVideo * document parameters for uploadx's resumable protocol * clear META files in scheduler * last audio refactor before cramming preview in the initial POST form data * refactor as mulitpart/form-data initial post request this allows preview/thumbnail uploads alongside the initial request, and cleans up the upload form * Add more tests for resumable uploads * Refactor remove dangling resumable uploads * Prepare changelog * Add more resumable upload tests * Remove user quota check for resumable uploads * Fix upload error handler * Update nginx template for upload-resumable * Cleanup comment * Remove unused express methods * Prefer to use got instead of raw http * Don't retry on error 500 Co-authored-by: Rigel Kent <par@rigelk.eu> Co-authored-by: Rigel Kent <sendmemail@rigelk.eu> Co-authored-by: Chocobozzz <me@florianbigard.com>
766 lines
27 KiB
TypeScript
766 lines
27 KiB
TypeScript
/* eslint-disable @typescript-eslint/no-unused-expressions,@typescript-eslint/require-await */
|
|
|
|
import 'mocha'
|
|
import * as chai from 'chai'
|
|
import { omit } from 'lodash'
|
|
import { join } from 'path'
|
|
import { HttpStatusCode } from '../../../../shared/core-utils/miscs/http-error-codes'
|
|
import {
|
|
checkUploadVideoParam,
|
|
cleanupTests,
|
|
createUser,
|
|
flushAndRunServer,
|
|
getMyUserInformation,
|
|
getVideo,
|
|
getVideosList,
|
|
immutableAssign,
|
|
makeDeleteRequest,
|
|
makeGetRequest,
|
|
makePutBodyRequest,
|
|
makeUploadRequest,
|
|
removeVideo,
|
|
root,
|
|
ServerInfo,
|
|
setAccessTokensToServers,
|
|
userLogin
|
|
} from '../../../../shared/extra-utils'
|
|
import {
|
|
checkBadCountPagination,
|
|
checkBadSortPagination,
|
|
checkBadStartPagination
|
|
} from '../../../../shared/extra-utils/requests/check-api-params'
|
|
import { VideoPrivacy } from '../../../../shared/models/videos/video-privacy.enum'
|
|
import { randomInt } from '@shared/core-utils'
|
|
|
|
const expect = chai.expect
|
|
|
|
describe('Test videos API validator', function () {
|
|
const path = '/api/v1/videos/'
|
|
let server: ServerInfo
|
|
let userAccessToken = ''
|
|
let accountName: string
|
|
let channelId: number
|
|
let channelName: string
|
|
let videoId
|
|
|
|
// ---------------------------------------------------------------
|
|
|
|
before(async function () {
|
|
this.timeout(30000)
|
|
|
|
server = await flushAndRunServer(1)
|
|
|
|
await setAccessTokensToServers([ server ])
|
|
|
|
const username = 'user1'
|
|
const password = 'my super password'
|
|
await createUser({ url: server.url, accessToken: server.accessToken, username: username, password: password })
|
|
userAccessToken = await userLogin(server, { username, password })
|
|
|
|
{
|
|
const res = await getMyUserInformation(server.url, server.accessToken)
|
|
channelId = res.body.videoChannels[0].id
|
|
channelName = res.body.videoChannels[0].name
|
|
accountName = res.body.account.name + '@' + res.body.account.host
|
|
}
|
|
})
|
|
|
|
describe('When listing videos', function () {
|
|
it('Should fail with a bad start pagination', async function () {
|
|
await checkBadStartPagination(server.url, path)
|
|
})
|
|
|
|
it('Should fail with a bad count pagination', async function () {
|
|
await checkBadCountPagination(server.url, path)
|
|
})
|
|
|
|
it('Should fail with an incorrect sort', async function () {
|
|
await checkBadSortPagination(server.url, path)
|
|
})
|
|
|
|
it('Should fail with a bad skipVideos query', async function () {
|
|
await makeGetRequest({ url: server.url, path, statusCodeExpected: HttpStatusCode.OK_200, query: { skipCount: 'toto' } })
|
|
})
|
|
|
|
it('Should success with the correct parameters', async function () {
|
|
await makeGetRequest({ url: server.url, path, statusCodeExpected: HttpStatusCode.OK_200, query: { skipCount: false } })
|
|
})
|
|
})
|
|
|
|
describe('When searching a video', function () {
|
|
|
|
it('Should fail with nothing', async function () {
|
|
await makeGetRequest({
|
|
url: server.url,
|
|
path: join(path, 'search'),
|
|
statusCodeExpected: HttpStatusCode.BAD_REQUEST_400
|
|
})
|
|
})
|
|
|
|
it('Should fail with a bad start pagination', async function () {
|
|
await checkBadStartPagination(server.url, join(path, 'search', 'test'))
|
|
})
|
|
|
|
it('Should fail with a bad count pagination', async function () {
|
|
await checkBadCountPagination(server.url, join(path, 'search', 'test'))
|
|
})
|
|
|
|
it('Should fail with an incorrect sort', async function () {
|
|
await checkBadSortPagination(server.url, join(path, 'search', 'test'))
|
|
})
|
|
|
|
it('Should success with the correct parameters', async function () {
|
|
await makeGetRequest({ url: server.url, path, statusCodeExpected: HttpStatusCode.OK_200 })
|
|
})
|
|
})
|
|
|
|
describe('When listing my videos', function () {
|
|
const path = '/api/v1/users/me/videos'
|
|
|
|
it('Should fail with a bad start pagination', async function () {
|
|
await checkBadStartPagination(server.url, path, server.accessToken)
|
|
})
|
|
|
|
it('Should fail with a bad count pagination', async function () {
|
|
await checkBadCountPagination(server.url, path, server.accessToken)
|
|
})
|
|
|
|
it('Should fail with an incorrect sort', async function () {
|
|
await checkBadSortPagination(server.url, path, server.accessToken)
|
|
})
|
|
|
|
it('Should success with the correct parameters', async function () {
|
|
await makeGetRequest({ url: server.url, token: server.accessToken, path, statusCodeExpected: HttpStatusCode.OK_200 })
|
|
})
|
|
})
|
|
|
|
describe('When listing account videos', function () {
|
|
let path: string
|
|
|
|
before(async function () {
|
|
path = '/api/v1/accounts/' + accountName + '/videos'
|
|
})
|
|
|
|
it('Should fail with a bad start pagination', async function () {
|
|
await checkBadStartPagination(server.url, path, server.accessToken)
|
|
})
|
|
|
|
it('Should fail with a bad count pagination', async function () {
|
|
await checkBadCountPagination(server.url, path, server.accessToken)
|
|
})
|
|
|
|
it('Should fail with an incorrect sort', async function () {
|
|
await checkBadSortPagination(server.url, path, server.accessToken)
|
|
})
|
|
|
|
it('Should success with the correct parameters', async function () {
|
|
await makeGetRequest({ url: server.url, path, statusCodeExpected: HttpStatusCode.OK_200 })
|
|
})
|
|
})
|
|
|
|
describe('When listing video channel videos', function () {
|
|
let path: string
|
|
|
|
before(async function () {
|
|
path = '/api/v1/video-channels/' + channelName + '/videos'
|
|
})
|
|
|
|
it('Should fail with a bad start pagination', async function () {
|
|
await checkBadStartPagination(server.url, path, server.accessToken)
|
|
})
|
|
|
|
it('Should fail with a bad count pagination', async function () {
|
|
await checkBadCountPagination(server.url, path, server.accessToken)
|
|
})
|
|
|
|
it('Should fail with an incorrect sort', async function () {
|
|
await checkBadSortPagination(server.url, path, server.accessToken)
|
|
})
|
|
|
|
it('Should success with the correct parameters', async function () {
|
|
await makeGetRequest({ url: server.url, path, statusCodeExpected: HttpStatusCode.OK_200 })
|
|
})
|
|
})
|
|
|
|
describe('When adding a video', function () {
|
|
let baseCorrectParams
|
|
const baseCorrectAttaches = {
|
|
fixture: join(root(), 'server', 'tests', 'fixtures', 'video_short.webm')
|
|
}
|
|
|
|
before(function () {
|
|
// Put in before to have channelId
|
|
baseCorrectParams = {
|
|
name: 'my super name',
|
|
category: 5,
|
|
licence: 1,
|
|
language: 'pt',
|
|
nsfw: false,
|
|
commentsEnabled: true,
|
|
downloadEnabled: true,
|
|
waitTranscoding: true,
|
|
description: 'my super description',
|
|
support: 'my super support text',
|
|
tags: [ 'tag1', 'tag2' ],
|
|
privacy: VideoPrivacy.PUBLIC,
|
|
channelId: channelId,
|
|
originallyPublishedAt: new Date().toISOString()
|
|
}
|
|
})
|
|
|
|
function runSuite (mode: 'legacy' | 'resumable') {
|
|
|
|
it('Should fail with nothing', async function () {
|
|
const fields = {}
|
|
const attaches = {}
|
|
await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
|
|
})
|
|
|
|
it('Should fail without name', async function () {
|
|
const fields = omit(baseCorrectParams, 'name')
|
|
const attaches = baseCorrectAttaches
|
|
|
|
await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
|
|
})
|
|
|
|
it('Should fail with a long name', async function () {
|
|
const fields = immutableAssign(baseCorrectParams, { name: 'super'.repeat(65) })
|
|
const attaches = baseCorrectAttaches
|
|
|
|
await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
|
|
})
|
|
|
|
it('Should fail with a bad category', async function () {
|
|
const fields = immutableAssign(baseCorrectParams, { category: 125 })
|
|
const attaches = baseCorrectAttaches
|
|
|
|
await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
|
|
})
|
|
|
|
it('Should fail with a bad licence', async function () {
|
|
const fields = immutableAssign(baseCorrectParams, { licence: 125 })
|
|
const attaches = baseCorrectAttaches
|
|
|
|
await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
|
|
})
|
|
|
|
it('Should fail with a bad language', async function () {
|
|
const fields = immutableAssign(baseCorrectParams, { language: 'a'.repeat(15) })
|
|
const attaches = baseCorrectAttaches
|
|
|
|
await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
|
|
})
|
|
|
|
it('Should fail with a long description', async function () {
|
|
const fields = immutableAssign(baseCorrectParams, { description: 'super'.repeat(2500) })
|
|
const attaches = baseCorrectAttaches
|
|
|
|
await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
|
|
})
|
|
|
|
it('Should fail with a long support text', async function () {
|
|
const fields = immutableAssign(baseCorrectParams, { support: 'super'.repeat(201) })
|
|
const attaches = baseCorrectAttaches
|
|
|
|
await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
|
|
})
|
|
|
|
it('Should fail without a channel', async function () {
|
|
const fields = omit(baseCorrectParams, 'channelId')
|
|
const attaches = baseCorrectAttaches
|
|
|
|
await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
|
|
})
|
|
|
|
it('Should fail with a bad channel', async function () {
|
|
const fields = immutableAssign(baseCorrectParams, { channelId: 545454 })
|
|
const attaches = baseCorrectAttaches
|
|
|
|
await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
|
|
})
|
|
|
|
it('Should fail with another user channel', async function () {
|
|
const user = {
|
|
username: 'fake' + randomInt(0, 1500),
|
|
password: 'fake_password'
|
|
}
|
|
await createUser({ url: server.url, accessToken: server.accessToken, username: user.username, password: user.password })
|
|
|
|
const accessTokenUser = await userLogin(server, user)
|
|
const res = await getMyUserInformation(server.url, accessTokenUser)
|
|
const customChannelId = res.body.videoChannels[0].id
|
|
|
|
const fields = immutableAssign(baseCorrectParams, { channelId: customChannelId })
|
|
const attaches = baseCorrectAttaches
|
|
|
|
await checkUploadVideoParam(server.url, userAccessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
|
|
})
|
|
|
|
it('Should fail with too many tags', async function () {
|
|
const fields = immutableAssign(baseCorrectParams, { tags: [ 'tag1', 'tag2', 'tag3', 'tag4', 'tag5', 'tag6' ] })
|
|
const attaches = baseCorrectAttaches
|
|
|
|
await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
|
|
})
|
|
|
|
it('Should fail with a tag length too low', async function () {
|
|
const fields = immutableAssign(baseCorrectParams, { tags: [ 'tag1', 't' ] })
|
|
const attaches = baseCorrectAttaches
|
|
|
|
await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
|
|
})
|
|
|
|
it('Should fail with a tag length too big', async function () {
|
|
const fields = immutableAssign(baseCorrectParams, { tags: [ 'tag1', 'my_super_tag_too_long_long_long_long_long_long' ] })
|
|
const attaches = baseCorrectAttaches
|
|
|
|
await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
|
|
})
|
|
|
|
it('Should fail with a bad schedule update (miss updateAt)', async function () {
|
|
const fields = immutableAssign(baseCorrectParams, { scheduleUpdate: { privacy: VideoPrivacy.PUBLIC } })
|
|
const attaches = baseCorrectAttaches
|
|
|
|
await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
|
|
})
|
|
|
|
it('Should fail with a bad schedule update (wrong updateAt)', async function () {
|
|
const fields = immutableAssign(baseCorrectParams, {
|
|
scheduleUpdate: {
|
|
privacy: VideoPrivacy.PUBLIC,
|
|
updateAt: 'toto'
|
|
}
|
|
})
|
|
const attaches = baseCorrectAttaches
|
|
|
|
await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
|
|
})
|
|
|
|
it('Should fail with a bad originally published at attribute', async function () {
|
|
const fields = immutableAssign(baseCorrectParams, { originallyPublishedAt: 'toto' })
|
|
const attaches = baseCorrectAttaches
|
|
|
|
await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
|
|
})
|
|
|
|
it('Should fail without an input file', async function () {
|
|
const fields = baseCorrectParams
|
|
const attaches = {}
|
|
await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
|
|
})
|
|
|
|
it('Should fail with an incorrect input file', async function () {
|
|
const fields = baseCorrectParams
|
|
let attaches = { fixture: join(root(), 'server', 'tests', 'fixtures', 'video_short_fake.webm') }
|
|
|
|
await checkUploadVideoParam(
|
|
server.url,
|
|
server.accessToken,
|
|
{ ...fields, ...attaches },
|
|
HttpStatusCode.UNPROCESSABLE_ENTITY_422,
|
|
mode
|
|
)
|
|
|
|
attaches = { fixture: join(root(), 'server', 'tests', 'fixtures', 'video_short.mkv') }
|
|
await checkUploadVideoParam(
|
|
server.url,
|
|
server.accessToken,
|
|
{ ...fields, ...attaches },
|
|
HttpStatusCode.UNSUPPORTED_MEDIA_TYPE_415,
|
|
mode
|
|
)
|
|
})
|
|
|
|
it('Should fail with an incorrect thumbnail file', async function () {
|
|
const fields = baseCorrectParams
|
|
const attaches = {
|
|
thumbnailfile: join(root(), 'server', 'tests', 'fixtures', 'video_short.mp4'),
|
|
fixture: join(root(), 'server', 'tests', 'fixtures', 'video_short.mp4')
|
|
}
|
|
|
|
await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
|
|
})
|
|
|
|
it('Should fail with a big thumbnail file', async function () {
|
|
const fields = baseCorrectParams
|
|
const attaches = {
|
|
thumbnailfile: join(root(), 'server', 'tests', 'fixtures', 'preview-big.png'),
|
|
fixture: join(root(), 'server', 'tests', 'fixtures', 'video_short.mp4')
|
|
}
|
|
|
|
await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
|
|
})
|
|
|
|
it('Should fail with an incorrect preview file', async function () {
|
|
const fields = baseCorrectParams
|
|
const attaches = {
|
|
previewfile: join(root(), 'server', 'tests', 'fixtures', 'video_short.mp4'),
|
|
fixture: join(root(), 'server', 'tests', 'fixtures', 'video_short.mp4')
|
|
}
|
|
|
|
await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
|
|
})
|
|
|
|
it('Should fail with a big preview file', async function () {
|
|
const fields = baseCorrectParams
|
|
const attaches = {
|
|
previewfile: join(root(), 'server', 'tests', 'fixtures', 'preview-big.png'),
|
|
fixture: join(root(), 'server', 'tests', 'fixtures', 'video_short.mp4')
|
|
}
|
|
|
|
await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.BAD_REQUEST_400, mode)
|
|
})
|
|
|
|
it('Should succeed with the correct parameters', async function () {
|
|
this.timeout(10000)
|
|
|
|
const fields = baseCorrectParams
|
|
|
|
{
|
|
const attaches = baseCorrectAttaches
|
|
await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.OK_200, mode)
|
|
}
|
|
|
|
{
|
|
const attaches = immutableAssign(baseCorrectAttaches, {
|
|
videofile: join(root(), 'server', 'tests', 'fixtures', 'video_short.mp4')
|
|
})
|
|
|
|
await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.OK_200, mode)
|
|
}
|
|
|
|
{
|
|
const attaches = immutableAssign(baseCorrectAttaches, {
|
|
videofile: join(root(), 'server', 'tests', 'fixtures', 'video_short.ogv')
|
|
})
|
|
|
|
await checkUploadVideoParam(server.url, server.accessToken, { ...fields, ...attaches }, HttpStatusCode.OK_200, mode)
|
|
}
|
|
})
|
|
}
|
|
|
|
describe('Resumable upload', function () {
|
|
runSuite('resumable')
|
|
})
|
|
|
|
describe('Legacy upload', function () {
|
|
runSuite('legacy')
|
|
})
|
|
})
|
|
|
|
describe('When updating a video', function () {
|
|
const baseCorrectParams = {
|
|
name: 'my super name',
|
|
category: 5,
|
|
licence: 2,
|
|
language: 'pt',
|
|
nsfw: false,
|
|
commentsEnabled: false,
|
|
downloadEnabled: false,
|
|
description: 'my super description',
|
|
privacy: VideoPrivacy.PUBLIC,
|
|
tags: [ 'tag1', 'tag2' ]
|
|
}
|
|
|
|
before(async function () {
|
|
const res = await getVideosList(server.url)
|
|
videoId = res.body.data[0].uuid
|
|
})
|
|
|
|
it('Should fail with nothing', async function () {
|
|
const fields = {}
|
|
await makePutBodyRequest({ url: server.url, path, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail without a valid uuid', async function () {
|
|
const fields = baseCorrectParams
|
|
await makePutBodyRequest({ url: server.url, path: path + 'blabla', token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with an unknown id', async function () {
|
|
const fields = baseCorrectParams
|
|
|
|
await makePutBodyRequest({
|
|
url: server.url,
|
|
path: path + '4da6fde3-88f7-4d16-b119-108df5630b06',
|
|
token: server.accessToken,
|
|
fields,
|
|
statusCodeExpected: HttpStatusCode.NOT_FOUND_404
|
|
})
|
|
})
|
|
|
|
it('Should fail with a long name', async function () {
|
|
const fields = immutableAssign(baseCorrectParams, { name: 'super'.repeat(65) })
|
|
|
|
await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with a bad category', async function () {
|
|
const fields = immutableAssign(baseCorrectParams, { category: 125 })
|
|
|
|
await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with a bad licence', async function () {
|
|
const fields = immutableAssign(baseCorrectParams, { licence: 125 })
|
|
|
|
await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with a bad language', async function () {
|
|
const fields = immutableAssign(baseCorrectParams, { language: 'a'.repeat(15) })
|
|
|
|
await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with a long description', async function () {
|
|
const fields = immutableAssign(baseCorrectParams, { description: 'super'.repeat(2500) })
|
|
|
|
await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with a long support text', async function () {
|
|
const fields = immutableAssign(baseCorrectParams, { support: 'super'.repeat(201) })
|
|
|
|
await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with a bad channel', async function () {
|
|
const fields = immutableAssign(baseCorrectParams, { channelId: 545454 })
|
|
|
|
await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with too many tags', async function () {
|
|
const fields = immutableAssign(baseCorrectParams, { tags: [ 'tag1', 'tag2', 'tag3', 'tag4', 'tag5', 'tag6' ] })
|
|
|
|
await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with a tag length too low', async function () {
|
|
const fields = immutableAssign(baseCorrectParams, { tags: [ 'tag1', 't' ] })
|
|
|
|
await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with a tag length too big', async function () {
|
|
const fields = immutableAssign(baseCorrectParams, { tags: [ 'tag1', 'my_super_tag_too_long_long_long_long_long_long' ] })
|
|
|
|
await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with a bad schedule update (miss updateAt)', async function () {
|
|
const fields = immutableAssign(baseCorrectParams, { scheduleUpdate: { privacy: VideoPrivacy.PUBLIC } })
|
|
|
|
await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with a bad schedule update (wrong updateAt)', async function () {
|
|
const fields = immutableAssign(baseCorrectParams, { scheduleUpdate: { updateAt: 'toto', privacy: VideoPrivacy.PUBLIC } })
|
|
|
|
await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with a bad originally published at param', async function () {
|
|
const fields = immutableAssign(baseCorrectParams, { originallyPublishedAt: 'toto' })
|
|
|
|
await makePutBodyRequest({ url: server.url, path: path + videoId, token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with an incorrect thumbnail file', async function () {
|
|
const fields = baseCorrectParams
|
|
const attaches = {
|
|
thumbnailfile: join(root(), 'server', 'tests', 'fixtures', 'video_short.mp4')
|
|
}
|
|
|
|
await makeUploadRequest({
|
|
url: server.url,
|
|
method: 'PUT',
|
|
path: path + videoId,
|
|
token: server.accessToken,
|
|
fields,
|
|
attaches
|
|
})
|
|
})
|
|
|
|
it('Should fail with a big thumbnail file', async function () {
|
|
const fields = baseCorrectParams
|
|
const attaches = {
|
|
thumbnailfile: join(root(), 'server', 'tests', 'fixtures', 'preview-big.png')
|
|
}
|
|
|
|
await makeUploadRequest({
|
|
url: server.url,
|
|
method: 'PUT',
|
|
path: path + videoId,
|
|
token: server.accessToken,
|
|
fields,
|
|
attaches
|
|
})
|
|
})
|
|
|
|
it('Should fail with an incorrect preview file', async function () {
|
|
const fields = baseCorrectParams
|
|
const attaches = {
|
|
previewfile: join(root(), 'server', 'tests', 'fixtures', 'video_short.mp4')
|
|
}
|
|
|
|
await makeUploadRequest({
|
|
url: server.url,
|
|
method: 'PUT',
|
|
path: path + videoId,
|
|
token: server.accessToken,
|
|
fields,
|
|
attaches
|
|
})
|
|
})
|
|
|
|
it('Should fail with a big preview file', async function () {
|
|
const fields = baseCorrectParams
|
|
const attaches = {
|
|
previewfile: join(root(), 'server', 'tests', 'fixtures', 'preview-big.png')
|
|
}
|
|
|
|
await makeUploadRequest({
|
|
url: server.url,
|
|
method: 'PUT',
|
|
path: path + videoId,
|
|
token: server.accessToken,
|
|
fields,
|
|
attaches
|
|
})
|
|
})
|
|
|
|
it('Should fail with a video of another user without the appropriate right', async function () {
|
|
const fields = baseCorrectParams
|
|
|
|
await makePutBodyRequest({
|
|
url: server.url,
|
|
path: path + videoId,
|
|
token: userAccessToken,
|
|
fields,
|
|
statusCodeExpected: HttpStatusCode.FORBIDDEN_403
|
|
})
|
|
})
|
|
|
|
it('Should fail with a video of another server')
|
|
|
|
it('Should succeed with the correct parameters', async function () {
|
|
const fields = baseCorrectParams
|
|
|
|
await makePutBodyRequest({
|
|
url: server.url,
|
|
path: path + videoId,
|
|
token: server.accessToken,
|
|
fields,
|
|
statusCodeExpected: HttpStatusCode.NO_CONTENT_204
|
|
})
|
|
})
|
|
})
|
|
|
|
describe('When getting a video', function () {
|
|
it('Should return the list of the videos with nothing', async function () {
|
|
const res = await makeGetRequest({
|
|
url: server.url,
|
|
path,
|
|
statusCodeExpected: HttpStatusCode.OK_200
|
|
})
|
|
|
|
expect(res.body.data).to.be.an('array')
|
|
expect(res.body.data.length).to.equal(6)
|
|
})
|
|
|
|
it('Should fail without a correct uuid', async function () {
|
|
await getVideo(server.url, 'coucou', HttpStatusCode.BAD_REQUEST_400)
|
|
})
|
|
|
|
it('Should return 404 with an incorrect video', async function () {
|
|
await getVideo(server.url, '4da6fde3-88f7-4d16-b119-108df5630b06', HttpStatusCode.NOT_FOUND_404)
|
|
})
|
|
|
|
it('Should succeed with the correct parameters', async function () {
|
|
await getVideo(server.url, videoId)
|
|
})
|
|
})
|
|
|
|
describe('When rating a video', function () {
|
|
let videoId
|
|
|
|
before(async function () {
|
|
const res = await getVideosList(server.url)
|
|
videoId = res.body.data[0].id
|
|
})
|
|
|
|
it('Should fail without a valid uuid', async function () {
|
|
const fields = {
|
|
rating: 'like'
|
|
}
|
|
await makePutBodyRequest({ url: server.url, path: path + 'blabla/rate', token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should fail with an unknown id', async function () {
|
|
const fields = {
|
|
rating: 'like'
|
|
}
|
|
await makePutBodyRequest({
|
|
url: server.url,
|
|
path: path + '4da6fde3-88f7-4d16-b119-108df5630b06/rate',
|
|
token: server.accessToken,
|
|
fields,
|
|
statusCodeExpected: HttpStatusCode.NOT_FOUND_404
|
|
})
|
|
})
|
|
|
|
it('Should fail with a wrong rating', async function () {
|
|
const fields = {
|
|
rating: 'likes'
|
|
}
|
|
await makePutBodyRequest({ url: server.url, path: path + videoId + '/rate', token: server.accessToken, fields })
|
|
})
|
|
|
|
it('Should succeed with the correct parameters', async function () {
|
|
const fields = {
|
|
rating: 'like'
|
|
}
|
|
await makePutBodyRequest({
|
|
url: server.url,
|
|
path: path + videoId + '/rate',
|
|
token: server.accessToken,
|
|
fields,
|
|
statusCodeExpected: HttpStatusCode.NO_CONTENT_204
|
|
})
|
|
})
|
|
})
|
|
|
|
describe('When removing a video', function () {
|
|
it('Should have 404 with nothing', async function () {
|
|
await makeDeleteRequest({
|
|
url: server.url,
|
|
path,
|
|
statusCodeExpected: HttpStatusCode.BAD_REQUEST_400
|
|
})
|
|
})
|
|
|
|
it('Should fail without a correct uuid', async function () {
|
|
await removeVideo(server.url, server.accessToken, 'hello', HttpStatusCode.BAD_REQUEST_400)
|
|
})
|
|
|
|
it('Should fail with a video which does not exist', async function () {
|
|
await removeVideo(server.url, server.accessToken, '4da6fde3-88f7-4d16-b119-108df5630b06', HttpStatusCode.NOT_FOUND_404)
|
|
})
|
|
|
|
it('Should fail with a video of another user without the appropriate right', async function () {
|
|
await removeVideo(server.url, userAccessToken, videoId, HttpStatusCode.FORBIDDEN_403)
|
|
})
|
|
|
|
it('Should fail with a video of another server')
|
|
|
|
it('Should succeed with the correct parameters', async function () {
|
|
await removeVideo(server.url, server.accessToken, videoId)
|
|
})
|
|
})
|
|
|
|
after(async function () {
|
|
await cleanupTests([ server ])
|
|
})
|
|
})
|