kotovalexarian-likes-github
/
activerecord-hackery--ransack
mirror of https://github.com/activerecord-hackery/ransack.git
1
0
Fork 0
Code Releases Activity

sort_fields can be a local variable instead of an ivar

This commit is contained in:
Jon Atack 2014-12-07 21:58:29 +01:00
parent 47c630e285
commit 16edfb479b
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/ransack/helpers/form_helper.rb
View File

@ -57,7 +57,7 @@ module Ransack
# Ivars are not mutated outside of this method. # Ivars are not mutated outside of this method.
def initialize!(search, attribute, args) def initialize!(search, attribute, args)
@field_name = attribute.to_s @field_name = attribute.to_s
@sort_fields, args = extract_sort_fields(args) sort_fields, args = extract_sort_fields(args)
@label_text, args = extract_label_text(args) @label_text, args = extract_label_text(args)
@options, args = extract_options(args) @options, args = extract_options(args)
@hide_indicator = @options.delete :hide_indicator @hide_indicator = @options.delete :hide_indicator
@ -65,7 +65,7 @@ module Ransack
if Hash === @default_order if Hash === @default_order
@default_order = @default_order.with_indifferent_access @default_order = @default_order.with_indifferent_access
end end
@sort_params = initialize_sort_params @sort_params = initialize_sort_params(sort_fields)
@sort_params = @sort_params.first if @sort_params.size == 1 @sort_params = @sort_params.first if @sort_params.size == 1
@current_dir = existing_sort_direction @current_dir = existing_sort_direction
end end
@ -139,8 +139,8 @@ module Ransack
end end
end end
def initialize_sort_params def initialize_sort_params(sort_fields)
@sort_fields.each_with_object([]) do |field, a| sort_fields.each_with_object([]) do |field, a|
attr_name, new_dir = field.to_s.split(/\s+/) attr_name, new_dir = field.to_s.split(/\s+/)
if no_sort_direction_specified?(new_dir) if no_sort_direction_specified?(new_dir)
new_dir = detect_previous_sort_direction_and_invert_it(attr_name) new_dir = detect_previous_sort_direction_and_invert_it(attr_name)