kotovalexarian-likes-github
/
activerecord-hackery--ransack
mirror of https://github.com/activerecord-hackery/ransack.git
1
0
Fork 0
Code Releases Activity

Follow-up: Remove unneeded specs after fix.

This commit is contained in:
Jon Atack 2014-10-12 23:07:27 +02:00
parent f48d94a3bd
commit b6585a0110
1 changed files with 10 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
spec/ransack/predicate_spec.rb
View File

@ -48,19 +48,11 @@ module Ransack
expect(@s.result.to_sql).to match /#{field} <= #{val}/
end
if ::ActiveRecord::VERSION::STRING < '4.2'.freeze
it 'generates a <= condition with a string column' do
val = 'jane@doe.com'
@s.email_lteq = val
field = "#{quote_table_name("people")}.#{quote_column_name("email")}"
expect(@s.result.to_sql).to match /#{field} <= '#{val}'/
end
else
# FIXME Rails 4.2 should be able to handle strings like Rails < 4.2 does.
it 'raises an error with a string column' do
@s.email_lteq = 'jane@doe.com'
expect { @s.result.to_sql }.to raise_error
end
it 'generates a <= condition with a string column' do
val = 'jane@doe.com'
@s.email_lteq = val
field = "#{quote_table_name("people")}.#{quote_column_name("email")}"
expect(@s.result.to_sql).to match /#{field} <= '#{val}'/
end
it 'does not generate a condition for nil' do
@ -77,19 +69,11 @@ module Ransack
expect(@s.result.to_sql).to match /#{field} < #{val}/
end
if ::ActiveRecord::VERSION::STRING < '4.2'.freeze
it 'generates a < condition with a string column' do
val = 'jane@doe.com'
@s.email_lt = val
field = "#{quote_table_name("people")}.#{quote_column_name("email")}"
expect(@s.result.to_sql).to match /#{field} < '#{val}'/
end
else
# FIXME Rails 4.2 should be able to handle strings like Rails < 4.2 does.
it 'raises an error with a string column' do
@s.email_lteq = 'jane@doe.com'
expect { @s.result.to_sql }.to raise_error
end
it 'generates a < condition with a string column' do
val = 'jane@doe.com'
@s.email_lt = val
field = "#{quote_table_name("people")}.#{quote_column_name("email")}"
expect(@s.result.to_sql).to match /#{field} < '#{val}'/
end
it 'does not generate a condition for nil' do