From db462304a5b6c40decb84f3df1536d4c4b464e3e Mon Sep 17 00:00:00 2001 From: Ryuta Kamizono Date: Fri, 10 Aug 2018 10:01:44 +0900 Subject: [PATCH] `JoinPart#==` is already replaced with `JoinPart#match?` See https://github.com/rails/rails/commit/e73fbdf804633f8e151a33e681f370dfa0fbb3a0. --- .../activerecord_5.1_ruby_2/join_association.rb | 7 ------- .../activerecord_5.2.0_ruby_2/join_association.rb | 7 ------- .../activerecord_5.2.1_ruby_2/join_association.rb | 7 ------- 3 files changed, 21 deletions(-) diff --git a/lib/polyamorous/activerecord_5.1_ruby_2/join_association.rb b/lib/polyamorous/activerecord_5.1_ruby_2/join_association.rb index 59e618c..9a0b1f3 100644 --- a/lib/polyamorous/activerecord_5.1_ruby_2/join_association.rb +++ b/lib/polyamorous/activerecord_5.1_ruby_2/join_association.rb @@ -20,13 +20,6 @@ module Polyamorous end end - # Reference: https://github.com/rails/rails/commit/9b15db5 - # NOTE: Not sure we still need it? - # - def ==(other) - base_klass == other.base_klass - end - def build_constraint(klass, table, key, foreign_table, foreign_key) if reflection.polymorphic? super(klass, table, key, foreign_table, foreign_key) diff --git a/lib/polyamorous/activerecord_5.2.0_ruby_2/join_association.rb b/lib/polyamorous/activerecord_5.2.0_ruby_2/join_association.rb index a3a2733..b9be34c 100644 --- a/lib/polyamorous/activerecord_5.2.0_ruby_2/join_association.rb +++ b/lib/polyamorous/activerecord_5.2.0_ruby_2/join_association.rb @@ -20,13 +20,6 @@ module Polyamorous end end - # Reference: https://github.com/rails/rails/commit/9b15db5 - # NOTE: Not sure we still need it? - # - def ==(other) - base_klass == other.base_klass - end - def build_constraint(klass, table, key, foreign_table, foreign_key) if reflection.polymorphic? super(klass, table, key, foreign_table, foreign_key) diff --git a/lib/polyamorous/activerecord_5.2.1_ruby_2/join_association.rb b/lib/polyamorous/activerecord_5.2.1_ruby_2/join_association.rb index d72d766..97f7068 100644 --- a/lib/polyamorous/activerecord_5.2.1_ruby_2/join_association.rb +++ b/lib/polyamorous/activerecord_5.2.1_ruby_2/join_association.rb @@ -19,13 +19,6 @@ module Polyamorous end end - # Reference: https://github.com/rails/rails/commit/9b15db5 - # NOTE: Not sure we still need it? - # - def ==(other) - base_klass == other.base_klass - end - def build_constraint(klass, table, key, foreign_table, foreign_key) if reflection.polymorphic? super(klass, table, key, foreign_table, foreign_key)