mirror of
https://github.com/awesome-print/awesome_print
synced 2023-03-27 23:22:34 -04:00
Update Contributing to reflect reality
Previously it seems that PRs were responded to within 1-3 days, however this has not been the case for about a year so I'm udating the relevant section of this guide in order to set more realistic expectations. This is mainly so people do not get discouraged when they see we haven't responded after a few days.
This commit is contained in:
parent
c0df203f03
commit
509c9ad000
1 changed files with 3 additions and 4 deletions
|
@ -8,15 +8,15 @@ We love pull requests. Here's a quick guide:
|
|||
|
||||
1. Update [CHANGELOG.md](https://github.com/michaeldv/awesome_print/blob/master/CHANGELOG.md) with a brief description of your changes under the `unreleased` heading.
|
||||
|
||||
1. Add/Update tests were appropriate
|
||||
|
||||
1. Commit your changes (`git commit -am 'Added some feature'`)
|
||||
|
||||
1. Push to the branch (`git push origin my-new-feature`)
|
||||
|
||||
1. Create new Pull Request
|
||||
|
||||
At this point you're waiting on us. We like to at least comment on, if not
|
||||
accept, pull requests within three business days (and, typically, one business
|
||||
day). We may suggest some changes or improvements or alternatives.
|
||||
At this point you're waiting on us. We are not super fast at responding, but we will do our best to get to your PR as soon as time permits. We may suggest some changes, improvements or alternatives.
|
||||
|
||||
Some things that will increase the chance that your pull request is accepted is to follow the practices described on [Ruby style guide](https://github.com/bbatsov/ruby-style-guide), [Rails style guide](https://github.com/bbatsov/rails-style-guide) and [Better Specs](http://betterspecs.org/).
|
||||
|
||||
|
@ -79,4 +79,3 @@ Special thanks goes to awesome team of contributors, namely:
|
|||
* Trevor Wennblom -- https://github.com/trevor
|
||||
* vfrride -- https://github.com/vfrride
|
||||
* Viktar Basharymau -- https://github.com/DNNX
|
||||
|
||||
|
|
Loading…
Reference in a new issue