Simplify matching logic in tests

Browse source

Simplify matching logic by adding a custom matcher which
handles the task of normalisation of object IDs instead of
calling gsub many times throughout the test code.

This allows our tests to focus more on what needs to be tested
instead obfuscating the tests with logic unrelated to what
the test is trying to cover.

It also allows making the normalisation code more robust so
there is less chance of an accidental match or typo slipping
in.

The change also replaces the arbitary default object IDs with a
string that makes it very obvious that it is just a placeholder.

...

This commit is contained in:

Gerard Caulfield 2016-05-10 00:04:42 +10:00

parent 28901dcca2

commit c5e8669e9c

No known key found for this signature in database

GPG key ID: 623B327128A9BEC3

6 changed files with 223 additions and 211 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

342

spec/ext/active_record_spec.rb

View file

File diff suppressed because it is too large Load diff