1
0
Fork 0
mirror of https://github.com/awesome-print/awesome_print synced 2023-03-27 23:22:34 -04:00
Commit graph

19 commits

Author SHA1 Message Date
Gerard Caulfield
a65ba3ff38
Use assignments consistent with our style guide
This is so that people do not get warnings about problems in existing
code when we turn on Hound style checks.

---

If git-blame brought you here you may want to read this, the
problem is with git-blame, not this change.

Try running these two lines just once:
```
git config --global alias.praise 'log -p -M --follow --stat --'
git config --global alias.praise-line 'log -p -M --pretty=format:"%h (%an %ai)" -L'
```

Now in future you can use

`git praise <path/to/your/file>`

or if you want to see the evolution of a specific line or range of lines

`git praise-line <start-line>:<end-line>:<path/to/your/file>`

Some examples you should try:
```
git praise lib/awesome_print/version.rb
git praise-line 8:8:lib/awesome_print/version.rb
```

Inspiration for these aliases:

http://blog.andrewray.me/a-better-git-blame/
2016-11-09 17:41:35 +11:00
Gerard Caulfield
4e99526c25
Fix spacing inoconsistencies which conflict with style guide
This is also so that Hound can be introduced without it bugging
people about issues in existing code.

---

If git-blame brought you here you may want to read this, the
problem is with git-blame, not this change.

Try running these two lines just once:
``
git config --global alias.praise 'log -p -M --follow --stat --'
git config --global alias.praise-line 'log -p -M --pretty=format:"%h (%an %ai)" -L'
``

Now in future you can use

`git praise <path/to/your/file>`

or if you want to see the evolution of a specific line or range of lines

`git praise-line <start-line>:<end-line>:<path/to/your/file>`

Some examples you should try:
``
git praise lib/awesome_print/version.rb
git praise-line 8:8:lib/awesome_print/version.rb
``

Inspiration for these aliases:

http://blog.andrewray.me/a-better-git-blame/`
2016-11-09 16:06:33 +11:00
Gerard Caulfield
a7dd25b824
Fix hash syntax inconsistency
Use the ruby 1.9 hash syntax everywhere appropriate. This is to fix style
inconsistencies in the code base. This is also so that Hound can be used
without it bugging people every time they touch an older piece of code
but forget to update the syntax.

If git-blame brought you here you may want to read this, the
problem is with git-blame, not this change.

Try running these two lines just once:
```
git config --global alias.praise 'log -p -M --follow --stat --'
git config --global alias.praise-line 'log -p -M --pretty=format:"%h (%an %ai)"  -L'
```

Now in future you can use

`git praise <path/to/your/file>`

or if you want to see the evolution of a specific line or range of lines

`git praise-line <start-line>:<end-line>:<path/to/your/file>`

Some examples you should try:
```
git praise lib/awesome_print/version.rb
git praise-line 8:8:lib/awesome_print/version.rb
```

Inspiration for these aliases:

http://blog.andrewray.me/a-better-git-blame/
2016-11-09 01:53:17 +11:00
Gerard Caulfield
ce934093b3
Fix string inconsistency
Only using double quoted strings when needing interpolation.

If git-blame brought you here you may want to read this, the
problem is with git-blame, not this change.

Try running these two lines just once:
```
git config --global alias.praise 'log -p -M --follow --stat --'
git config --global alias.praise-line 'log -p -M --pretty=format:"%h (%an %ai)"  -L'
```

Now in future you can use

`git praise <path/to/your/file>`

or if you want to see the evolution of a specific line or range of lines

`git praise-line <start-line>:<end-line>:<path/to/your/file>`

Some examples you should try:
```
git praise lib/awesome_print/version.rb
git praise-line 8:8:lib/awesome_print/version.rb
```

Inspiration for these aliases:

http://blog.andrewray.me/a-better-git-blame/
2016-11-08 17:30:17 +11:00
Gerard Caulfield
f628193028
Ensure stub_dotfile! is called before all specs
The previous stubbing of dotfiles was still allowing calls to fall
through and populate the AwesomePrint.defaults hash which would then
cause some tests to fail if run in a certain order.

e.g. https://github.com/awesome-print/awesome_print/issues/265

One place in particular where this would happen is if you ran the
action_view_spec before other specs as it did not stub the dotfile.

This change makes dotfile stubbing more reliable, specific and
ensures it is run for every spec. I've also removed all instances
where it was being called manually, as this is now not needed due
to it being automatic.
2016-08-27 23:43:32 +10:00
Gerard Caulfield
e41d317e51
Fix outdated ActiveRecord tests
Update the Rails 4.2 ActiveRecord tests to test for the current
format of AR models

Prior to this change the tests were broken
2016-05-10 07:39:59 +10:00
Gerard Caulfield
c5e8669e9c
Simplify matching logic in tests
Simplify matching logic by adding a custom matcher which
handles the task of normalisation of object IDs instead of
calling gsub many times throughout the test code.

This allows our tests to focus more on what needs to be tested
instead obfuscating the tests with logic unrelated to what
the test is trying to cover.

It also allows making the normalisation code more robust so
there is less chance of an accidental match or typo slipping
in.

The change also replaces the arbitary default object IDs with a
string that makes it very obvious that it is just a placeholder.
2016-05-10 04:32:36 +10:00
Mauro George
526f907629 Improves spec runner harness, switches to better env detection.
Does not run rails specs when running mongoid specs

WIP Start of remove BRE to check tests

Remove old helper of active record

Use RSpec skip to skip AR specs

Run ActionView only when needed

Run ActiveSupport only when needed

Run Mongoid only when needed

Create ExtVerifier.require_dependencies

Run MongoMapper only when needed

Always load nokogiri specs

Always load ostruct specs

Run Ripple only when needed

Remove :: when check for defined constants

Require spec_helper directly

Remove 1.8.6 old monkey patch

Add some RSpec configs
2015-01-02 13:20:18 -05:00
Eoin Kelly
52bffc1873 Get specs passing with latest versions of extension gems
* Get specs passing with latest versions of
    * ActiveRecord  4.0.4
    * ActiveSupport 4.0.4
    * MongoMapper   0.13.0
    * Mongoid       4.0.0
    * ActionView    4.0.4
    * Ripple seems to be abandoned so no changes made.
* Clean up ActiveRecord setup:
    * Creating tableless AR objects seems even trickier in Rails 4 so
      simplify testing setup by using an in-memory SQLite DB back-end.

Conflicts:
	spec/ext/active_record_spec.rb
2014-12-29 12:11:08 -05:00
adamjonas
2bc678bba5 update rspec syntax from should to expect via transpec 2014-12-18 12:24:30 -05:00
Mike Dvorkin
5463de12e9 Manually merged expanded mongo_mapper support provided by gardelea 2012-09-06 18:16:25 -07:00
Mike Dvorkin
da0defa87a Resolved Mongoid/MongoMapper specs dependency 2012-09-06 16:34:11 -07:00
Mike Dvorkin
f24462a533 Made specs pass with the latest versions of mongo_mapper and mongoid gems 2011-11-24 00:25:52 -08:00
Mike Dvorkin
562201f7dd Streamlined error reporting for the extension specs 2011-11-23 21:33:03 -08:00
Mike Dvorkin
d2c0a398e2 Fixed nested left alighment; fixed ActiveRecord and MongoMapper object specs 2011-11-08 21:27:02 -08:00
Mike Dvorkin
785109a66e Fixed ~/.aprc dependency in specs 2011-11-08 18:30:50 -08:00
Mike Dvorkin
b8822574ec Refactored MongoMapper extension and its specs 2011-05-13 21:07:34 -07:00
Mike Dvorkin
5d76ded7ed Format ActiveRecord and MongoDocument instances as any other arbitrary objects 2011-05-13 17:36:12 -07:00
Mike Dvorkin
b538cca4c5 Renamed directories 2011-05-13 16:37:24 -07:00
Renamed from spec/mongo_mapper_spec.rb (Browse further)