1
0
Fork 0
mirror of https://github.com/awesome-print/awesome_print synced 2023-03-27 23:22:34 -04:00
Commit graph

25 commits

Author SHA1 Message Date
Gerard Caulfield
4e99526c25
Fix spacing inoconsistencies which conflict with style guide
This is also so that Hound can be introduced without it bugging
people about issues in existing code.

---

If git-blame brought you here you may want to read this, the
problem is with git-blame, not this change.

Try running these two lines just once:
``
git config --global alias.praise 'log -p -M --follow --stat --'
git config --global alias.praise-line 'log -p -M --pretty=format:"%h (%an %ai)" -L'
``

Now in future you can use

`git praise <path/to/your/file>`

or if you want to see the evolution of a specific line or range of lines

`git praise-line <start-line>:<end-line>:<path/to/your/file>`

Some examples you should try:
``
git praise lib/awesome_print/version.rb
git praise-line 8:8:lib/awesome_print/version.rb
``

Inspiration for these aliases:

http://blog.andrewray.me/a-better-git-blame/`
2016-11-09 16:06:33 +11:00
Gerard Caulfield
a7dd25b824
Fix hash syntax inconsistency
Use the ruby 1.9 hash syntax everywhere appropriate. This is to fix style
inconsistencies in the code base. This is also so that Hound can be used
without it bugging people every time they touch an older piece of code
but forget to update the syntax.

If git-blame brought you here you may want to read this, the
problem is with git-blame, not this change.

Try running these two lines just once:
```
git config --global alias.praise 'log -p -M --follow --stat --'
git config --global alias.praise-line 'log -p -M --pretty=format:"%h (%an %ai)"  -L'
```

Now in future you can use

`git praise <path/to/your/file>`

or if you want to see the evolution of a specific line or range of lines

`git praise-line <start-line>:<end-line>:<path/to/your/file>`

Some examples you should try:
```
git praise lib/awesome_print/version.rb
git praise-line 8:8:lib/awesome_print/version.rb
```

Inspiration for these aliases:

http://blog.andrewray.me/a-better-git-blame/
2016-11-09 01:53:17 +11:00
Gerard Caulfield
ce934093b3
Fix string inconsistency
Only using double quoted strings when needing interpolation.

If git-blame brought you here you may want to read this, the
problem is with git-blame, not this change.

Try running these two lines just once:
```
git config --global alias.praise 'log -p -M --follow --stat --'
git config --global alias.praise-line 'log -p -M --pretty=format:"%h (%an %ai)"  -L'
```

Now in future you can use

`git praise <path/to/your/file>`

or if you want to see the evolution of a specific line or range of lines

`git praise-line <start-line>:<end-line>:<path/to/your/file>`

Some examples you should try:
```
git praise lib/awesome_print/version.rb
git praise-line 8:8:lib/awesome_print/version.rb
```

Inspiration for these aliases:

http://blog.andrewray.me/a-better-git-blame/
2016-11-08 17:30:17 +11:00
Gerard Caulfield
f628193028
Ensure stub_dotfile! is called before all specs
The previous stubbing of dotfiles was still allowing calls to fall
through and populate the AwesomePrint.defaults hash which would then
cause some tests to fail if run in a certain order.

e.g. https://github.com/awesome-print/awesome_print/issues/265

One place in particular where this would happen is if you ran the
action_view_spec before other specs as it did not stub the dotfile.

This change makes dotfile stubbing more reliable, specific and
ensures it is run for every spec. I've also removed all instances
where it was being called manually, as this is now not needed due
to it being automatic.
2016-08-27 23:43:32 +10:00
Gerard Caulfield
cf18904915
Make option name more meaningful
I just noticed a code review which suggested against the name
we are currently using and gave some good reasoning:

"Naming things "new" is always a problem (since time passes and
it's no longer new). Maybe colonize_symbol_keys? ("colonize"
sounds kind of gross though...)
https://git.io/vKIiX

The ruby19_syntax name was suggested later in the conversation.

As we have not yet released with the previous option name, it's
now or never for this change.
2016-07-06 19:03:24 +10:00
Mauro George
7ddc36bde6 Add spec for hash syntax option 2016-06-09 00:34:03 -03:00
Waldyr
e4a26d28a5 Add feature to print Structs like Objects 2016-05-12 09:33:11 -03:00
Waldyr
e2371657e7 Fix typo in formats spec 2016-04-14 21:20:49 -03:00
Elliot Shank
f6f3914bae Test Formatter#to_hash. 2015-02-02 17:19:45 -06:00
Mauro George
526f907629 Improves spec runner harness, switches to better env detection.
Does not run rails specs when running mongoid specs

WIP Start of remove BRE to check tests

Remove old helper of active record

Use RSpec skip to skip AR specs

Run ActionView only when needed

Run ActiveSupport only when needed

Run Mongoid only when needed

Create ExtVerifier.require_dependencies

Run MongoMapper only when needed

Always load nokogiri specs

Always load ostruct specs

Run Ripple only when needed

Remove :: when check for defined constants

Require spec_helper directly

Remove 1.8.6 old monkey patch

Add some RSpec configs
2015-01-02 13:20:18 -05:00
Eoin Kelly
52bffc1873 Get specs passing with latest versions of extension gems
* Get specs passing with latest versions of
    * ActiveRecord  4.0.4
    * ActiveSupport 4.0.4
    * MongoMapper   0.13.0
    * Mongoid       4.0.0
    * ActionView    4.0.4
    * Ripple seems to be abandoned so no changes made.
* Clean up ActiveRecord setup:
    * Creating tableless AR objects seems even trickier in Rails 4 so
      simplify testing setup by using an in-memory SQLite DB back-end.

Conflicts:
	spec/ext/active_record_spec.rb
2014-12-29 12:11:08 -05:00
adamjonas
2bc678bba5 update rspec syntax from should to expect via transpec 2014-12-18 12:24:30 -05:00
Mike Dvorkin
fb070acab0 Fixed set formatting spec for Ruby 1.8.x 2013-09-24 12:18:44 -07:00
Michael Dvorkin
7ccf4907ae Added formatting for Ruby set objects (patch by Richard Hall) 2013-09-19 17:00:28 -07:00
Mike Dvorkin
bef11700b5 Make sure Rational specs pass with Ruby 1.8.x 2012-09-03 21:22:05 -07:00
Mike Dvorkin
c7bdcd85e6 Merge branch 'master' of git://github.com/evansenter/awesome_print into evansenter/master 2012-09-03 21:02:12 -07:00
Mike Dvorkin
fa958455ca Moved misc specs to spec/misc_specs.rb 2012-09-03 13:57:10 -07:00
Mike Dvorkin
8a222fb709 Fixed ArgumentError: Can't create Binding from C level Proc 2012-09-03 13:06:16 -07:00
Mike Dvorkin
fcdc3b6320 Tiny spec fix for Ruby 1.8.x 2012-09-03 11:57:16 -07:00
Evan Senter
bd032ca03b Patching awesome_bigdecimal to not have lossy precision. 2012-06-26 12:05:26 -04:00
Mike Dvorkin
b6a02f200b Make specs pass with Ruby 1.8.6 2011-11-23 22:37:25 -08:00
Mike Dvorkin
3849b4a7bd Changed HTML formatting to support pre { display:inline } style 2011-11-23 21:10:56 -08:00
Mike Dvorkin
d2c0a398e2 Fixed nested left alighment; fixed ActiveRecord and MongoMapper object specs 2011-11-08 21:27:02 -08:00
Mike Dvorkin
782e38268b Fixed double indentation for left-aligned hash keys 2011-11-08 18:30:50 -08:00
Mike Dvorkin
8044c29b50 Ported AwesomePrint.force_colors! and its specs 2011-11-08 18:30:50 -08:00
Renamed from spec/awesome_print_spec.rb (Browse further)