1
0
Fork 0
mirror of https://github.com/capistrano/capistrano synced 2023-03-27 23:21:18 -04:00

Merge pull request #1780 from mattbrictson/rubocop-43

Fix guard-clause warnings reported by RuboCop 0.43
This commit is contained in:
Matt Brictson 2016-09-19 16:09:52 -07:00 committed by GitHub
commit 3d4b17c2fb
3 changed files with 8 additions and 14 deletions

View file

@ -25,12 +25,10 @@ module VagrantHelpers
end end
def run_vagrant_command(command) def run_vagrant_command(command)
if (status = vagrant_cli_command("ssh -c #{command.inspect}")).success? status = vagrant_cli_command("ssh -c #{command.inspect}")
true return true if status.success?
else
raise VagrantSSHCommandError, status raise VagrantSSHCommandError, status
end end
end
end end
World(VagrantHelpers) World(VagrantHelpers)

View file

@ -91,11 +91,10 @@ module Capistrano
end end
def assert_value_or_block_not_both(value, block) def assert_value_or_block_not_both(value, block)
unless value.nil? || block.nil? return if value.nil? || block.nil?
raise Capistrano::ValidationError, raise Capistrano::ValidationError,
"Value and block both passed to Configuration#set" "Value and block both passed to Configuration#set"
end end
end
class ValidatedQuestion < Question class ValidatedQuestion < Question
def initialize(validator) def initialize(validator)

View file

@ -5,12 +5,9 @@ module Capistrano
end end
def verify def verify
if match? return self if match?
self
else
raise "Capfile locked at #{version}, but #{current_version} is loaded" raise "Capfile locked at #{version}, but #{current_version} is loaded"
end end
end
private private