Merge pull request #1604 from will-in-wi/rubocop_signal_exception

Enable SignalException cop

.rubocop.yml

@@ -23,8 +23,6 @@ Style/Documentation:
   Enabled: false
 Style/RegexpLiteral:
   Enabled: false
-Style/SignalException:
-  Enabled: false
 Style/PercentLiteralDelimiters:
   Enabled: false
 Style/BlockDelimiters:

features/support/vagrant_helpers.rb

@@ -28,7 +28,7 @@ module VagrantHelpers
     if (status = vagrant_cli_command("ssh -c #{command.inspect}")).success?
       true
     else
-      fail VagrantSSHCommandError, status
+      raise VagrantSSHCommandError, status
     end
   end
 end

lib/capistrano/version_validator.rb

@@ -8,7 +8,7 @@ module Capistrano
       if match?
         self
       else
-        fail "Capfile locked at #{version}, but #{current_version} is loaded"
+        raise "Capfile locked at #{version}, but #{current_version} is loaded"
       end
     end
 

spec/lib/capistrano/configuration_spec.rb

@@ -136,7 +136,7 @@ module Capistrano
       end
 
       context "block is passed to fetch" do
-        subject { config.fetch(:key, :default) { fail "we need this!" } }
+        subject { config.fetch(:key, :default) { raise "we need this!" } }
 
         it "returns the block value" do
           expect { subject }.to raise_error(RuntimeError)

spec/support/tasks/fail.rake

@@ -1,4 +1,4 @@
-set :fail, proc { fail }
+set :fail, proc { raise }
 before "deploy:starting", :fail do
   on roles :all do
     execute :mkdir, "-p", shared_path