* deploy:cleanup should skip only the invalid releases and continue the rotation
of releases
* Add cucumber tests for deploy:cleanup
* PR feedback
* rebase on master
* add ruby 2.4.1 to specs
* vagrant works with bundler 1.15.3
* remove unnecessary command
"Danger" is a gem that automatically runs certain sanity checks against
GitHub pull requests. Whenever a Capistrano PR is opened, Danger will
check whether a CHANGELOG entry was included, and whether tests were
included, and add a comment to the PR if there are violations.
For some reason Rubinius seg faults sometimes when running RuboCop on
Travis. Rather than have periodically failing builds, just disable it.
We still get adequate coverage because RuboCop results shouldn't be
different for rbx anyway.
This removes the dependency on the `kuroko` gem and uses the Vagrant
command line application to control the virtual environment. The
`vagrant` command should be in your path, but if it isn't the path can
be set with the `VAGRANT_BIN` environment variable. This may even work
on older versions of Vagrant, but they are untested.
The `VagrantHelpers` module was added to mimic some of the API that was
provided by `kuroko`. The `RemoteCommandHelpers` module was modified to
accommodate those changes. Any non-zero exit status on a remote command
will raise a `VagrantHelpers::VagrantSSHCommandError` and should be
expected by any tests using the command helpers. All existing tests
work as expected.
In addition, a couple of minor changes were made. The TestApp utilizes
the Pathname library but does not require it. This was causing the suite
to fail for me so I added an explicit require. Also, the test for the
existence of a release directory would give a false positive on
subsequent runs if the `KEEP_RUNNING` option was used. I added an
`at_exit` that removes the test deployment directory to clean up the
box for the next run.
Documentation was also added to the README for how to run the test
suites.
