adds syntax sugar for reading cookie values (fix #179)
This commit is contained in:
parent
d3f344af44
commit
341306f72a
|
@ -2,6 +2,7 @@ require "capybara"
|
||||||
require "capybara/driver/webkit/node"
|
require "capybara/driver/webkit/node"
|
||||||
require "capybara/driver/webkit/browser"
|
require "capybara/driver/webkit/browser"
|
||||||
require "capybara/driver/webkit/socket_debugger"
|
require "capybara/driver/webkit/socket_debugger"
|
||||||
|
require "capybara/driver/webkit/cookie_jar"
|
||||||
|
|
||||||
class Capybara::Driver::Webkit
|
class Capybara::Driver::Webkit
|
||||||
class WebkitInvalidResponseError < StandardError
|
class WebkitInvalidResponseError < StandardError
|
||||||
|
@ -103,6 +104,12 @@ class Capybara::Driver::Webkit
|
||||||
@rack_server.port
|
@rack_server.port
|
||||||
end
|
end
|
||||||
|
|
||||||
|
def cookies
|
||||||
|
@cookie_jar ||= begin
|
||||||
|
CookieJar.new(browser)
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
private
|
private
|
||||||
|
|
||||||
def url(path)
|
def url(path)
|
||||||
|
|
|
@ -0,0 +1,55 @@
|
||||||
|
require 'webrick'
|
||||||
|
|
||||||
|
# A simple cookie jar implementation.
|
||||||
|
# Does not take special cookie attributes
|
||||||
|
# into account like expire, max-age, httponly, secure
|
||||||
|
class Capybara::Driver::Webkit::CookieJar
|
||||||
|
attr_reader :browser
|
||||||
|
|
||||||
|
def initialize(browser)
|
||||||
|
@browser = browser
|
||||||
|
end
|
||||||
|
|
||||||
|
def [](*args)
|
||||||
|
cookie = find(*args)
|
||||||
|
cookie && cookie.value
|
||||||
|
end
|
||||||
|
|
||||||
|
def find(name, domain = nil, path = "/")
|
||||||
|
# we are sorting by path size because more specific paths take
|
||||||
|
# precendence
|
||||||
|
cookies.sort_by { |c| -c.path.size }.find { |c|
|
||||||
|
c.name.downcase == name.downcase &&
|
||||||
|
(!domain || valid_domain?(c, domain)) &&
|
||||||
|
(!path || valid_path?(c, path))
|
||||||
|
}
|
||||||
|
end
|
||||||
|
|
||||||
|
protected
|
||||||
|
|
||||||
|
def valid_domain?(cookie, domain)
|
||||||
|
ends_with?(("." + domain).downcase,
|
||||||
|
normalize_domain(cookie.domain).downcase)
|
||||||
|
end
|
||||||
|
|
||||||
|
def normalize_domain(domain)
|
||||||
|
domain = "." + domain unless domain[0,1] == "."
|
||||||
|
domain
|
||||||
|
end
|
||||||
|
|
||||||
|
def valid_path?(cookie, path)
|
||||||
|
starts_with?(path, cookie.path)
|
||||||
|
end
|
||||||
|
|
||||||
|
def ends_with?(str, suffix)
|
||||||
|
str[-suffix.size..-1] == suffix
|
||||||
|
end
|
||||||
|
|
||||||
|
def starts_with?(str, prefix)
|
||||||
|
str[0, prefix.size] == prefix
|
||||||
|
end
|
||||||
|
|
||||||
|
def cookies
|
||||||
|
browser.get_cookies.map { |c| WEBrick::Cookie.parse_set_cookie(c) }
|
||||||
|
end
|
||||||
|
end
|
|
@ -0,0 +1,34 @@
|
||||||
|
require 'spec_helper'
|
||||||
|
require 'capybara/driver/webkit/cookie_jar'
|
||||||
|
|
||||||
|
describe Capybara::Driver::Webkit::CookieJar do
|
||||||
|
let(:browser) {
|
||||||
|
browser = double("Browser")
|
||||||
|
browser.stub(:get_cookies) { [
|
||||||
|
"cookie1=1; domain=.example.org; path=/",
|
||||||
|
"cookie1=2; domain=.example.org; path=/dir1/",
|
||||||
|
"cookie1=3; domain=.facebook.com; path=/",
|
||||||
|
"cookie2=4; domain=.sub1.example.org; path=/",
|
||||||
|
] }
|
||||||
|
browser
|
||||||
|
}
|
||||||
|
|
||||||
|
subject { Capybara::Driver::Webkit::CookieJar.new(browser) }
|
||||||
|
|
||||||
|
describe "#[]" do
|
||||||
|
it "should return the right cookie value for every given domain/path" do
|
||||||
|
subject["cookie1", "example.org"].should == "1"
|
||||||
|
subject["cookie1", "www.facebook.com"].should == "3"
|
||||||
|
subject["cookie2", "sub1.example.org"].should == "4"
|
||||||
|
end
|
||||||
|
|
||||||
|
it "should not return cookie from other domain" do
|
||||||
|
subject["cookie2", "www.example.org"].should == nil
|
||||||
|
end
|
||||||
|
|
||||||
|
it "should handle path precedence correctly" do
|
||||||
|
subject["cookie1", "www.example.org"].should == "1"
|
||||||
|
subject["cookie1", "www.example.org", "/dir1/123"].should == "2"
|
||||||
|
end
|
||||||
|
end
|
||||||
|
end
|
|
@ -943,6 +943,10 @@ describe Capybara::Driver::Webkit do
|
||||||
cookie["domain"].should include "127.0.0.1"
|
cookie["domain"].should include "127.0.0.1"
|
||||||
cookie["path"].should == "/"
|
cookie["path"].should == "/"
|
||||||
end
|
end
|
||||||
|
|
||||||
|
it "allows reading access to cookies using a nice syntax" do
|
||||||
|
subject.cookies["cookie"].should == "abc"
|
||||||
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
context "with socket debugger" do
|
context "with socket debugger" do
|
||||||
|
|
Loading…
Reference in New Issue