Rename logger() => log() and prepend info with current time

This commit is contained in:
Washington Luiz 2016-06-04 23:08:21 -03:00 committed by Thomas Walpole
parent d53cf7c214
commit 6675770509
6 changed files with 18 additions and 18 deletions

View File

@ -24,7 +24,7 @@ Connection::Connection(QTcpSocket *socket, WebPageManager *manager, QObject *par
} }
void Connection::commandReady(Command *command) { void Connection::commandReady(Command *command) {
m_manager->logger() << "Received" << command->toString(); m_manager->log() << "Received" << command->toString();
startCommand(command); startCommand(command);
} }
@ -65,7 +65,7 @@ void Connection::writeResponse(Response *response) {
else else
m_socket->write("failure\n"); m_socket->write("failure\n");
m_manager->logger() << "Wrote response" << response->isSuccess() << response->message(); m_manager->log() << "Wrote response" << response->isSuccess() << response->message();
QByteArray messageUtf8 = response->message(); QByteArray messageUtf8 = response->message();
QString messageLength = QString::number(messageUtf8.size()) + "\n"; QString messageLength = QString::number(messageUtf8.size()) + "\n";

View File

@ -14,7 +14,7 @@ PageLoadingCommand::PageLoadingCommand(Command *command, WebPageManager *manager
} }
void PageLoadingCommand::start() { void PageLoadingCommand::start() {
m_manager->logger() << "Started" << m_command->toString(); m_manager->log() << "Started" << m_command->toString();
connect(m_command, SIGNAL(finished(Response *)), this, SLOT(commandFinished(Response *))); connect(m_command, SIGNAL(finished(Response *)), this, SLOT(commandFinished(Response *)));
connect(m_manager, SIGNAL(loadStarted()), this, SLOT(pageLoadingFromCommand())); connect(m_manager, SIGNAL(loadStarted()), this, SLOT(pageLoadingFromCommand()));
connect(m_manager, SIGNAL(pageFinished(bool)), this, SLOT(pendingLoadFinished(bool))); connect(m_manager, SIGNAL(pageFinished(bool)), this, SLOT(pendingLoadFinished(bool)));
@ -26,7 +26,7 @@ void PageLoadingCommand::pendingLoadFinished(bool success) {
if (m_pageLoadingFromCommand) { if (m_pageLoadingFromCommand) {
m_pageLoadingFromCommand = false; m_pageLoadingFromCommand = false;
if (m_pendingResponse) { if (m_pendingResponse) {
m_manager->logger() << "Page load from command finished"; m_manager->log() << "Page load from command finished";
if (m_pageSuccess) { if (m_pageSuccess) {
emit finished(m_pendingResponse); emit finished(m_pendingResponse);
} else { } else {
@ -38,13 +38,13 @@ void PageLoadingCommand::pendingLoadFinished(bool success) {
} }
void PageLoadingCommand::pageLoadingFromCommand() { void PageLoadingCommand::pageLoadingFromCommand() {
m_manager->logger() << m_command->toString() << "started page load"; m_manager->log() << m_command->toString() << "started page load";
m_pageLoadingFromCommand = true; m_pageLoadingFromCommand = true;
} }
void PageLoadingCommand::commandFinished(Response *response) { void PageLoadingCommand::commandFinished(Response *response) {
disconnect(m_manager, SIGNAL(loadStarted()), this, SLOT(pageLoadingFromCommand())); disconnect(m_manager, SIGNAL(loadStarted()), this, SLOT(pageLoadingFromCommand()));
m_manager->logger() << "Finished" << m_command->toString() << "with response" << response->toString(); m_manager->log() << "Finished" << m_command->toString() << "with response" << response->toString();
if (m_pageLoadingFromCommand) if (m_pageLoadingFromCommand)
m_pendingResponse = response; m_pendingResponse = response;

View File

@ -19,7 +19,7 @@ TimeoutCommand::TimeoutCommand(Command *command, WebPageManager *manager, QObjec
void TimeoutCommand::start() { void TimeoutCommand::start() {
QApplication::processEvents(); QApplication::processEvents();
if (m_manager->isLoading()) { if (m_manager->isLoading()) {
m_manager->logger() << this->toString() << "waiting for load to finish"; m_manager->log() << this->toString() << "waiting for load to finish";
connect(m_manager, SIGNAL(pageFinished(bool)), this, SLOT(pendingLoadFinished(bool))); connect(m_manager, SIGNAL(pageFinished(bool)), this, SLOT(pendingLoadFinished(bool)));
startTimeout(); startTimeout();
} else { } else {

View File

@ -177,7 +177,7 @@ void WebPage::javaScriptConsoleMessage(const QString &message, int lineNumber, c
m["line_number"] = lineNumber; m["line_number"] = lineNumber;
} }
m_consoleMessages.append(m); m_consoleMessages.append(m);
m_manager->logger() << qPrintable(fullMessage); m_manager->log() << qPrintable(fullMessage);
} }
void WebPage::javaScriptAlert(QWebFrame *frame, const QString &message) { void WebPage::javaScriptAlert(QWebFrame *frame, const QString &message) {
@ -194,7 +194,7 @@ void WebPage::javaScriptAlert(QWebFrame *frame, const QString &message) {
addModalMessage(expectedType, message, expectedMessage); addModalMessage(expectedType, message, expectedMessage);
} }
m_manager->logger() << "ALERT:" << qPrintable(message); m_manager->log() << "ALERT:" << qPrintable(message);
} }
bool WebPage::javaScriptConfirm(QWebFrame *frame, const QString &message) { bool WebPage::javaScriptConfirm(QWebFrame *frame, const QString &message) {

View File

@ -81,14 +81,14 @@ void WebPageManager::removePage(WebPage *page) {
void WebPageManager::emitLoadStarted() { void WebPageManager::emitLoadStarted() {
if (m_started.empty()) { if (m_started.empty()) {
logger() << "Load started"; log() << "Load started";
emit loadStarted(); emit loadStarted();
} }
m_started += qobject_cast<WebPage *>(sender()); m_started += qobject_cast<WebPage *>(sender());
} }
void WebPageManager::requestCreated(QByteArray &url, QNetworkReply *reply) { void WebPageManager::requestCreated(QByteArray &url, QNetworkReply *reply) {
logger() << "Started request to" << url; log() << "Started request to" << url;
if (reply->isFinished()) if (reply->isFinished())
replyFinished(reply); replyFinished(reply);
else { else {
@ -110,7 +110,7 @@ void WebPageManager::handleReplyFinished() {
void WebPageManager::replyFinished(QNetworkReply *reply) { void WebPageManager::replyFinished(QNetworkReply *reply) {
int status = reply->attribute(QNetworkRequest::HttpStatusCodeAttribute).toInt(); int status = reply->attribute(QNetworkRequest::HttpStatusCodeAttribute).toInt();
logger() << "Received" << status << "from" << reply->url().toString(); log() << "Received" << status << "from" << reply->url().toString();
m_pendingReplies.removeAll(reply); m_pendingReplies.removeAll(reply);
} }
@ -119,7 +119,7 @@ void WebPageManager::replyDestroyed(QObject *reply) {
} }
void WebPageManager::setPageStatus(bool success) { void WebPageManager::setPageStatus(bool success) {
logger() << "Page finished with" << success; log() << "Page finished with" << success;
m_started.remove(qobject_cast<WebPage *>(sender())); m_started.remove(qobject_cast<WebPage *>(sender()));
m_success = success && m_success; m_success = success && m_success;
if (m_started.empty()) { if (m_started.empty()) {
@ -128,7 +128,7 @@ void WebPageManager::setPageStatus(bool success) {
} }
void WebPageManager::emitPageFinished() { void WebPageManager::emitPageFinished() {
logger() << "Load finished"; log() << "Load finished";
emit pageFinished(m_success); emit pageFinished(m_success);
m_success = true; m_success = true;
} }
@ -151,7 +151,7 @@ void WebPageManager::setTimeout(int timeout) {
void WebPageManager::reset() { void WebPageManager::reset() {
foreach(QNetworkReply *reply, m_pendingReplies) { foreach(QNetworkReply *reply, m_pendingReplies) {
logger() << "Aborting request to" << reply->url().toString(); log() << "Aborting request to" << reply->url().toString();
reply->abort(); reply->abort();
} }
m_pendingReplies.clear(); m_pendingReplies.clear();
@ -191,9 +191,9 @@ bool WebPageManager::isLoading() const {
return false; return false;
} }
QDebug WebPageManager::logger() const { QDebug WebPageManager::log() const {
if (m_loggingEnabled) { if (m_loggingEnabled) {
return qCritical(); return qCritical() << QTime::currentTime().toString("hh:mm:ss.zzz");
} else { } else {
return QDebug(m_ignoredOutput); return QDebug(m_ignoredOutput);
} }

View File

@ -33,7 +33,7 @@ class WebPageManager : public QObject {
void reset(); void reset();
NetworkCookieJar *cookieJar(); NetworkCookieJar *cookieJar();
bool isLoading() const; bool isLoading() const;
QDebug logger() const; QDebug log() const;
void enableLogging(); void enableLogging();
void replyFinished(QNetworkReply *reply); void replyFinished(QNetworkReply *reply);
NetworkAccessManager *networkAccessManager(); NetworkAccessManager *networkAccessManager();