kotovalexarian-likes-github/capybara-webkit
1
0
Fork 0
mirror of https://github.com/thoughtbot/capybara-webkit synced 2023-03-27 23:22:28 -04:00
Code Releases Activity

Trigger correct input events for checkbox/radio elements

Browse source
This commit is contained in:
Joe Ferris 2011-03-11 11:25:06 -05:00
parent 54d121f1a2
commit 6c247a0669
3 changed files with 126 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
lib/capybara/driver/webkit/node.rb
View file

@ -5,7 +5,12 @@ class Capybara::Driver::Webkit
end end
def [](name) def [](name)
invoke "attribute", name value = invoke("attribute", name)
if name == 'checked'
value == 'true'
else
value
end
end end
def value def value

120
spec/driver_spec.rb
View file

@ -148,6 +148,8 @@ describe Capybara::Driver::Webkit do
<html><body> <html><body>
<form action="/" method="GET"> <form action="/" method="GET">
<input type="text" name="foo" value="bar"/> <input type="text" name="foo" value="bar"/>
<input type="checkbox" name="checkedbox" value="1" checked="checked"/>
<input type="checkbox" name="uncheckedbox" value="2"/>
<select name="animal"> <select name="animal">
<option id="select-option-monkey">Monkey</option> <option id="select-option-monkey">Monkey</option>
<option id="select-option-capybara" selected="selected">Capybara</option> <option id="select-option-capybara" selected="selected">Capybara</option>
@ -162,22 +164,8 @@ describe Capybara::Driver::Webkit do
</optgroup> </optgroup>
</select> </select>
<textarea id="only-textarea">what a wonderful area for text</textarea> <textarea id="only-textarea">what a wonderful area for text</textarea>
<input type="radio" id="only-radio" value="1"/>
</form> </form>
<ul id="events"></ul>
<script type="text/javascript">
var events = document.getElementById("events");
var textarea = document.getElementById("only-textarea");
var recordEvent = function (event) {
var element = document.createElement("li");
element.innerHTML = event.type;
events.appendChild(element);
};
textarea.addEventListener("focus", recordEvent);
textarea.addEventListener("keydown", recordEvent);
textarea.addEventListener("keyup", recordEvent);
textarea.addEventListener("change", recordEvent);
textarea.addEventListener("blur", recordEvent);
</script>
</body></html> </body></html>
HTML HTML
[200, [200,
@ -204,11 +192,6 @@ describe Capybara::Driver::Webkit do
input.value.should == "newvalue" input.value.should == "newvalue"
end end
it "triggers input events" do
subject.find("//textarea").first.set("newvalue")
subject.find("//li").map(&:text).should == %w(focus keydown keyup change blur)
end
it "sets a select's value" do it "sets a select's value" do
select = subject.find("//select").first select = subject.find("//select").first
select.set("Monkey") select.set("Monkey")
@ -255,6 +238,103 @@ describe Capybara::Driver::Webkit do
toppings_select.value.should include("Apple", "Banana", "Cherry") toppings_select.value.should include("Apple", "Banana", "Cherry")
end end
let(:checked_box) { subject.find("//input[@name='checkedbox']").first }
let(:unchecked_box) { subject.find("//input[@name='uncheckedbox']").first }
it "knows a checked box is checked" do
checked_box['checked'].should be_true
end
it "knows an unchecked box is unchecked" do
unchecked_box['checked'].should_not be_true
end
it "checks an unchecked box" do
unchecked_box.set(true)
unchecked_box['checked'].should be_true
end
it "unchecks a checked box" do
checked_box.set(false)
checked_box['checked'].should_not be_true
end
it "leaves a checked box checked" do
checked_box.set(true)
checked_box['checked'].should be_true
end
it "leaves an unchecked box unchecked" do
unchecked_box.set(false)
unchecked_box['checked'].should_not be_true
end
end
context "form events app" do
before(:all) do
@app = lambda do |env|
body = <<-HTML
<html><body>
<form action="/" method="GET">
<input class="watch" type="text"/>
<input class="watch" type="password"/>
<textarea class="watch"></textarea>
<input class="watch" type="checkbox"/>
<input class="watch" type="radio"/>
</form>
<ul id="events"></ul>
<script type="text/javascript">
var events = document.getElementById("events");
var recordEvent = function (event) {
var element = document.createElement("li");
element.innerHTML = event.type;
events.appendChild(element);
};
var elements = document.getElementsByClassName("watch");
for (var i = 0; i < elements.length; i++) {
var element = elements[i];
element.addEventListener("focus", recordEvent);
element.addEventListener("keydown", recordEvent);
element.addEventListener("keyup", recordEvent);
element.addEventListener("change", recordEvent);
element.addEventListener("blur", recordEvent);
element.addEventListener("click", recordEvent);
}
</script>
</body></html>
HTML
[200,
{ 'Content-Type' => 'text/html', 'Content-Length' => body.length.to_s },
[body]]
end
end
it "triggers text input events" do
subject.find("//input[@type='text']").first.set("newvalue")
subject.find("//li").map(&:text).should == %w(focus keydown keyup change blur)
end
it "triggers textarea input events" do
subject.find("//textarea").first.set("newvalue")
subject.find("//li").map(&:text).should == %w(focus keydown keyup change blur)
end
it "triggers password input events" do
subject.find("//input[@type='password']").first.set("newvalue")
subject.find("//li").map(&:text).should == %w(focus keydown keyup change blur)
end
it "triggers radio input events" do
subject.find("//input[@type='radio']").first.set(true)
subject.find("//li").map(&:text).should == %w(click)
end
it "triggers checkbox events" do
subject.find("//input[@type='checkbox']").first.set(true)
subject.find("//li").map(&:text).should == %w(click)
end
end end
context "mouse app" do context "mouse app" do

27
src/capybara.js
View file

@ -31,7 +31,11 @@ Capybara = {
}, },
attribute: function (index, name) { attribute: function (index, name) {
return this.nodes[index].getAttribute(name); if (name == "checked") {
return this.nodes[index].checked;
} else {
return this.nodes[index].getAttribute(name);
}
}, },
tagName: function(index) { tagName: function(index) {
@ -65,12 +69,21 @@ Capybara = {
}, },
set: function(index, value) { set: function(index, value) {
this.trigger(index, "focus"); var node = this.nodes[index];
this.nodes[index].value = value; var type = (node.type || node.tagName).toLowerCase();
this.trigger(index, "keydown"); if (type == "text" || type == "textarea" || type == "password") {
this.trigger(index, "keyup"); this.trigger(index, "focus");
this.trigger(index, "change"); node.value = value;
this.trigger(index, "blur"); this.trigger(index, "keydown");
this.trigger(index, "keyup");
this.trigger(index, "change");
this.trigger(index, "blur");
} else if(type == "checkbox" || type == "radio") {
node.checked = (value == "true");
this.trigger(index, "click");
} else {
node.value = value;
}
}, },
selectOption: function(index) { selectOption: function(index) {