From 99f4a88f2fa87315f67a7ff5de8d30fabca2f9cc Mon Sep 17 00:00:00 2001 From: Matthew Horan Date: Wed, 9 Jul 2014 21:32:35 -0400 Subject: [PATCH] Add deprecation warnings to legacy window methods * Capybara 2.3 provides a new window API. --- lib/capybara/webkit/browser.rb | 12 ++++++++++-- lib/capybara/webkit/driver.rb | 2 ++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/lib/capybara/webkit/browser.rb b/lib/capybara/webkit/browser.rb index 74e7364..e9f7c32 100644 --- a/lib/capybara/webkit/browser.rb +++ b/lib/capybara/webkit/browser.rb @@ -126,13 +126,21 @@ module Capybara::Webkit JSON.parse(command('GetWindowHandles')) end - alias_method :window_handles, :get_window_handles + def window_handles + warn '[DEPRECATION] Capybara::Webkit::Browser#window_handles ' \ + 'is deprecated. Please use Capybara::Session#windows instead.' + get_window_handles + end def get_window_handle command('GetWindowHandle') end - alias_method :window_handle, :get_window_handle + def window_handle + warn '[DEPRECATION] Capybara::Webkit::Browser#window_handle ' \ + 'is deprecated. Please use Capybara::Session#current_window instead.' + get_window_handle + end def accept_confirm(options) command("SetConfirmAction", "Yes", options[:text]) diff --git a/lib/capybara/webkit/driver.rb b/lib/capybara/webkit/driver.rb index e91873f..793ecaf 100644 --- a/lib/capybara/webkit/driver.rb +++ b/lib/capybara/webkit/driver.rb @@ -97,6 +97,8 @@ module Capybara::Webkit end def resize_window(width, height) + warn '[DEPRECATION] Capybara::Webkit::Driver#resize_window ' \ + 'is deprecated. Please use Capybara::Window#resize_to instead.' resize_window_to(current_window_handle, width, height) end