kotovalexarian-likes-github/capybara-webkit
1
0
Fork 0
mirror of https://github.com/thoughtbot/capybara-webkit synced 2023-03-27 23:22:28 -04:00
Code Releases Activity

Rather than creating a new NetworkAccessManager when the page is reset,

Browse source 
reuse the existing manager and just clear its headers and cookies.

This avoids repeatedly setting up the SIGNAL/SLOT callback stuff which
is leading to unclosed pipes on Ubuntu, eventually causing "too many
open files" errors in large test suites.
This commit is contained in:
Patrick Bacon 2012-03-22 10:14:30 -04:00 committed by Joe Ferris
parent c2a2bd0376
commit f190f51652
3 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/NetworkAccessManager.cpp
View file

@ -23,3 +23,7 @@ void NetworkAccessManager::addHeader(QString key, QString value) {
m_headers.insert(key, value);
};
void NetworkAccessManager::resetHeaders() {
m_headers.clear();
};

3
src/NetworkAccessManager.h
View file

@ -9,10 +9,11 @@ class NetworkAccessManager : public QNetworkAccessManager {
public:
NetworkAccessManager(QObject *parent = 0);
void addHeader(QString key, QString value);
void resetHeaders();
protected:
QNetworkReply* createRequest(QNetworkAccessManager::Operation op, const QNetworkRequest &req, QIODevice * outgoingData);
private:
QHash<QString, QString> m_headers;
};
};

7
src/Reset.cpp
View file

@ -8,8 +8,11 @@ Reset::Reset(WebPage *page, QStringList &arguments, QObject *parent) : Command(p
void Reset::start() {
page()->triggerAction(QWebPage::Stop);
page()->networkAccessManager()->setCookieJar(new NetworkCookieJar());
page()->setCustomNetworkAccessManager();
NetworkAccessManager* networkAccessManager = qobject_cast<NetworkAccessManager*>(page()->networkAccessManager());
networkAccessManager->setCookieJar(new NetworkCookieJar());
networkAccessManager->resetHeaders();
page()->setUserAgent(NULL);
page()->resetResponseHeaders();
page()->resetConsoleMessages();