Commit Graph

12 Commits

Author SHA1 Message Date
Thomas Walpole 43ebe80704 Support Capybara 2.11
* Update versions being tested against
* Implement missing APIs from newer versions
2017-01-13 09:12:31 -05:00
Matthew Horan c74949bd04 Rename Command::emitFinished to finish 2013-02-11 18:31:41 -05:00
Matthew Horan 6c72a99174 Serialize errors as JSON 2013-02-11 00:04:35 -05:00
Sean Geoghegan 77811ca9ba Fix memory leak of response.
Turns Response into a QObject and sets parent to the
command that emits it.

Each Command is also a child of the decorator commands,
Timeout and PageLoading commnds, so that deleting the
top level command will delete all the children.

See discussion in #430.
2012-12-14 01:46:54 -05:00
Joe Ferris 95732ad796 Split Command into more abstract Command and concrete SocketCommand 2012-07-08 12:04:30 -07:00
Matthew Horan f80125e6cb Pass the WebPageManager to each command 2012-05-29 22:23:02 -04:00
Dan Ivovich 1ef8f4c844 Store response messages as QByteArray
This prevents conversion of QByteArray to QString from truncating content at a null byte in the QByteArray. This truncation can be a problem if the response body is a binary object (e.g. PDF)

Fixes #322
2012-04-17 12:06:12 -04:00
Joe Ferris 85dcc729dd Pass command arguments to the constructor 2012-03-16 19:58:58 -04:00
Joe Ferris cc74875e4b Created a Response object for the success/message pair 2011-05-05 17:55:40 -04:00
Joe Ferris 3615624ec4 Refactored FrameFocus 2011-04-20 19:02:20 -04:00
Aaron Gibralter c563ed54cb `within_frame` now works. Takes either an index or a frame name/id. 2011-04-20 18:12:03 -04:00
Aaron Gibralter 182cb2e5b7 Working on frame handling. In terms of the QT code, the non-frame-related
specs pass with these changes (e.g. mainFrame() => currentFrame() and the new
injectJavascriptHelpers() code in WebPage.cpp).

It seems like the current JS+xpath implementation dives in to iframes already.
Is this desired behavior? I wonder if that works with x-domain iframes? I
doubt it...

Also, this design assumes that we only step one frame down at a time...

Lastly, I'm really not sure how QWebKit decides which frame is currentFrame().
For now, I'm hoping to be able to use the QWebFrame setFocus() method. This
may be a dead end though. We may have to have WebPage manually keep track of
the "current" frame.
2011-04-20 18:12:03 -04:00