Commit Graph

17 Commits

Author SHA1 Message Date
Kirill Nikitin 525a8bb130 Attempt to visit URLs with invalid characters
* Fixes issues with URLs which include square brackets
2013-11-10 17:06:03 -05:00
Matthew Horan c74949bd04 Rename Command::emitFinished to finish 2013-02-11 18:31:41 -05:00
Sean Geoghegan 77811ca9ba Fix memory leak of response.
Turns Response into a QObject and sets parent to the
command that emits it.

Each Command is also a child of the decorator commands,
Timeout and PageLoading commnds, so that deleting the
top level command will delete all the children.

See discussion in #430.
2012-12-14 01:46:54 -05:00
Joe Ferris 95732ad796 Split Command into more abstract Command and concrete SocketCommand 2012-07-08 12:04:30 -07:00
Matthew Horan f80125e6cb Pass the WebPageManager to each command 2012-05-29 22:23:02 -04:00
Joe Ferris 85dcc729dd Pass command arguments to the constructor 2012-03-16 19:58:58 -04:00
Joe Ferris 5b57eee8c5 Simplify Visit 2012-03-16 18:53:43 -04:00
Pete Gieser fccb444816 visit no longer tries to fix invalid URLs 2012-01-13 09:57:36 -05:00
Brian Buchanan e746feab5d Fix issue #39 2011-10-01 11:46:50 -05:00
Matthew Mongeau f75bc3dbad Anchors don't agree with setUrl. Using load instead. Fixes #92 2011-09-30 12:32:06 -04:00
Matthew Mongeau 353fe860b2 Handle unsupported content types gracefully 2011-09-23 10:28:50 -04:00
Chad Pytel 66a6145ee9 fix for https://github.com/thoughtbot/capybara-webkit/issues/52 2011-06-02 15:45:28 -04:00
Joe Ferris cc74875e4b Created a Response object for the success/message pair 2011-05-05 17:55:40 -04:00
Aaron Gibralter 182cb2e5b7 Working on frame handling. In terms of the QT code, the non-frame-related
specs pass with these changes (e.g. mainFrame() => currentFrame() and the new
injectJavascriptHelpers() code in WebPage.cpp).

It seems like the current JS+xpath implementation dives in to iframes already.
Is this desired behavior? I wonder if that works with x-domain iframes? I
doubt it...

Also, this design assumes that we only step one frame down at a time...

Lastly, I'm really not sure how QWebKit decides which frame is currentFrame().
For now, I'm hoping to be able to use the QWebFrame setFocus() method. This
may be a dead end though. We may have to have WebPage manually keep track of
the "current" frame.
2011-04-20 18:12:03 -04:00
Joe Ferris a8e64a5f10 Don't create a command until all arguments are received; don't start the next command if a page is still loading 2011-03-09 00:08:30 -05:00
Joe Ferris 3e32892e2b Refactor Connection/Command so that arguments are passed in as a single QStringList instead of in consecutive calls to argumentReceived 2011-02-25 23:29:36 -05:00
Joe Ferris 0745b1ee1c Initial commit 2011-02-24 23:13:11 -05:00