1
0
Fork 0
mirror of https://github.com/thoughtbot/capybara-webkit synced 2023-03-27 23:22:28 -04:00
Commit graph

10 commits

Author SHA1 Message Date
Joe Ferris
82d0d6fcc9 Extract handle classes from NetworkAccessManager
NetworkAccessManager was getting pretty complex, and adding something
that modifies or intercepts requests is becoming a common change.

This change introduces a chain of handlers which can modify a request or
return a response of their own.

To start with, this extracts the concerns of fixing missing content
types, setting custom headers, and intercepting blacklisted requests.
2014-11-24 09:52:34 -05:00
Matthew Horan
be22bfe244 Share the NetworkAccessManager across WebPages
Destroying the NetworkAccessManager seems to result in "terminate called
without an active exception" segfaults. The documentation states that an
application requires only a single single NetworkAccessManager.
2013-03-18 08:14:35 -04:00
Matthew Horan
c74949bd04 Rename Command::emitFinished to finish 2013-02-11 18:31:41 -05:00
Sean Geoghegan
77811ca9ba Fix memory leak of response.
Turns Response into a QObject and sets parent to the
command that emits it.

Each Command is also a child of the decorator commands,
Timeout and PageLoading commnds, so that deleting the
top level command will delete all the children.

See discussion in #430.
2012-12-14 01:46:54 -05:00
Matthew Horan
5127c01366 Fix status code and headers for iframes
QWebFrame::url() does not return a valid URL for iframes.  We can't just
look up the requested URL in m_responses because the request may have
been redirected, so instead we keep track of redirects and set up the
NetworkResponse when the final reply is received.
2012-11-30 21:26:40 -05:00
Joe Ferris
95732ad796 Split Command into more abstract Command and concrete SocketCommand 2012-07-08 12:04:30 -07:00
Matthew Horan
f80125e6cb Pass the WebPageManager to each command 2012-05-29 22:23:02 -04:00
Joe Ferris
85dcc729dd Pass command arguments to the constructor 2012-03-16 19:58:58 -04:00
os0x
818f654e4e fix spell
move header specs to driver_spec
2011-06-25 20:48:01 +09:00
shogo-ohta
ee1388e329 add header support 2011-06-24 13:55:03 +09:00