Commit Graph

26 Commits

Author SHA1 Message Date
wonda-tea-coffee 7e947ba38c Suppress rspec deprecation
e.g)
The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g  `expect { value }.to raise CarrierWave::DownloadError` not `expect(value).to raise CarrierWave::DownloadError`
2022-06-18 12:54:48 +09:00
M.Shibuya 7a40ef7c4d
Completely migrate to allowlist/denylist terminology, with deprecating denylist
Closes #2536
2021-10-31 18:32:52 +09:00
Vishal Patel 568fa595a3 Allow uploaders to use unless conditions 2021-10-05 19:10:16 -04:00
M.Shibuya dafab19c32
Rename remaining whitelist/blacklist terminology to allowlist/denylist
Refs. #2442
2021-02-20 19:49:22 +09:00
M.Shibuya 012702eb3b
Fix SSRF vulnerability in the remote file download feature
Closes #2509, Refs. https://github.com/carrierwaveuploader/carrierwave/security/advisories/GHSA-fwcm-636p-68r5
2021-02-08 13:42:22 +09:00
M.Shibuya 22e8005e44
Fix passing empty string to #image_cache= causes existing ones deleted. Fixes #2412
Refs. 8f18a95b
2019-08-25 16:34:09 +09:00
M.Shibuya 67800fdeb7
Delete files only once when marked for removal
On update clearing uploaders in write_#{column}_identifier is enough, remove_previously_stored_#{column} will do the rest
2019-06-22 10:20:11 +09:00
M.Shibuya 42da7c1b6c
Allow #images= to accept cache name, making cache feature more friendly to keep-stored feature 2019-06-18 19:29:04 +09:00
M.Shibuya 19c97c7e35
Allow deleting all files for multiple file upload. Fixes #1990 2019-06-18 16:40:08 +09:00
M.Shibuya 7db9195de3
[breaking] Change to preserve successful files even if others failed 2019-06-18 16:25:32 +09:00
M.Shibuya 8f18a95b74
[breaking] Make #images_cache= and #remote_images_urls= compatiblie with keep-stored feature
This changes behavior of remote file download not to overwrite newly uploaded file
2019-06-18 13:13:28 +09:00
M.Shibuya 0ffad68709
Add keep-stored and reorder feature for multiple file uploader 2019-06-18 13:12:54 +09:00
Timur Yanberdin 301f927d72 fix broken specs 2016-08-21 17:15:39 +03:00
Thiago Fernandes Massa 3c21014216 Refactored more specs
Fixed more specs...

Worked a bit more in the specs

More work in the mount multiple spec

Finished refactoring mount multiple spec
2016-04-01 23:05:20 +02:00
Mehdi Lahmam 55f9fad78f Replace ShamRack by WebMock in specs
WebMock provides a cleaner API that helps to simplify some specs
examples.
2016-01-09 20:20:56 +01:00
Mehdi Lahmam 06003a5044 Rename `extension_white_list` ~> `extension_whitelist`
Breaking changes:
* Rename `extension_white_list` ~> `extension_whitelist`
* Rename `extension_black_list` ~> `extension_blacklist`.
* Rename i18n keys `extension_black_list_error` ~> `extension_blacklist_error`
  and `extension_white_list_error` ~> `extension_whitelist_error`

Rename `check_blacklist!` internal callback ~> `check_extension_blacklist`, which
is more precise and less prone to collisions with other callbacks
methods names.
2016-01-02 19:28:34 +01:00
Mehdi Lahmam f4501394b9 Remove UTF-8 magic comments from all the Ruby files
Ruby 2 made UTF-8 the default encoding, which make magic comments
omissible.
2016-01-02 16:38:59 +01:00
Boris Gvozdev 3e989fc366 Add counter to cache_id
Old version of generate_cache_id was collision-prone: for complex factories with multiple uploaders we had quite a few flaky specs because of that. With a counter, this (and similar situations like https://github.com/carrierwaveuploader/carrierwave/issues/1232) should be resolved completely.
2015-12-14 20:43:18 +06:00
Piotr Boniecki 8f0539c8c0 Fix `Mounter.blank?` method 2015-09-24 18:07:05 +02:00
Aggelos Avgerinos 3407ed122e Move to Rspec 3 syntax 2015-04-22 23:00:01 +03:00
Jonas Nicklas and Lisa Hammarström a477d6b76d Fix documentation for mount_uploaders 2014-10-17 09:33:13 +02:00
Jonas Nicklas and Lisa Hammarström d54d5df7c3 Move back into mount file 2014-10-17 09:33:13 +02:00
Jonas Nicklas and Lisa Hammarström 4617a77d76 Make remaining specs pass 2014-10-17 09:33:13 +02:00
Jonas Nicklas and Lisa Hammarström e38789cd40 First stab at supporting arrays 2014-10-17 09:33:13 +02:00
Jonas Nicklas and Lisa Hammarström 1f168cd78f Pluralize column name 2014-10-17 09:33:13 +02:00
Jonas Nicklas and Lisa Hammarström 1ac1268d9b Add a module for supporting multiple files 2014-10-17 09:33:13 +02:00