carrierwaveuploader--carrie.../spec/processing
Akihiko Odaki 7af7db3636 Remove implementation-dependent information from an error message
The message for CarrierWave::ProcessingError used to include
- the name of the underlying image processor (RMagick, MiniMagick or
  libvips) and
- the original error message produced by it.

The message is used for ActiveRecord validation, and it is often shown for
an end-user. This behavior has some downsides:
- The message may look cryptic and is confusing for end-users. A typical
  end-user has no idea what is RMagick, for example.
- The information the message carries may be valuable for an adversary.
  Especially, the image processor may not be careful enough to mask
  sensitive information in an error message it produces. e.g. MiniMagick
  may include stderr of ImageMagick, which may contain file paths and
  reveal underlying ImageMagick configurations, in an error message.

This change solves the problems by simply removing those information.
You may still retrieve the original error message with
CarrierWave::ProcessingError#cause for debugging or programatic error
handling.
2021-05-31 21:05:49 +09:00
..
mini_magick_spec.rb Remove implementation-dependent information from an error message 2021-05-31 21:05:49 +09:00
rmagick_spec.rb Remove implementation-dependent information from an error message 2021-05-31 21:05:49 +09:00
vips_spec.rb Remove implementation-dependent information from an error message 2021-05-31 21:05:49 +09:00