kotovalexarian-likes-github
/
database_cleaner
mirror of https://github.com/DatabaseCleaner/database_cleaner
1
0
Fork 0
Code Releases Activity

Merge pull request #538 from botandrose/fix_sequel_primary_key_sequence_resetting 

Fix primary key sequence resetting in Sequel with Postgres and SQLite
This commit is contained in:
Ernesto Tagwerker 2018-05-20 13:41:37 -04:00 committed by GitHub
parent 93bebb90c7 9206180a53
commit 3f76c9d775
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 35 additions and 101 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
lib/database_cleaner/sequel/truncation.rb
View File

@ -14,39 +14,40 @@ module DatabaseCleaner
def clean
return unless dirty?
tables = tables_to_truncate(db)
# Count rows before truncating
if pre_count?
tables = pre_count_tables(tables)
end
case db.database_type
when :postgres
# PostgreSQL requires all tables with FKs to be truncates in the same command, or have the CASCADE keyword
# appended. Bulk truncation without CASCADE is:
# * Safer. Tables outside of tables_to_truncate won't be affected.
# * Faster. Less roundtrips to the db.
unless (tables = tables_to_truncate(db)).empty?
all_tables = tables.map { |t| %("#{t}") }.join(',')
db.run "TRUNCATE TABLE #{all_tables};"
unless tables.empty?
tables_sql = tables.map { |t| %("#{t}") }.join(',')
db.run "TRUNCATE TABLE #{tables_sql} RESTART IDENTITY;"
end
else
tables = tables_to_truncate(db)
if pre_count?
# Count rows before truncating
pre_count_truncate_tables(db, tables)
else
# Truncate each table normally
truncate_tables(db, tables)
end
truncate_tables(db, tables)
end
end
private
def pre_count_truncate_tables(db, tables)
tables = tables.reject { |table| db[table.to_sym].count == 0 }
truncate_tables(db, tables)
def pre_count_tables tables
tables.reject { |table| db[table.to_sym].count == 0 }
end
def truncate_tables(db, tables)
tables.each do |table|
db[table.to_sym].truncate
if db.database_type == :sqlite && db.table_exists?(:sqlite_sequence)
db[:sqlite_sequence].where(name: table).delete
end
end
end

105
spec/database_cleaner/sequel/truncation_spec.rb
View File

@ -10,14 +10,6 @@ module DatabaseCleaner
end
RSpec.shared_examples 'a Sequel truncation strategy' do
# XXX: it'd be really nice if Truncation accepted db: constructor parameter
let(:truncation) do
t = Truncation.new
t.db = db
t
end
context 'when several tables have data' do
before do
db.create_table!(:precious_stones) { primary_key :id }
@ -64,63 +56,13 @@ module DatabaseCleaner
end
end
RSpec.shared_examples_for 'a truncation strategy without autoincrement resets' do
it "leaves AUTO_INCREMENT index alone by default (BUG: it should be reset instead)" do
pending
# Jordan Hollinger made everything reset auto increment IDs
# in commit 6a0104382647e5c06578aeac586c0333c8944492 so I'm pretty sure
# everything is meant to reset by default.
#
# For Postgres, db[:mytable].truncate(restart: true) should work.
# For SQLite, db[:sqlite_sequence].where(name: 'mytable').delete
db.create_table!(:replaceable_trifles) { primary_key :id }
table = db[:replaceable_trifles]
2.times { table.insert }
truncation.clean
id_after_clean = table.insert
expect(id_after_clean).to eq 1
end
# XXX: it'd be really nice if Truncation accepted db: constructor parameter
let(:truncation) do
t = Truncation.new
t.db = db
t
end
end
RSpec.shared_examples_for 'a truncation strategy that resets autoincrement keys by default' do
it "resets AUTO_INCREMENT primary keys" do
db.create_table!(:replaceable_trifles) { primary_key :id }
table = db[:replaceable_trifles]
2.times { table.insert }
truncation.clean
id_after_clean = table.insert
expect(id_after_clean).to eq 1
end
# XXX: it'd be really nice if Truncation accepted db: constructor parameter
let(:truncation) do
t = Truncation.new
t.db = db
t
end
end
half_supported_configurations = [
configurations = [
{url: 'mysql:///', connection_options: db_config['mysql']},
{url: 'mysql2:///', connection_options: db_config['mysql2']},
{url: 'sqlite:///', connection_options: db_config['sqlite3']},
{url: 'postgres:///', connection_options: db_config['postgres']},
]
supported_configurations = [
{url: 'mysql:///', connection_options: db_config['mysql']},
{url: 'mysql2:///', connection_options: db_config['mysql2']}
]
supported_configurations.each do |config|
configurations.each do |config|
RSpec.describe "Sequel truncation (using a #{config[:url]} connection)" do
around do |example|
helper = SequelHelper.new(config)
@ -132,9 +74,9 @@ module DatabaseCleaner
end
let(:db) { ::Sequel.connect(config[:url], config[:connection_options]) }
subject { Truncation.new.tap { |t| t.db = db } }
it_behaves_like 'a Sequel truncation strategy'
it_behaves_like 'a truncation strategy that resets autoincrement keys by default'
describe '#pre_count?' do
@ -155,45 +97,36 @@ module DatabaseCleaner
end
end
describe "relying on #pre_count_truncate_tables if asked to" do
subject { Truncation.new.tap { |t| t.db = db } }
it "should rely on #pre_count_truncate_tables if #pre_count? returns true" do
describe "relying on #pre_count_tables if asked to" do
it "should rely on #pre_count_tables if #pre_count? returns true" do
subject.instance_variable_set(:"@pre_count", true)
expect(subject).not_to receive(:truncate_tables)
expect(subject).to receive(:pre_count_truncate_tables)
expect(subject).to receive(:pre_count_tables).and_return([])
subject.clean
end
it "should not rely on #pre_count_truncate_tables if #pre_count? return false" do
it "should not rely on #pre_count_tables if #pre_count? return false" do
subject.instance_variable_set(:"@pre_count", false)
expect(subject).not_to receive(:pre_count_truncate_tables)
expect(subject).to receive(:truncate_tables)
expect(subject).not_to receive(:pre_count_tables)
subject.clean
end
end
end
end
half_supported_configurations.each do |config|
RSpec.describe "Sequel truncation (using a #{config[:url]} connection)" do
around do |example|
helper = SequelHelper.new(config)
helper.setup
describe 'auto increment sequences' do
it "resets AUTO_INCREMENT primary key seqeunce" do
db.create_table!(:replaceable_trifles) { primary_key :id }
table = db[:replaceable_trifles]
2.times { table.insert }
example.run
subject.clean
helper.teardown
id_after_clean = table.insert
expect(id_after_clean).to eq 1
end
end
let(:db) { ::Sequel.connect(config[:url], config[:connection_options]) }
it_behaves_like 'a Sequel truncation strategy'
it_behaves_like 'a truncation strategy without autoincrement resets'
end
end
end