From 635206ac25be1e8f6acf282af08b4836269ea4a7 Mon Sep 17 00:00:00 2001 From: Tomas Varaneckas Date: Wed, 9 Mar 2016 18:03:21 +0200 Subject: [PATCH 1/2] Make namespace symbol friendly Currently limit_fetch fails to work with symbol namespaces with following error: `Error fetching job: undefined method `+' for :sidekiq:Symbol` --- lib/sidekiq/limit_fetch/queues.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/sidekiq/limit_fetch/queues.rb b/lib/sidekiq/limit_fetch/queues.rb index 9ae7e68..897e293 100644 --- a/lib/sidekiq/limit_fetch/queues.rb +++ b/lib/sidekiq/limit_fetch/queues.rb @@ -48,7 +48,7 @@ module Sidekiq::LimitFetch::Queues def namespace @namespace ||= Sidekiq.redis do |it| if it.respond_to?(:namespace) and it.namespace - it.namespace + ':' + "#{it.namespace}:" else '' end From 3a1fdd0f28577bdeb5633a852920c7d56a4de6f2 Mon Sep 17 00:00:00 2001 From: Tomas Varaneckas Date: Thu, 10 Mar 2016 11:19:08 +0200 Subject: [PATCH 2/2] Use array in gem.require_paths On older ruby versions string value fails with: NoMethodError: undefined method `join' for "lib":String --- sidekiq-limit_fetch.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sidekiq-limit_fetch.gemspec b/sidekiq-limit_fetch.gemspec index ebbe2a9..d840e19 100644 --- a/sidekiq-limit_fetch.gemspec +++ b/sidekiq-limit_fetch.gemspec @@ -13,7 +13,7 @@ Gem::Specification.new do |gem| gem.files = `git ls-files`.split($/) gem.test_files = gem.files.grep %r{^spec/} - gem.require_paths = 'lib' + gem.require_paths = %w(lib) gem.add_dependency 'sidekiq', '>= 4' gem.add_development_dependency 'redis-namespace', '~> 1.5', '>= 1.5.2'