Commit Graph

5 Commits

Author SHA1 Message Date
Marc Siegel 25114d0c1d Add Rubocop and run checks in CI
This should finally allow us to adopt code style lints, as well
as others such as performance linting, and have them enforced by
the Github Actions continuous integration (CI) jobs.

For now, I'm choosing to depend on the 'panolint' gem from
Panorama Education, which is my current workplace, as I'd like
to adopt and stay consistent with the setting used there.

Changes
  * Move development and test dependencies from gemspec to Gemfile
  * Add dependency on 'panolint' gem
  * Add .rubocop.yml
  * Fix all existing issues
  * Run rubocop in github actions CI
2021-05-10 17:20:00 -04:00
Marc Siegel 2716579ff9
Merge pull request #68 from taichi-ishitani/introduce_codecov_action
Introduce Codecov action
2021-05-08 10:59:46 -04:00
Taichi Ishitani 26d0c0e327 use codecov action instead of codecov gem 2021-05-08 23:49:47 +09:00
Taichi Ishitani 8158993762 use 'bundler-cache' option instead of running 'bundle install' directly 2021-05-08 08:37:38 +09:00
Marc Siegel 5455d69af6 Add Github Actions CI configuration
Based on: https://github.com/ruby/setup-ruby

Re: #60

Some notes on the initial Github Actions config:

  1. Set min ruby version to 2.5 in order to support JRuby,
     which as of 9.2.17.0 has a RUBY_VERSION of 2.5.

  2. For CodeCov exclude JRuby and TruffleRuby, to avoid
     errors sending the results in Github Actions on those
     jobs rather than debugging them further.

  3. Plan is to next remove Travis CI, and then to convert
     the CodeCov config to use the Github Action for CodeCov
     (thanks @taichi-ishitani for this suggestion!)
2021-05-06 11:24:42 -04:00