kotovalexarian-likes-github
/
draper
mirror of https://github.com/drapergem/draper
1
0
Fork 0
Code Releases Activity

Use current rspec API for rspec stub example in README (#855) 

In rspec 3, if you try:

    helpers.stub(users_path: '/users')

You get a deprecation warning:

    Using `stub` from rspec-mocks' old `:should` syntax without explicitly enabling the syntax is deprecated. Use the new `:expect` syntax or explicitly enable `:should` instead.

And in addition to the deprecation warning, it actually fails with a message:

    #<Draper::HelperProxy: ...  [lots of text] ... does not implement: users_path

If we switch to 'new' rspec API `allow(:helpers).to receive(:users_path).and_return("/users"), we don't get the deprecation method, but still get the failure with same error message.

If we additionally wrap in `without_partial_double_verification` [introduced in RSpec 3.6 in May 2017](http://rspec.info/blog/2017/05/rspec-3-6-has-been-released/), all is well.

It would save the user a lot of time to provide a nice non-deprecated working-under-default-Rspec example for RSpec stubbing, instead of giving them deprecated/non-working example and making them figure it out.

pic: 8128cca Work and Collection factories default to publisheddd
This commit is contained in:
Jonathan Rochkind 2019-05-31 09:33:41 -04:00 committed by Cliff Braton
parent d44c86f1e5
commit 27e83b41ca
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
README.md
View File

@ -380,7 +380,7 @@ can continue to use the `@article` instance variable to manipulate the model -
for example, `@article.comments.build` to add a new blank comment for a form.
## Configuration
Draper works out the box well, but also provides a hook for you to configure its
Draper works out the box well, but also provides a hook for you to configure its
default functionality. For example, Draper assumes you have a base `ApplicationController`.
If your base controller is named something different (e.g. `BaseController`),
you can tell Draper to use it by adding the following to an initializer:
@ -469,10 +469,13 @@ end
```
Then you can stub the specific route helper functions you need using your
preferred stubbing technique (this example uses RSpec's `stub` method):
preferred stubbing technique. This examples uses Rspec currently recommended API
available in RSpec 3.6+
```ruby
helpers.stub(users_path: '/users')
without_partial_double_verification do
allow(helpers).to receive(:users_path).and_return('/users')
end
```
### View context leakage
@ -646,7 +649,7 @@ you can include this module manually.
### Active Job Integration
[Active Job](http://edgeguides.rubyonrails.org/active_job_basics.html) allows you to pass ActiveRecord
[Active Job](http://edgeguides.rubyonrails.org/active_job_basics.html) allows you to pass ActiveRecord
objects to background tasks directly and performs the necessary serialization and deserialization. In
order to do this, arguments to a background job must implement [Global ID](https://github.com/rails/globalid).
Decorated objects implement Global ID by delegating to the object they are decorating. This means