1
0
Fork 0
mirror of https://github.com/drapergem/draper synced 2023-03-27 23:21:17 -04:00
Commit graph

31 commits

Author SHA1 Message Date
y-yagi
89ec4b70f4 Add support for Rails 6.0 to ViewContext::BuildStrategy (#866)
* Add support for Rails 6.0 to `ViewContext::BuildStrategy`

In Rails 6.0 the API for `ActionView::Base.new` is changing.
`ActionView::Base.new` now take arguments [1], otherwise you
will see the following deprecation warning:

```
DEPRECATION WARNING: ActionView::Base instances should be constructed with a lookup context, assignments, and a controller.
```

[1] e17fe52e0e

`ViewContext::BuildStrategy::Fast` does not have lookup context, so use `empty`
method instead of `new` to build instance.

* Bump a Rails version of dummy application

Also bump a sqlite version because Rails 6.0 requires upper sqlite
1.4.0.

* Add `ApplicationController` to dummy application

Because Action Text expects `ApplicationController` exists.
Ref: https://github.com/rails/rails/issues/35749#issuecomment-525083643

* Test against Rails 6.0 that only supported Ruby versions
2020-01-07 10:58:00 -06:00
Cliff Braton
eb3468238f
Add manifest.js for newer versions of sprockets 2019-10-18 09:54:26 -05:00
Cliff Braton
815c4186dd Feature: ActiveJob Integration and Documentation (#817)
* Add note on Active Job integration for #663

* Implement GlobalID by delegating to object and add documentation.

* Update readme and add missing require statement.

* Actually include the module.

* Create post instead of assuming it exists.

* Add test for #to_global_id.
2017-09-11 09:35:14 -07:00
Dmytro Stepaniuk
607f03e908 Railsify dummy app (rails v5.*) (#810)
* add filter_parameter_logging initializer

* models in rails 5.* should be inherited from abstract application record class
2017-06-20 08:56:53 -05:00
Bartek Bułat
af7f3a6736 Fix failing specs re Rails 5.1 (#800)
* Fix failing specs re Rails 5.1

Because there is no hard constraint on Rails version, tests run against
the newest version available. Rails 5.1 removes `to_h` from unpermitted
parameters class. Using `empty?` is sufficient replacement.

* Fix Dummy app `posts#mail` action rendering

Rails 5.1 does not accept `:text` key for `render`.
2017-05-05 10:28:28 -05:00
Cliff Braton
ff36bd81ad Add support for custom default controller configuration (#788)
* Add configure functionality to allow customizing the default.

* Add configuration module and tests.

* Add documentation to the README.md

* Skip tests that only fail when whole suite is ran.

* Fix the double leaking by re-writing the test that caused the issue.

* Clean up railtie - Exract out method, Remove unnecessary compatibility.

* Add new functionality to the dummy app to increase test coverage.
2017-03-31 09:05:15 -05:00
Thibault Jouan
50dea101b2 Remove executable bit from lib and spec source files (#718) 2017-03-27 22:39:17 -05:00
Sean Linsley
1e52e791ff _path helpers are no longer available in mailers
https://github.com/rails/rails/pull/15840
2016-07-04 15:16:35 -05:00
Jeff Casimir
f4797ed1e1 Hacking around Rails 4.2 incompatibilities 2015-03-26 21:48:51 -06:00
Andrew Haines
3b092b2248 Add more route helper integration specs 2013-07-14 16:03:16 +01:00
Andrew Haines
0a09c096a6 Only define MongoidPostDecorator when using Mongoid 2013-06-02 21:23:08 +01:00
Andrew Haines
4b933ef39d Rename source to object
Closes #501
2013-04-30 14:10:52 +01:00
Andrew Haines
2de0592214 Add integration specs for Decoratable.decorate 2013-03-03 11:13:32 +00:00
Andrew Haines
afa97bb401 Add decorates_assigned method to controllers 2013-02-07 01:00:48 +00:00
Andrew Haines
d1b22caa59 Improve Devise integration 2013-01-25 17:42:56 +00:00
Andrew Haines
8b0150317d Basic mongoid integration spec 2013-01-21 13:39:19 +00:00
Andrew Haines
3d07cb387b Prevent leaking view contexts between tests 2013-01-19 21:55:57 +00:00
Andrew Haines
fa2d5274a6 More integration specs 2013-01-16 16:30:53 +00:00
Andrew Haines
c510a92a3c Add integration test for AM::Serialization support
...which shows that we need to always `delegate :attributes`
2013-01-16 16:28:55 +00:00
Andrew Haines
c6f8aaa2b2 Remove allows, denies and denies_all from Decorator
Automatic delegation of methods is now achieved with `delegate_all`,
which includes the new AutomaticDelegation module.

Manual delegation is achieved using the standard Active Support
`delegate` method, which is enhanced so that `to: :source` is the
default.
2013-01-14 03:57:47 +00:00
Andrew Haines
d528fffe78 Rails 3.0 compatibility 2013-01-12 16:34:55 +00:00
Chris Heald
731995a5fe Provide support for class methods. Reintroduce the decorates class method, which may be used to hint at which class to delegate class methods to. 2012-12-02 14:16:03 +00:00
Andrew Haines
cfbc3888e9 Add mailer specs
Closes #316
2012-11-13 20:32:29 +00:00
Andrew Haines
cef5e628be Integration tests for all environments
The problem with using Cucumber is that it runs the dummy app in the
test environment. Because the view context behaviour is dependent on
environment, we need to test it running on an actual server.
2012-11-12 19:59:43 +00:00
Andrew Haines
b4a5839345 Remove some scaffolding 2012-11-10 16:50:09 +00:00
Steve Klabnik
bf84303a62 Fix the build.
My decorator was silly. When UTC's today is different
than today's today, the decorator would be wrong. Now
we make sure to convert both to utc before making
the comparison
2012-11-02 19:19:39 -07:00
Andrew Haines
e1214d97b6 Remove .decorates method 2012-10-31 17:55:38 +00:00
Steve Klabnik
bfc33537b9 Add features around url helpers 2012-10-24 07:24:03 -04:00
Steve Klabnik
9f869ab84c Updating with latest master.
Needed to turn Base -> Decorator, and also add
the test db back to the repo so that travis will
have a copy.
2012-10-19 14:16:16 -03:00
Steve Klabnik
6b5b0a77ee Added first integration test
This test tests the following Draper features:

1) finders
2) decorates
3) using a decorated method

It also is the first test that verifies that the whole Cucumber setup
actually works properly.
2012-10-19 14:12:27 -03:00
Steve Klabnik
90a4859085 Adding cucumber stuff for integration testing.
I've embedded a little Rails app so that we can write cuke tests and
make sure that stuff doesn't break. Woo!

This was generated by making a rails engine, then copying just the
app over.

Thanks @nashby for fixing my stupid bug with sqlite3; it had to be
added as a development dependency. ❤️
2012-10-19 14:12:27 -03:00