assert collection is paged

lib/fog/aws/iam/paged_collection.rb

@@ -13,7 +13,9 @@ module Fog
           to_a.each(*args, &block)
         end
 
-        def each
+        def each(options={})
+          limit = options[:limit] || 100
+
           if !block_given?
             self
           else
@@ -23,7 +25,7 @@ module Fog
 
             while subset.truncated
               subset.
-                all(:marker => subset.marker, :limit => 1000).
+                all(:marker => subset.marker, :limit => limit).
                 each_entry { |f| yield f }
             end
 

lib/fog/aws/models/iam/roles.rb

@@ -7,13 +7,16 @@ module Fog
 
         model Fog::AWS::IAM::Role
 
-        def all
+        def all(options={})
-          load(service.list_roles.body['Roles'])
+          body = service.list_roles(page_params(options)).body
+
+          merge_attributes(body)
+          load(body["Roles"])
         end
 
         def get(identity)
           new(service.get_role(identity).body["Role"])
-        rescue Excon::Errors::NotFound, Fog::AWS::IAM::NotFound # ignore not found error
+        rescue Excon::Errors::NotFound, Fog::AWS::IAM::NotFound
           nil
         end
 

tests/models/iam/roles_tests.rb

@@ -52,6 +52,16 @@ Shindo.tests("Fog::Compute[:iam] | roles", ['aws','iam']) do
     @iam.roles.get(@role_one_name).destroy
   end
 
+  tests('#all', 'limit 1').succeeds do
+    1 == @iam.roles.all(:limit => 1).size
+  end
+
+  tests('#all', 'each_entry').succeeds do
+    roles = []; @iam.roles.each(:limit => 1) { |r| roles << r }
+
+    3 == roles.size
+  end
+
   tests('#destroy','clean up remaining roles').succeeds do
     @iam.roles.get(@role_two_name).destroy
     @iam.roles.get(@role_three_name).destroy