kotovalexarian-likes-github/fog--fog-aws
1
0
Fork 0
mirror of https://github.com/fog/fog-aws.git synced 2022-11-09 13:50:52 -05:00
Code Releases Activity

[AWS|Core] Fix signature v4 non canonicalising header case properly

Browse source
This commit is contained in:
Frederick Cheung 2015-01-11 21:06:22 +00:00
parent 3dad29880c
commit 3f69279ffd
2 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/fog/aws/signaturev4.rb
View file

@ -104,14 +104,14 @@ DATA
def canonical_headers(headers)
canonical_headers = ''
for key in headers.keys.sort_by {|k| k.to_s}
for key in headers.keys.sort_by {|k| k.to_s.downcase}
canonical_headers << "#{key.to_s.downcase}:#{headers[key].to_s.strip}\n"
end
canonical_headers
end
def signed_headers(headers)
headers.keys.map {|key| key.to_s}.sort.map {|key| key.downcase}.join(';')
headers.keys.map {|key| key.to_s.downcase}.sort.join(';')
end
end

6
tests/signaturev4_tests.rb
View file

@ -13,6 +13,12 @@ Shindo.tests('AWS | signaturev4', ['aws']) do
end
end
tests('get-headers-mixed-case-headers') do
returns(@signer.sign({:headers => {'HOST' => 'host.foo.com', 'date' => 'Mon, 09 Sep 2011 23:36:00 GMT'}, :method => :get, :path => '/'}, @now)) do
'AWS4-HMAC-SHA256 Credential=AKIDEXAMPLE/20110909/us-east-1/host/aws4_request, SignedHeaders=date;host, Signature=b27ccfbfa7df52a200ff74193ca6e32d4b48b8856fab7ebf1c595d0670a7e470'
end
end
tests('get-vanilla-query-order-key with symbol keys') do
returns(@signer.sign({:query => {:'a' => 'foo', :'b' => 'foo'}, :headers => {:'Host' => 'host.foo.com', 'Date' => 'Mon, 09 Sep 2011 23:36:00 GMT'}, :method => :get, :path => '/'}, @now)) do
'AWS4-HMAC-SHA256 Credential=AKIDEXAMPLE/20110909/us-east-1/host/aws4_request, SignedHeaders=date;host, Signature=0dc122f3b28b831ab48ba65cb47300de53fbe91b577fe113edac383730254a3b'