[ec2] make things that shouldn't cost money idempotent

lib/fog/aws/requests/ec2/associate_address.rb

@@ -19,6 +19,7 @@ module Fog
             'Action'      => 'AssociateAddress',
             'InstanceId'  => instance_id,
             'PublicIp'    => public_ip,
+            :idempotent   => true,
             :parser       => Fog::Parsers::AWS::EC2::Basic.new
           )
         end

lib/fog/aws/requests/ec2/attach_volume.rb

@@ -25,6 +25,7 @@ module Fog
             'VolumeId'    => volume_id,
             'InstanceId'  => instance_id,
             'Device'      => device,
+            :idempotent   => true,
             :parser       => Fog::Parsers::AWS::EC2::AttachVolume.new
           )
         end

lib/fog/aws/requests/ec2/authorize_security_group_ingress.rb

@@ -24,8 +24,9 @@ module Fog
         #     * 'return'<~Boolean> - success?
         def authorize_security_group_ingress(options = {})
           request({
-            'Action'  => 'AuthorizeSecurityGroupIngress',
+            'Action'    => 'AuthorizeSecurityGroupIngress',
-            :parser   => Fog::Parsers::AWS::EC2::Basic.new
+            :idempotent => true,
+            :parser     => Fog::Parsers::AWS::EC2::Basic.new
           }.merge!(options))
         end
 

lib/fog/aws/requests/ec2/delete_security_group.rb

@@ -17,6 +17,7 @@ module Fog
           request(
             'Action'    => 'DeleteSecurityGroup',
             'GroupName' => name,
+            :idempotent => true,
             :parser     => Fog::Parsers::AWS::EC2::Basic.new
           )
         end

lib/fog/aws/requests/ec2/delete_snapshot.rb

@@ -17,6 +17,7 @@ module Fog
           request(
             'Action'      => 'DeleteSnapshot',
             'SnapshotId'  => snapshot_id,
+            :idempotent   => true,
             :parser       => Fog::Parsers::AWS::EC2::Basic.new
           )
         end

lib/fog/aws/requests/ec2/delete_volume.rb

@@ -17,6 +17,7 @@ module Fog
           request(
             'Action'    => 'DeleteVolume',
             'VolumeId'  => volume_id,
+            :idempotent => true,
             :parser     => Fog::Parsers::AWS::EC2::Basic.new
           )
         end

lib/fog/aws/requests/ec2/describe_addresses.rb

@@ -18,8 +18,9 @@ module Fog
         def describe_addresses(public_ip = [])
           params = AWS.indexed_param('PublicIp', public_ip)
           request({
-            'Action'  => 'DescribeAddresses',
+            'Action'    => 'DescribeAddresses',
-            :parser   => Fog::Parsers::AWS::EC2::DescribeAddresses.new
+            :idempotent => true,
+            :parser     => Fog::Parsers::AWS::EC2::DescribeAddresses.new
           }.merge!(params))
         end
 

lib/fog/aws/requests/ec2/describe_availability_zones.rb

@@ -19,8 +19,9 @@ module Fog
         def describe_availability_zones(zone_name = [])
           params = AWS.indexed_param('ZoneName', zone_name)
           request({
-            'Action'  => 'DescribeAvailabilityZones',
+            'Action'    => 'DescribeAvailabilityZones',
-            :parser   => Fog::Parsers::AWS::EC2::DescribeAvailabilityZones.new
+            :idempotent => true,
+            :parser     => Fog::Parsers::AWS::EC2::DescribeAvailabilityZones.new
           }.merge!(params))
         end
 

lib/fog/aws/requests/ec2/describe_images.rb

@@ -33,8 +33,9 @@ module Fog
             options.merge!(AWS.indexed_param('ImageId', image_id))
           end
           request({
-            'Action'  => 'DescribeImages',
+            'Action'    => 'DescribeImages',
-            :parser   => Fog::Parsers::AWS::EC2::DescribeImages.new
+            :idempotent => true,
+            :parser     => Fog::Parsers::AWS::EC2::DescribeImages.new
           }.merge!(options))
         end
 

lib/fog/aws/requests/ec2/describe_key_pairs.rb

@@ -18,8 +18,9 @@ module Fog
         def describe_key_pairs(key_name = [])
           params = AWS.indexed_param('KeyName', key_name)
           request({
-            'Action'  => 'DescribeKeyPairs',
+            'Action'    => 'DescribeKeyPairs',
-            :parser   => Fog::Parsers::AWS::EC2::DescribeKeyPairs.new
+            :idempotent => true,
+            :parser     => Fog::Parsers::AWS::EC2::DescribeKeyPairs.new
           }.merge!(params))
         end
 

lib/fog/aws/requests/ec2/describe_regions.rb

@@ -18,8 +18,9 @@ module Fog
         def describe_regions(region_name = [])
           params = AWS.indexed_param('RegionName', region_name)
           request({
-            'Action'  => 'DescribeRegions',
+            'Action'    => 'DescribeRegions',
-            :parser   => Fog::Parsers::AWS::EC2::DescribeRegions.new
+            :idempotent => true,
+            :parser     => Fog::Parsers::AWS::EC2::DescribeRegions.new
           }.merge!(params))
         end
 

lib/fog/aws/requests/ec2/describe_reserved_instances.rb

@@ -26,8 +26,9 @@ module Fog
         def describe_reserved_instances(reserved_instances_id = [])
           params = AWS.indexed_param('ReservedInstancesId', reserved_instances_id)
           request({
-            'Action'  => 'DescribeReservedInstances',
+            'Action'    => 'DescribeReservedInstances',
-            :parser   => Fog::Parsers::AWS::EC2::DescribeReservedInstances.new
+            :idempotent => true,
+            :parser     => Fog::Parsers::AWS::EC2::DescribeReservedInstances.new
           }.merge!(params))
         end
 

lib/fog/aws/requests/ec2/describe_security_groups.rb

@@ -28,8 +28,9 @@ module Fog
         def describe_security_groups(group_name = [])
           params = AWS.indexed_param('GroupName', group_name)
           request({
-            'Action'  => 'DescribeSecurityGroups',
+            'Action'    => 'DescribeSecurityGroups',
-            :parser   => Fog::Parsers::AWS::EC2::DescribeSecurityGroups.new
+            :idempotent => true,
+            :parser     => Fog::Parsers::AWS::EC2::DescribeSecurityGroups.new
           }.merge!(params))
         end
 

lib/fog/aws/requests/ec2/describe_snapshots.rb

@@ -25,8 +25,9 @@ module Fog
           options['Owner'] ||= 'self'
           options.merge!(AWS.indexed_param('SnapshotId', snapshot_id))
           request({
-            'Action'  => 'DescribeSnapshots',
+            'Action'    => 'DescribeSnapshots',
-            :parser   => Fog::Parsers::AWS::EC2::DescribeSnapshots.new
+            :idempotent => true,
+            :parser     => Fog::Parsers::AWS::EC2::DescribeSnapshots.new
           }.merge!(options))
         end
 

lib/fog/aws/requests/ec2/describe_volumes.rb

@@ -27,8 +27,9 @@ module Fog
         def describe_volumes(volume_id = [])
           params = AWS.indexed_param('VolumeId', volume_id)
           request({
-            'Action'  => 'DescribeVolumes',
+            'Action'    => 'DescribeVolumes',
-            :parser   => Fog::Parsers::AWS::EC2::DescribeVolumes.new
+            :idempotent => true,
+            :parser     => Fog::Parsers::AWS::EC2::DescribeVolumes.new
           }.merge!(params))
         end
 

lib/fog/aws/requests/ec2/detach_volume.rb

@@ -25,6 +25,7 @@ module Fog
           request({
             'Action'    => 'DetachVolume',
             'VolumeId'  => volume_id,
+            :idempotent => true,
             :parser     => Fog::Parsers::AWS::EC2::DetachVolume.new
           }.merge!(options))
         end

lib/fog/aws/requests/ec2/disassociate_address.rb

@@ -17,6 +17,7 @@ module Fog
           request(
             'Action'    => 'DisassociateAddress',
             'PublicIp'  => public_ip,
+            :idempotent => true,
             :parser     => Fog::Parsers::AWS::EC2::Basic.new
           )
         end

lib/fog/aws/requests/ec2/get_console_output.rb

@@ -19,6 +19,7 @@ module Fog
           request(
             'Action'      => 'GetConsoleOutput',
             'InstanceId'  => instance_id,
+            :idempotent   => true,
             :parser       => Fog::Parsers::AWS::EC2::GetConsoleOutput.new
           )
         end

lib/fog/aws/requests/ec2/modify_image_attributes.rb

@@ -20,6 +20,7 @@ module Fog
             'Attribute'     => attribute,
             'ImageId'       => image_id,
             'OperationType' => operation_type,
+            :idempotent     => true,
             :parser         => Fog::Parsers::AWS::EC2::Basic.new
           }.merge!(params))
         end

lib/fog/aws/requests/ec2/reboot_instances.rb

@@ -16,8 +16,9 @@ module Fog
         def reboot_instances(instance_id = [])
           params = AWS.indexed_param('InstanceId', instance_id)
           request({
-            'Action'  => 'RebootInstances',
+            'Action'    => 'RebootInstances',
-            :parser   => Fog::Parsers::AWS::EC2::Basic.new
+            :idempotent => true,
+            :parser     => Fog::Parsers::AWS::EC2::Basic.new
           }.merge!(params))
         end
 

lib/fog/aws/requests/ec2/release_address.rb

@@ -14,6 +14,7 @@ module Fog
           request(
             'Action'    => 'ReleaseAddress',
             'PublicIp'  => public_ip,
+            :idempotent => true,
             :parser     => Fog::Parsers::AWS::EC2::Basic.new
           )
         end

lib/fog/aws/requests/ec2/revoke_security_group_ingress.rb

@@ -24,8 +24,9 @@ module Fog
         #     * 'return'<~Boolean> - success?
         def revoke_security_group_ingress(options = {})
           request({
-            'Action'  => 'RevokeSecurityGroupIngress',
+            'Action'    => 'RevokeSecurityGroupIngress',
-            :parser   => Fog::Parsers::AWS::EC2::Basic.new
+            :idempotent => true,
+            :parser     => Fog::Parsers::AWS::EC2::Basic.new
           }.merge!(options))
         end
 

lib/fog/aws/requests/ec2/terminate_instances.rb

@@ -23,8 +23,9 @@ module Fog
         def terminate_instances(instance_id)
           params = AWS.indexed_param('InstanceId', instance_id)
           request({
-            'Action' => 'TerminateInstances',
+            'Action'    => 'TerminateInstances',
-            :parser  => Fog::Parsers::AWS::EC2::TerminateInstances.new
+            :idempotent => true,
+            :parser     => Fog::Parsers::AWS::EC2::TerminateInstances.new
           }.merge!(params))
         end